Files
my-rook-config/pkg/operator/ceph/object/notification/provisioner.go
T
Travis Nielsen 023608e6fd core: enhance logging with namespaced names
For all of the controllers besides the cluster controller,
the logging now includes the namespaced name of the resource
that is being reconciled. This will help with log troubleshooting
to help analyze logs consistently for the resource being
reconciled.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2025-12-04 12:00:42 -07:00

215 lines
7.6 KiB
Go

/*
Copyright 2021 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package notification to manage a rook bucket notifications.
package notification
import (
"context"
"github.com/aws/aws-sdk-go/service/s3"
"github.com/ceph/go-ceph/rgw/admin"
"github.com/coreos/pkg/capnslog"
bktv1alpha1 "github.com/kube-object-storage/lib-bucket-provisioner/pkg/apis/objectbucket.io/v1alpha1"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/object"
"github.com/rook/rook/pkg/operator/ceph/object/bucket"
"github.com/rook/rook/pkg/util/log"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
)
type provisioner struct {
context *clusterd.Context
clusterInfo *cephclient.ClusterInfo
clusterSpec *cephv1.ClusterSpec
opManagerContext context.Context
owner string
objectStoreName types.NamespacedName
}
func getUserCredentials(adminOpsCtx *object.AdminOpsContext, opManagerContext context.Context, username string) (accessKey string, secretKey string, err error) {
if len(username) == 0 {
err = errors.New("no user name provided")
return
}
var u admin.User
u, err = adminOpsCtx.AdminOpsClient.GetUser(opManagerContext, admin.User{ID: username})
if err != nil {
err = errors.Wrapf(err, "failed to get ceph user %q", username)
return
}
logger.Infof("successfully fetched ceph user %q", username)
accessKey = u.Keys[0].AccessKey
secretKey = u.Keys[0].SecretKey
return
}
func newS3Agent(p provisioner) (*object.S3Agent, error) {
objStore, err := p.context.RookClientset.CephV1().CephObjectStores(p.objectStoreName.Namespace).Get(p.opManagerContext, p.objectStoreName.Name, metav1.GetOptions{})
if err != nil {
return nil, errors.Wrapf(err, "failed to get CephObjectStore %v", p.objectStoreName)
}
objContext, err := object.NewMultisiteContext(p.context, p.clusterInfo, objStore)
if err != nil {
return nil, errors.Wrapf(err, "failed to get object context for CephObjectStore %v", p.objectStoreName)
}
adminOpsCtx, err := object.NewMultisiteAdminOpsContext(objContext, &objStore.Spec)
if err != nil {
return nil, errors.Wrapf(err, "failed to get admin Ops context for CephObjectStore %q", p.objectStoreName)
}
accessKey, secretKey, err := getUserCredentials(adminOpsCtx, p.opManagerContext, p.owner)
if err != nil {
return nil, errors.Wrapf(err, "failed to get owner credentials for %q", p.owner)
}
tlsCert := make([]byte, 0)
insecureTLS := false
if objStore.Spec.IsTLSEnabled() {
tlsCert, insecureTLS, err = object.GetTlsCaCert(objContext, &objStore.Spec)
if err != nil {
return nil, errors.Wrap(err, "failed to fetch TLS certificate for the object store")
}
}
return object.NewS3Agent(accessKey, secretKey, objContext.Endpoint, logger.LevelAt(capnslog.DEBUG), tlsCert, insecureTLS, nil)
}
// TODO: convert all rules without restrictions once the AWS SDK supports that
func createS3FilterRules(filterRules []cephv1.NotificationKeyFilterRule) (s3FilterRules []*s3.FilterRule) {
for _, rule := range filterRules {
s3FilterRules = append(s3FilterRules, &s3.FilterRule{
Name: &rule.DeepCopy().Name,
Value: &rule.DeepCopy().Value,
})
}
return
}
func createS3Filter(filter *cephv1.NotificationFilterSpec) *s3.NotificationConfigurationFilter {
if filter == nil {
return nil
}
return &s3.NotificationConfigurationFilter{
Key: &s3.KeyFilter{
FilterRules: createS3FilterRules(filter.KeyFilters),
},
}
}
func createS3Events(events []cephv1.BucketNotificationEvent) []*string {
// in the AWS S3 library "Events" is required field
// but in our CR it is optional. indicating notifications on all events
if len(events) == 0 {
createdEvent := "s3:ObjectCreated:*"
removedEvent := "s3:ObjectRemoved:*"
return []*string{&createdEvent, &removedEvent}
}
s3Events := []*string{}
for _, event := range events {
stringEvent := string(event)
s3Events = append(s3Events, &stringEvent)
}
return s3Events
}
// Allow overriding this function for unit tests
var createNotificationFunc = createNotification
var createNotification = func(p provisioner, bucket *bktv1alpha1.ObjectBucket, topicARN string, notification *cephv1.CephBucketNotification) error {
bucketName := bucket.Spec.Endpoint.BucketName
bnName := types.NamespacedName{Namespace: notification.Namespace, Name: notification.Name}
s3Agent, err := newS3Agent(p)
if err != nil {
return errors.Wrapf(err, "failed to create S3 agent for CephBucketNotification %q provisioning for bucket %q", bnName, bucketName)
}
_, err = s3Agent.Client.PutBucketNotificationConfiguration(&s3.PutBucketNotificationConfigurationInput{
Bucket: &bucketName,
NotificationConfiguration: &s3.NotificationConfiguration{
TopicConfigurations: []*s3.TopicConfiguration{
{
Events: createS3Events(notification.Spec.Events),
Filter: createS3Filter(notification.Spec.Filter),
Id: &notification.Name,
TopicArn: &topicARN,
},
},
},
})
if err != nil {
return errors.Wrapf(err, "failed to provisioning CephBucketNotification %q for bucket %q", bnName, bucketName)
}
log.NamedInfo(bnName, logger, "CephBucketNotification was created for bucket %q", bucketName)
return nil
}
// Allow overriding this function for unit tests
var getAllNotificationsFunc = getAllRGWNotifications
var getAllRGWNotifications = func(p provisioner, ob *bktv1alpha1.ObjectBucket) ([]string, error) {
bucketName := ob.Spec.Endpoint.BucketName
ownerName := ob.Spec.AdditionalState[bucket.CephUser]
s3Agent, err := newS3Agent(p)
if err != nil {
return nil, errors.Wrapf(err, "failed to create S3 agent for CephBucketNotification provisioning for bucket %q", bucketName)
}
nc, err := s3Agent.Client.GetBucketNotificationConfiguration(&s3.GetBucketNotificationConfigurationRequest{
Bucket: &bucketName,
ExpectedBucketOwner: &ownerName,
})
if err != nil {
return nil, errors.Wrapf(err, "failed to get BucketNotification from bucket %q", bucketName)
}
notificationList := make([]string, 0)
if nc != nil {
for _, tc := range nc.TopicConfigurations {
notificationList = append(notificationList, *tc.Id)
}
}
logger.Debugf("Bucket Notifications %q was listed for bucket %q", notificationList, bucketName)
return notificationList, nil
}
// Allow overriding this function for unit tests
var deleteNotificationFunc = deleteNotification
var deleteNotification = func(p provisioner, bucket *bktv1alpha1.ObjectBucket, notificationId string) error {
bucketName := types.NamespacedName{Namespace: bucket.Namespace, Name: bucket.Name}
s3Agent, err := newS3Agent(p)
if err != nil {
return errors.Wrapf(err, "failed to create S3 agent for deleting all bucket notifications from bucket %q", bucketName)
}
if err := DeleteBucketNotification(s3Agent.Client, &DeleteBucketNotificationRequestInput{
Bucket: &bucket.Spec.Endpoint.BucketName,
}, notificationId); err != nil {
return errors.Wrapf(err, "failed to delete bucket notification %q from bucket %q", notificationId, bucketName)
}
logger.Debugf("bucket notification %q deleted from bucket %q", notificationId, bucketName)
return nil
}