forked from rook/rook
For all of the controllers besides the cluster controller, the logging now includes the namespaced name of the resource that is being reconciled. This will help with log troubleshooting to help analyze logs consistently for the resource being reconciled. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
330 lines
13 KiB
Go
330 lines
13 KiB
Go
/*
|
|
Copyright 2021 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package topic to manage a rook bucket topics.
|
|
package topic
|
|
|
|
import (
|
|
"context"
|
|
"crypto/hmac"
|
|
|
|
//nolint:gosec // sha1 is needed for v2 signatures
|
|
"crypto/sha1"
|
|
"encoding/base64"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/aws/arn"
|
|
"github.com/aws/aws-sdk-go/aws/awserr"
|
|
"github.com/aws/aws-sdk-go/aws/credentials"
|
|
awsrequest "github.com/aws/aws-sdk-go/aws/request"
|
|
awssession "github.com/aws/aws-sdk-go/aws/session"
|
|
awsv4signer "github.com/aws/aws-sdk-go/aws/signer/v4"
|
|
"github.com/aws/aws-sdk-go/service/sns"
|
|
"github.com/coreos/pkg/capnslog"
|
|
"github.com/pkg/errors"
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
|
|
"github.com/rook/rook/pkg/operator/ceph/controller"
|
|
"github.com/rook/rook/pkg/operator/ceph/object"
|
|
"github.com/rook/rook/pkg/util/log"
|
|
corev1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
)
|
|
|
|
type provisioner struct {
|
|
client client.Client
|
|
context *clusterd.Context
|
|
clusterInfo *cephclient.ClusterInfo
|
|
clusterSpec *cephv1.ClusterSpec
|
|
opManagerContext context.Context
|
|
}
|
|
|
|
// A new client type is needed here since topic management is part of AWS's Simple Notification Service (SNS) and not part of S3
|
|
func createSNSClient(p provisioner, objectStoreName types.NamespacedName) (*sns.SNS, error) {
|
|
objStore, err := p.context.RookClientset.CephV1().CephObjectStores(objectStoreName.Namespace).Get(p.opManagerContext, objectStoreName.Name, metav1.GetOptions{})
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to get CephObjectStore %v", objectStoreName)
|
|
}
|
|
|
|
objContext, err := object.NewMultisiteContext(p.context, p.clusterInfo, objStore)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to get object context for CephObjectStore %v", objectStoreName)
|
|
}
|
|
|
|
accessKey, secretKey, err := object.GetAdminOPSUserCredentials(objContext, &objStore.Spec)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed to get Ceph RGW admin ops user credentials")
|
|
}
|
|
|
|
// pass log level to AWS session
|
|
logLevel := aws.LogOff
|
|
if logger.LevelAt(capnslog.DEBUG) {
|
|
logLevel = aws.LogDebugWithHTTPBody
|
|
}
|
|
|
|
// pass TLS indication and certificates to AWS session
|
|
client := http.Client{
|
|
Timeout: object.HttpTimeOut,
|
|
}
|
|
tlsEnabled := objStore.Spec.IsTLSEnabled()
|
|
if tlsEnabled {
|
|
tlsCert, _, err := object.GetTlsCaCert(objContext, &objStore.Spec)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed to get TLS certificate for the object store")
|
|
}
|
|
if len(tlsCert) > 0 {
|
|
client.Transport = object.BuildTransportTLS(tlsCert, false)
|
|
}
|
|
}
|
|
|
|
sess, err := awssession.NewSession(
|
|
aws.NewConfig().
|
|
WithRegion(object.CephRegion).
|
|
WithCredentials(credentials.NewStaticCredentials(accessKey, secretKey, "")).
|
|
WithEndpoint(objContext.Endpoint).
|
|
WithMaxRetries(3).
|
|
WithDisableSSL(!tlsEnabled).
|
|
WithHTTPClient(&client).
|
|
WithLogLevel(logLevel),
|
|
)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to create a new session for CephBucketTopic provisioning with %q", objectStoreName)
|
|
}
|
|
|
|
log.NamedDebug(objectStoreName, logger, "session created. endpoint %q secure %v",
|
|
*sess.Config.Endpoint,
|
|
tlsEnabled,
|
|
)
|
|
snsClient := sns.New(sess)
|
|
// This is a hack to workaround the following RGW issue: https://tracker.ceph.com/issues/50039
|
|
// note that using: "github.com/aws/aws-sdk-go/private/signer/v2"
|
|
// * would add the signature to the query and not the header
|
|
// * use sha246 and not sha1
|
|
customSignername := "cephV2.SignRequestHandler"
|
|
snsClient.Handlers.Sign.Swap(awsv4signer.SignRequestHandler.Name, awsrequest.NamedHandler{
|
|
Name: customSignername,
|
|
Fn: func(req *awsrequest.Request) {
|
|
credentials, err := req.Config.Credentials.Get()
|
|
if err != nil {
|
|
log.NamedDebug(objectStoreName, logger, "%s failed to get credentials: %v", customSignername, err)
|
|
return
|
|
}
|
|
date := req.Time.UTC().Format(time.RFC1123Z)
|
|
contentType := "application/x-www-form-urlencoded; charset=utf-8"
|
|
stringToSign := req.HTTPRequest.Method + "\n\n" + contentType + "\n" + date + "\n" + req.HTTPRequest.URL.Path
|
|
hash := hmac.New(sha1.New, []byte(credentials.SecretAccessKey))
|
|
hash.Write([]byte(stringToSign))
|
|
signature := base64.StdEncoding.EncodeToString(hash.Sum(nil))
|
|
if len(req.HTTPRequest.Header["Authorization"]) == 0 {
|
|
req.HTTPRequest.Header.Add("Authorization", "AWS "+credentials.AccessKeyID+":"+signature)
|
|
}
|
|
if len(req.HTTPRequest.Header["Date"]) == 0 {
|
|
req.HTTPRequest.Header.Add("Date", date)
|
|
}
|
|
},
|
|
})
|
|
return snsClient, nil
|
|
}
|
|
|
|
func createTopicAttributes(p provisioner, topic *cephv1.CephBucketTopic) (map[string]*string, *map[types.UID]*corev1.Secret, error) {
|
|
attr := make(map[string]*string)
|
|
nsName := controller.NsName(topic.Namespace, topic.Name)
|
|
// Currently, referencedSecrets is only used by the kafka endpoint but it
|
|
// could be used by other endpoints in the future.
|
|
referencedSecrets := make(map[types.UID]*corev1.Secret)
|
|
|
|
attr["OpaqueData"] = &topic.Spec.OpaqueData
|
|
persistent := strconv.FormatBool(topic.Spec.Persistent)
|
|
attr["persistent"] = &persistent
|
|
var verifySSL string
|
|
var useSSL string
|
|
if topic.Spec.Endpoint.AMQP != nil {
|
|
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, topic.Spec.Endpoint.AMQP.URI)
|
|
attr["push-endpoint"] = &topic.Spec.Endpoint.AMQP.URI
|
|
attr["amqp-exchange"] = &topic.Spec.Endpoint.AMQP.Exchange
|
|
attr["amqp-ack-level"] = &topic.Spec.Endpoint.AMQP.AckLevel
|
|
verifySSL = strconv.FormatBool(!topic.Spec.Endpoint.AMQP.DisableVerifySSL)
|
|
attr["verify-ssl"] = &verifySSL
|
|
}
|
|
if topic.Spec.Endpoint.HTTP != nil {
|
|
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, topic.Spec.Endpoint.HTTP.URI)
|
|
attr["push-endpoint"] = &topic.Spec.Endpoint.HTTP.URI
|
|
verifySSL = strconv.FormatBool(!topic.Spec.Endpoint.HTTP.DisableVerifySSL)
|
|
attr["verify-ssl"] = &verifySSL
|
|
cloudEvents := strconv.FormatBool(topic.Spec.Endpoint.HTTP.SendCloudEvents)
|
|
attr["cloudevents"] = &cloudEvents
|
|
}
|
|
if topic.Spec.Endpoint.Kafka != nil {
|
|
kafka := topic.Spec.Endpoint.Kafka
|
|
|
|
uri, err := url.Parse(kafka.URI)
|
|
if err != nil {
|
|
// URI could contain a passphrase...
|
|
return nil, nil, errors.Wrapf(err, "failed to parse CephBucketTopic %q .spec.endpoint.kafka.URI %q", nsName, kafka.URI)
|
|
}
|
|
|
|
// If UserSecretRef or PasswordRef is set, we need to parse the URI and insert the
|
|
// credentials as http basic auth. If basic auth was already set as part of
|
|
// the URI string, it will be overridden.
|
|
if kafka.UserSecretRef != nil || kafka.PasswordSecretRef != nil {
|
|
var user, pass string
|
|
|
|
if kafka.UserSecretRef != nil {
|
|
var secret *corev1.Secret
|
|
user, secret, err = p.getSecretValue(kafka.UserSecretRef, topic.Namespace)
|
|
if err != nil {
|
|
return nil, nil, errors.Wrapf(err, "failed to get secret value from CephBucketTopic %q .spec.endpoint.kafka.userSecretRef %q", nsName, kafka.UserSecretRef)
|
|
}
|
|
|
|
log.NamedDebug(nsName, logger, "CephBucketTopic %q references secret %q", nsName, client.ObjectKeyFromObject(secret))
|
|
referencedSecrets[secret.UID] = secret
|
|
}
|
|
if kafka.PasswordSecretRef != nil {
|
|
var secret *corev1.Secret
|
|
pass, secret, err = p.getSecretValue(kafka.PasswordSecretRef, topic.Namespace)
|
|
if err != nil {
|
|
return nil, nil, errors.Wrapf(err, "failed to get secret value from CephBucketTopic %q .spec.endpoint.kafka.passwordSecretRef %q", nsName, kafka.PasswordSecretRef)
|
|
}
|
|
log.NamedDebug(nsName, logger, "CephBucketTopic %q references secret %q", nsName, client.ObjectKeyFromObject(secret))
|
|
referencedSecrets[secret.UID] = secret
|
|
}
|
|
|
|
uri.User = url.UserPassword(user, pass)
|
|
}
|
|
|
|
// do not log passphrases, if set
|
|
log.NamedInfo(nsName, logger, "creating CephBucketTopic %q with endpoint %q", nsName, uri.Redacted())
|
|
|
|
kafkaUri := uri.String()
|
|
attr["push-endpoint"] = &kafkaUri
|
|
useSSL = strconv.FormatBool(topic.Spec.Endpoint.Kafka.UseSSL)
|
|
attr["use-ssl"] = &useSSL
|
|
attr["kafka-ack-level"] = &topic.Spec.Endpoint.Kafka.AckLevel
|
|
verifySSL = strconv.FormatBool(!topic.Spec.Endpoint.Kafka.DisableVerifySSL)
|
|
attr["verify-ssl"] = &verifySSL
|
|
attr["mechanism"] = &topic.Spec.Endpoint.Kafka.Mechanism
|
|
}
|
|
|
|
return attr, &referencedSecrets, nil
|
|
}
|
|
|
|
// Allow overriding this function for unit tests
|
|
var createTopicFunc = createTopic
|
|
|
|
func createTopic(p provisioner, topic *cephv1.CephBucketTopic) (*string, *map[types.UID]*corev1.Secret, error) {
|
|
nsName := controller.NsName(topic.Namespace, topic.Name)
|
|
|
|
snsClient, err := createSNSClient(p, types.NamespacedName{Name: topic.Spec.ObjectStoreName, Namespace: topic.Spec.ObjectStoreNamespace})
|
|
if err != nil {
|
|
return nil, nil, errors.Wrapf(err, "failed to create SNS client for CephBucketTopic %q provisioning", nsName)
|
|
}
|
|
attr, referencedSecrets, err := createTopicAttributes(p, topic)
|
|
if err != nil {
|
|
return nil, nil, errors.Wrapf(err, "failed to generate topic attributes for CephBucketTopic %q", nsName)
|
|
}
|
|
topicOutput, err := snsClient.CreateTopic(&sns.CreateTopicInput{
|
|
Name: &topic.Name,
|
|
Attributes: attr,
|
|
})
|
|
if err != nil {
|
|
return nil, nil, errors.Wrapf(err, "failed to provision CephBucketTopic %q", nsName)
|
|
}
|
|
|
|
log.NamedInfo(nsName, logger, "CephBucketTopic %q created with ARN %q", nsName, *topicOutput.TopicArn)
|
|
|
|
return topicOutput.TopicArn, referencedSecrets, nil
|
|
}
|
|
|
|
// Allow overriding this function for unit tests
|
|
var deleteTopicFunc = deleteTopic
|
|
|
|
func deleteTopic(p provisioner, topic *cephv1.CephBucketTopic) error {
|
|
nsName := controller.NsName(topic.Namespace, topic.Name)
|
|
log.NamedInfo(nsName, logger, "deleting CephBucketTopic %q", nsName)
|
|
|
|
if topic.Status.ARN == nil {
|
|
log.NamedWarning(nsName, logger, "ignore CephBucketTopic deletion. topic %q was never successfully provisioned", nsName)
|
|
return nil
|
|
}
|
|
|
|
snsClient, err := createSNSClient(p, types.NamespacedName{Name: topic.Spec.ObjectStoreName, Namespace: topic.Spec.ObjectStoreNamespace})
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to create SNS client for CephBucketTopic %q deletion", nsName)
|
|
}
|
|
|
|
_, err = snsClient.DeleteTopic(&sns.DeleteTopicInput{TopicArn: topic.Status.ARN})
|
|
if err != nil {
|
|
if err.(awserr.Error).Code() != sns.ErrCodeNotFoundException {
|
|
return errors.Wrapf(err, "failed to delete CephBucketTopic %q", nsName)
|
|
}
|
|
log.NamedWarning(nsName, logger, "ignore CephBucketTopic deletion. %q was already deleted", nsName)
|
|
}
|
|
|
|
log.NamedInfo(nsName, logger, "CephBucketTopic %q deleted", nsName)
|
|
|
|
return nil
|
|
}
|
|
|
|
func GetProvisioned(cl client.Client, ctx context.Context, topicName types.NamespacedName) (*cephv1.CephBucketTopic, error) {
|
|
bucketTopic := &cephv1.CephBucketTopic{}
|
|
if err := cl.Get(ctx, topicName, bucketTopic); err != nil {
|
|
return nil, errors.Wrapf(err, "failed to retrieve CephBucketTopic %q", topicName)
|
|
}
|
|
if bucketTopic.Status == nil || bucketTopic.Status.ARN == nil {
|
|
return nil, errors.Errorf("no ARN in topic. CephBucketTopic %q was not provisioned yet", topicName)
|
|
}
|
|
topicARN := *bucketTopic.Status.ARN
|
|
parsedTopicARN, err := arn.Parse(topicARN)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to parse CephBucketTopic %q ARN %q", topicName, topicARN)
|
|
}
|
|
if strings.ToLower(parsedTopicARN.Service) != "sns" {
|
|
return nil, errors.Errorf("CephBucketTopic %q ARN %q must have 'sns' service", topicName, topicARN)
|
|
}
|
|
if parsedTopicARN.Resource == "" {
|
|
return nil, errors.Errorf("CephBucketTopic %q is missing a topic inside ARN %q", topicName, topicARN)
|
|
}
|
|
log.NamedDebug(topicName, logger, "CephBucketTopic found with valid ARN %q", topicARN)
|
|
|
|
return bucketTopic, nil
|
|
}
|
|
|
|
// getSecretValue returns the value of key in a kubernetes secret
|
|
func (p *provisioner) getSecretValue(selector *corev1.SecretKeySelector, namespace string) (string, *corev1.Secret, error) {
|
|
secret := &corev1.Secret{}
|
|
namespacedName := types.NamespacedName{
|
|
Name: selector.Name,
|
|
Namespace: namespace,
|
|
}
|
|
if err := p.client.Get(p.opManagerContext, namespacedName, secret); err != nil {
|
|
return "", nil, errors.Wrapf(err, "failed to get secret %q", namespacedName)
|
|
}
|
|
value, ok := secret.Data[selector.Key]
|
|
if !ok {
|
|
return "", nil, errors.Errorf("failed to find key %q in secret %q", selector.Key, namespacedName)
|
|
}
|
|
|
|
return string(value), secret, nil
|
|
}
|