Files
my-rook-config/pkg/operator/ceph/cluster/mon/spec_test.go
T
Sébastien Han bed14cfd71 ceph: improve upgrade on image change
From now on, Rook will only perform check before upgrades when there is
an actual upgrade. So if the Ceph image changed and a new version is
desired Rook will go through all the daemons and update them one by one
and perform checks in between.

Closes: https://github.com/rook/rook/issues/3583
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-08-29 10:18:19 +02:00

223 lines
7.1 KiB
Go

/*
Copyright 2016 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package mon
import (
"sync"
"testing"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
rook "github.com/rook/rook/pkg/apis/rook.io/v1alpha2"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/operator/ceph/config"
opspec "github.com/rook/rook/pkg/operator/ceph/spec"
cephtest "github.com/rook/rook/pkg/operator/ceph/test"
testop "github.com/rook/rook/pkg/operator/test"
"github.com/stretchr/testify/assert"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
func TestPodSpecs(t *testing.T) {
testPodSpec(t, "a", true)
testPodSpec(t, "mon0", true)
testPodSpec(t, "a", false)
testPodSpec(t, "mon0", false)
}
func testPodSpec(t *testing.T, monID string, pvc bool) {
clientset := testop.New(1)
c := New(
&clusterd.Context{Clientset: clientset, ConfigDir: "/var/lib/rook"},
"ns",
"/var/lib/rook",
cephv1.NetworkSpec{},
metav1.OwnerReference{},
&sync.Mutex{},
false,
)
setCommonMonProperties(c, 0, cephv1.MonSpec{Count: 3, AllowMultiplePerNode: true}, "rook/rook:myversion")
c.spec.CephVersion = cephv1.CephVersionSpec{Image: "ceph/ceph:myceph"}
c.spec.Resources = map[string]v1.ResourceRequirements{}
c.spec.Resources["mon"] = v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: *resource.NewQuantity(200.0, resource.BinarySI),
v1.ResourceMemory: *resource.NewQuantity(1337.0, resource.BinarySI),
},
Requests: v1.ResourceList{
v1.ResourceCPU: *resource.NewQuantity(100.0, resource.BinarySI),
v1.ResourceMemory: *resource.NewQuantity(500.0, resource.BinarySI),
},
}
monConfig := testGenMonConfig(monID)
d := c.makeDeployment(monConfig)
assert.NotNil(t, d)
if pvc {
d.Spec.Template.Spec.Volumes = append(
d.Spec.Template.Spec.Volumes, opspec.DaemonVolumesDataPVC("i-am-pvc"))
} else {
d.Spec.Template.Spec.Volumes = append(
d.Spec.Template.Spec.Volumes, opspec.DaemonVolumesDataHostPath(monConfig.DataPathMap)...)
}
// Deployment should have Ceph labels
cephtest.AssertLabelsContainCephRequirements(t, d.ObjectMeta.Labels,
config.MonType, monID, AppName, "ns")
podTemplate := cephtest.NewPodTemplateSpecTester(t, &d.Spec.Template)
podTemplate.RunFullSuite(config.MonType, monID, AppName, "ns", "ceph/ceph:myceph",
"200", "100", "1337", "500" /* resources */)
}
func TestDeploymentPVCSpec(t *testing.T) {
clientset := testop.New(1)
c := New(
&clusterd.Context{Clientset: clientset, ConfigDir: "/var/lib/rook"},
"ns",
"/var/lib/rook",
cephv1.NetworkSpec{},
metav1.OwnerReference{},
&sync.Mutex{},
false,
)
setCommonMonProperties(c, 0, cephv1.MonSpec{Count: 3, AllowMultiplePerNode: true}, "rook/rook:myversion")
c.spec.CephVersion = cephv1.CephVersionSpec{Image: "ceph/ceph:myceph"}
c.spec.Resources = map[string]v1.ResourceRequirements{}
c.spec.Resources["mon"] = v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: *resource.NewQuantity(200.0, resource.BinarySI),
v1.ResourceMemory: *resource.NewQuantity(1337.0, resource.BinarySI),
},
Requests: v1.ResourceList{
v1.ResourceCPU: *resource.NewQuantity(100.0, resource.BinarySI),
v1.ResourceMemory: *resource.NewQuantity(500.0, resource.BinarySI),
},
}
monConfig := testGenMonConfig("a")
// configured with default storage request
c.spec.Mon.VolumeClaimTemplate = &v1.PersistentVolumeClaim{}
pvc, err := c.makeDeploymentPVC(monConfig)
assert.NoError(t, err)
defaultReq, err := resource.ParseQuantity(cephMonDefaultStorageRequest)
assert.NoError(t, err)
assert.Equal(t, pvc.Spec.Resources.Requests[v1.ResourceStorage], defaultReq)
// limit is preserved
req, err := resource.ParseQuantity("22Gi")
assert.NoError(t, err)
c.spec.Mon.VolumeClaimTemplate = &v1.PersistentVolumeClaim{
Spec: v1.PersistentVolumeClaimSpec{
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{v1.ResourceStorage: req},
},
},
}
pvc, err = c.makeDeploymentPVC(monConfig)
assert.NoError(t, err)
assert.Equal(t, pvc.Spec.Resources.Limits[v1.ResourceStorage], req)
// request is preserved
req, err = resource.ParseQuantity("23Gi")
assert.NoError(t, err)
c.spec.Mon.VolumeClaimTemplate = &v1.PersistentVolumeClaim{
Spec: v1.PersistentVolumeClaimSpec{
Resources: v1.ResourceRequirements{
Requests: v1.ResourceList{v1.ResourceStorage: req},
},
},
}
pvc, err = c.makeDeploymentPVC(monConfig)
assert.NoError(t, err)
assert.Equal(t, pvc.Spec.Resources.Requests[v1.ResourceStorage], req)
}
func testPodSpecPlacement(t *testing.T, hostNet, allowMulti bool, req, pref int, placement *rook.Placement) {
clientset := testop.New(1)
c := New(
&clusterd.Context{Clientset: clientset, ConfigDir: "/var/lib/rook"},
"ns",
"/var/lib/rook",
cephv1.NetworkSpec{HostNetwork: hostNet},
metav1.OwnerReference{},
&sync.Mutex{},
false,
)
setCommonMonProperties(c, 0, cephv1.MonSpec{Count: 3, AllowMultiplePerNode: allowMulti}, "rook/rook:myversion")
monConfig := testGenMonConfig("a")
if placement != nil {
c.spec.Placement = rook.PlacementSpec{}
c.spec.Placement["mon"] = *placement
}
d := c.makeDeployment(monConfig)
assert.NotNil(t, d)
p := cephv1.GetMonPlacement(c.spec.Placement)
c.setPodPlacement(&d.Spec.Template.Spec, p, nil)
// should have a required anti-affnity and no preferred anti-affinity
assert.Equal(t,
req,
len(d.Spec.Template.Spec.Affinity.PodAntiAffinity.RequiredDuringSchedulingIgnoredDuringExecution))
assert.Equal(t,
pref,
len(d.Spec.Template.Spec.Affinity.PodAntiAffinity.PreferredDuringSchedulingIgnoredDuringExecution))
}
func makePlacement() rook.Placement {
return rook.Placement{
PodAntiAffinity: &v1.PodAntiAffinity{
RequiredDuringSchedulingIgnoredDuringExecution: []v1.PodAffinityTerm{
{
TopologyKey: v1.LabelZoneFailureDomain,
},
},
PreferredDuringSchedulingIgnoredDuringExecution: []v1.WeightedPodAffinityTerm{
{
PodAffinityTerm: v1.PodAffinityTerm{
TopologyKey: v1.LabelZoneFailureDomain,
},
},
},
},
}
}
func TestPodSpecPlacement(t *testing.T) {
// no placement settings in the crd
testPodSpecPlacement(t, true, true, 1, 0, nil)
testPodSpecPlacement(t, true, false, 1, 0, nil)
testPodSpecPlacement(t, false, true, 0, 1, nil)
testPodSpecPlacement(t, false, false, 1, 0, nil)
// crd has other preferred and required anti-affinity setting
p := makePlacement()
testPodSpecPlacement(t, true, true, 2, 1, &p)
p = makePlacement()
testPodSpecPlacement(t, true, false, 2, 1, &p)
p = makePlacement()
testPodSpecPlacement(t, false, true, 1, 2, &p)
p = makePlacement()
testPodSpecPlacement(t, false, false, 2, 1, &p)
}