Files
my-rook-config/pkg/operator/ceph/object/config_test.go
T
Sébastien Han 7d54cac453 ceph: rgw: set proper port syntax on beast
The beast fronted configuration for rgw is quite different than civetweb
so we adapted the construct of the arg line based on that configuration
requirement.

Closes: https://github.com/rook/rook/issues/3411
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-07-08 17:54:43 +02:00

136 lines
4.4 KiB
Go

/*
Copyright 2016 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package object
import (
"testing"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
cephconfig "github.com/rook/rook/pkg/daemon/ceph/config"
cephver "github.com/rook/rook/pkg/operator/ceph/version"
"github.com/stretchr/testify/assert"
)
func newConfig() *clusterConfig {
clusterInfo := &cephconfig.ClusterInfo{
CephVersion: cephver.Mimic,
}
return &clusterConfig{
store: cephv1.CephObjectStore{
Spec: cephv1.ObjectStoreSpec{
Gateway: cephv1.GatewaySpec{},
}},
clusterInfo: clusterInfo}
}
func TestPortString(t *testing.T) {
// No port or secure port on civetweb
cfg := newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
result := cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "", result)
// No port or secure port on beast
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Nautilus
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "", result)
// Insecure port on civetweb
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
cfg.store.Spec.Gateway.Port = 80
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "port=80", result)
// Insecure port on beast
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Nautilus
cfg.store.Spec.Gateway.Port = 80
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "port=80", result)
// Secure port on civetweb
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
cfg.store.Spec.Gateway.SecurePort = 443
cfg.store.Spec.Gateway.SSLCertificateRef = "some-k8s-key-secret"
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "port=443s ssl_certificate=/etc/ceph/private/rgw-cert.pem", result)
// Both ports on civetweb
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
cfg.store.Spec.Gateway.Port = 80
cfg.store.Spec.Gateway.SecurePort = 443
cfg.store.Spec.Gateway.SSLCertificateRef = "some-k8s-key-secret"
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "port=80+443s ssl_certificate=/etc/ceph/private/rgw-cert.pem", result)
// Secure port on beast
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Nautilus
cfg.store.Spec.Gateway.SecurePort = 443
cfg.store.Spec.Gateway.SSLCertificateRef = "some-k8s-key-secret"
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "ssl_port=443 ssl_certificate=/etc/ceph/private/rgw-cert.pem", result)
// Both ports on beast
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Nautilus
cfg.store.Spec.Gateway.Port = 80
cfg.store.Spec.Gateway.SecurePort = 443
cfg.store.Spec.Gateway.SSLCertificateRef = "some-k8s-key-secret"
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "port=80 ssl_port=443 ssl_certificate=/etc/ceph/private/rgw-cert.pem", result)
// Secure port requires the cert on civetweb
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
cfg.store.Spec.Gateway.SecurePort = 443
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "", result)
// Secure port requires the cert on beast
cfg = newConfig()
cfg.clusterInfo.CephVersion = cephver.Nautilus
cfg.store.Spec.Gateway.SecurePort = 443
result = cfg.portString(cfg.clusterInfo.CephVersion)
assert.Equal(t, "", result)
}
func TestFrontend(t *testing.T) {
cfg := newConfig()
cfg.clusterInfo.CephVersion = cephver.Mimic
result := rgwFrontend(cfg.clusterInfo.CephVersion)
assert.Equal(t, "civetweb", result)
cfg.clusterInfo.CephVersion = cephver.Nautilus
result = rgwFrontend(cfg.clusterInfo.CephVersion)
assert.Equal(t, "beast", result)
cfg.clusterInfo.CephVersion = cephver.Octopus
result = rgwFrontend(cfg.clusterInfo.CephVersion)
assert.Equal(t, "beast", result)
}
func TestGenerateCephXUser(t *testing.T) {
fakeUser := generateCephXUser("rook-ceph-rgw-fake-store-fake-user")
assert.Equal(t, "client.fake.store.fake.user", fakeUser)
}