Files
my-rook-config/tests/integration/ceph_base_block_test.go
T
Travis Nielsen e32729269f ceph: clean up block integration tests more reliably
The block integration tests are a source of intermittent failures
in the CI. The PVCs were not being confirmed as removed before the
pools were deleted. Then the pool would not be removed since there
might still be a block image from the PVC that wasn't deleted yet.
Now the tests will ensure the PVCs and their block images are
removed before the pool is deleted.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2019-10-30 15:37:35 -06:00

447 lines
17 KiB
Go

/*
Copyright 2016 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package integration
import (
"fmt"
"strconv"
"time"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/operator/k8sutil"
"github.com/rook/rook/tests/framework/clients"
"github.com/rook/rook/tests/framework/installer"
"github.com/rook/rook/tests/framework/utils"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
appsv1 "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/version"
)
// Smoke Test for Block Storage - Test check the following operations on Block Storage in order
// Create,Mount,Write,Read,Expand,Unmount and Delete.
func runBlockE2ETest(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite, namespace string) {
podName := "block-test"
poolName := "replicapool"
storageClassName := "rook-ceph-block"
blockName := "block-pv-claim"
podNameWithPVRetained := "block-test-retained"
poolNameRetained := "replicapoolretained"
storageClassNameRetained := "rook-ceph-block-retained"
blockNameRetained := "block-pv-claim-retained"
defer blockTestDataCleanUp(helper, k8sh, s, namespace, poolName, storageClassName, blockName, podName)
defer blockTestDataCleanUp(helper, k8sh, s, namespace, poolNameRetained, storageClassNameRetained, blockNameRetained, podNameWithPVRetained)
logger.Infof("Block Storage End to End Integration Test - create, mount, write to, read from, and unmount")
logger.Infof("Running on Rook Cluster %s", namespace)
logger.Infof("Step 0 : Get Initial List Block")
initBlockImages, _ := helper.BlockClient.List(namespace)
assert.Equal(s.T(), 0, len(initBlockImages), "there should not already be any images in the pool")
logger.Infof("step 1: Create block storage")
cbErr := helper.PoolClient.CreateStorageClassAndPvc(namespace, poolName, storageClassName, "Delete", blockName, "ReadWriteOnce")
require.Nil(s.T(), cbErr)
require.True(s.T(), retryBlockImageCountCheck(helper, 1, namespace), "Make sure a new block is created")
cbErr = helper.PoolClient.CreateStorageClassAndPvc(namespace, poolNameRetained, storageClassNameRetained, "Retain", blockNameRetained, "ReadWriteOnce")
require.Nil(s.T(), cbErr)
require.True(s.T(), retryBlockImageCountCheck(helper, 2, namespace), "Make sure another new block is created")
logger.Infof("Block Storage created successfully")
require.True(s.T(), k8sh.WaitUntilPVCIsBound(defaultNamespace, blockName), "Make sure PVC is Bound")
require.True(s.T(), k8sh.WaitUntilPVCIsBound(defaultNamespace, blockNameRetained), "Make sure PVC with reclaimPolicy:Retain is Bound")
logger.Infof("step 2: Mount block storage")
crdName := createPodWithBlock(helper, k8sh, s, namespace, blockName, podName)
crdNameRetained := createPodWithBlock(helper, k8sh, s, namespace, blockNameRetained, podNameWithPVRetained)
logger.Infof("step 3: Write to block storage")
message := "Smoke Test Data for Block storage"
filename := "bsFile1"
err := k8sh.WriteToPod("", podName, filename, message)
require.Nil(s.T(), err)
logger.Infof("Write to Block storage successfully")
logger.Infof("step 4: Read from block storage")
err = k8sh.ReadFromPod("", podName, filename, message)
require.Nil(s.T(), err)
logger.Infof("Read from Block storage successfully")
logger.Infof("step 5: Restart the OSDs to confirm they are still healthy after restart")
restartOSDPods(k8sh, s, namespace)
logger.Infof("step 6: Read from block storage again")
err = k8sh.ReadFromPod("", podName, filename, message)
require.Nil(s.T(), err)
logger.Infof("Read from Block storage successfully")
v := version.MustParseSemantic(k8sh.GetK8sServerVersion())
if v.AtLeast(version.MustParseSemantic("1.14.0")) {
logger.Infof("additional step: Expand block storage")
// Expanding the image by applying new PVC specs
err = helper.BlockClient.CreatePvc(blockName, storageClassName, "ReadWriteOnce", "2M")
require.Nil(s.T(), err)
// Once the pod using the volume is terminated, the filesystem is expanded and the size of the PVC is increased.
err = k8sh.DeletePod(k8sutil.DefaultNamespace, podName)
require.Nil(s.T(), err)
_, err = helper.BlockClient.BlockMap(getBlockPodDefinition(podName, blockName, false))
require.Nil(s.T(), err)
require.True(s.T(), k8sh.IsPodRunning(podName, defaultNamespace), "Make sure new pod is running")
require.True(s.T(), k8sh.WaitUntilPVCIsExpanded(defaultNamespace, blockName, "2M"), "Make sure PVC is expanded")
logger.Infof("Block Storage successfully expanded")
}
logger.Infof("step 7: Mount same block storage on a different pod. Should not be allowed")
otherPod := "block-test2"
_, mtErr := helper.BlockClient.BlockMap(getBlockPodDefinition(otherPod, blockName, false))
require.Nil(s.T(), mtErr)
require.True(s.T(), k8sh.IsPodInError(otherPod, defaultNamespace, "FailedMount", "Volume is already attached by pod"), "make sure block-test2 pod errors out while mounting the volume")
logger.Infof("Block Storage successfully fenced")
logger.Infof("step 8: Delete fenced pod")
unmtErr := k8sh.DeletePod(k8sutil.DefaultNamespace, otherPod)
require.Nil(s.T(), unmtErr)
require.True(s.T(), k8sh.IsPodTerminated(otherPod, defaultNamespace), "make sure block-test2 pod is terminated")
logger.Infof("Fenced pod deleted successfully")
logger.Infof("step 9: Unmount block storage")
unmtErr = k8sh.DeletePod(k8sutil.DefaultNamespace, podName)
require.Nil(s.T(), unmtErr)
unmtErr = k8sh.DeletePod(k8sutil.DefaultNamespace, podNameWithPVRetained)
require.Nil(s.T(), unmtErr)
require.True(s.T(), k8sh.IsVolumeResourceAbsent(installer.SystemNamespace(namespace), crdName), fmt.Sprintf("make sure Volume %s is deleted", crdName))
require.True(s.T(), k8sh.IsVolumeResourceAbsent(installer.SystemNamespace(namespace), crdNameRetained), fmt.Sprintf("make sure Volume %s is deleted", crdNameRetained))
require.True(s.T(), k8sh.IsPodTerminated(podName, defaultNamespace), "make sure block-test pod is terminated")
require.True(s.T(), k8sh.IsPodTerminated(podNameWithPVRetained, defaultNamespace), "make sure block-test-retained pod is terminated")
logger.Infof("Block Storage unmounted successfully")
logger.Infof("step 10: Deleting block storage")
pvName, err := k8sh.GetPVCVolumeName(defaultNamespace, blockName)
pv, _ := k8sh.GetPV(pvName)
require.Nil(s.T(), err)
dbErr := helper.PoolClient.DeletePvc(defaultNamespace, blockName)
require.Nil(s.T(), dbErr)
require.Equal(s.T(), string((*pv).Spec.PersistentVolumeReclaimPolicy), "Delete")
require.True(s.T(), retryPVCheck(k8sh, pvName, false, ""))
logger.Infof("PV: %s deleted successfully", pvName)
require.True(s.T(), retryBlockImageCountCheck(helper, 1, namespace), "Make sure a block is deleted")
logger.Infof("Block Storage deleted successfully")
pvName, err = k8sh.GetPVCVolumeName(defaultNamespace, blockNameRetained)
pv, _ = k8sh.GetPV(pvName)
require.Nil(s.T(), err)
dbErr = helper.PoolClient.DeletePvc(defaultNamespace, blockNameRetained)
require.Nil(s.T(), dbErr)
require.Equal(s.T(), string((*pv).Spec.PersistentVolumeReclaimPolicy), "Retain")
require.True(s.T(), retryPVCheck(k8sh, pvName, true, "Released"))
require.True(s.T(), retryBlockImageCountCheck(helper, 1, namespace), "Make sure a block is retained")
logger.Infof("Block Storage retained")
k8sh.Kubectl("delete", "pv", pvName)
logger.Infof("step 11: Delete storage classes and pools")
err = helper.PoolClient.DeletePool(helper.BlockClient, namespace, poolName)
assert.NoError(s.T(), err)
err = helper.PoolClient.DeletePool(helper.BlockClient, namespace, poolNameRetained)
assert.NoError(s.T(), err)
err = helper.PoolClient.DeleteStorageClass(storageClassName)
assert.NoError(s.T(), err)
err = helper.PoolClient.DeleteStorageClass(storageClassNameRetained)
assert.NoError(s.T(), err)
}
func createPodWithBlock(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite, namespace, blockName, podName string) string {
_, mtErr := helper.BlockClient.BlockMap(getBlockPodDefinition(podName, blockName, false))
require.Nil(s.T(), mtErr)
crdName, err := k8sh.GetVolumeResourceName(defaultNamespace, blockName)
require.Nil(s.T(), err)
require.True(s.T(), k8sh.IsVolumeResourcePresent(installer.SystemNamespace(namespace), crdName), fmt.Sprintf("make sure Volume %s is created", crdName))
require.True(s.T(), k8sh.IsPodRunning(podName, defaultNamespace), "make sure block-test pod is in running state")
logger.Infof("Block Storage Mounted successfully")
return crdName
}
func restartOSDPods(k8sh *utils.K8sHelper, s suite.Suite, namespace string) {
osdLabel := "app=rook-ceph-osd"
// Delete the osd pod(s)
logger.Infof("Deleting osd pod(s)")
pods, err := k8sh.Clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: osdLabel})
for _, pod := range pods.Items {
options := metav1.DeleteOptions{}
err = k8sh.Clientset.CoreV1().Pods(namespace).Delete(pod.Name, &options)
assert.Nil(s.T(), err)
logger.Infof("Waiting for osd pod %s to be deleted", pod.Name)
deleted := k8sh.WaitUntilPodIsDeleted(pod.Name, namespace)
assert.True(s.T(), deleted)
}
// Wait for the new pods to run
logger.Infof("Waiting for new osd pod to run")
err = k8sh.WaitForLabeledPodsToRun(osdLabel, namespace)
assert.Nil(s.T(), err)
}
func runBlockE2ETestLite(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite, clusterNamespace string, version cephv1.CephVersionSpec) {
logger.Infof("Block Storage End to End Integration Test - create storageclass,pool and pvc")
logger.Infof("Running on Rook Cluster %s", clusterNamespace)
poolName := "rookpool"
storageClassName := "rook-ceph-block-lite"
blockName := "test-block-claim-lite"
podName := "test-pod-lite"
defer blockTestDataCleanUp(helper, k8sh, s, clusterNamespace, poolName, storageClassName, blockName, podName)
setupBlockLite(helper, k8sh, s, clusterNamespace, poolName, storageClassName, blockName, podName, version)
}
func setupBlockLite(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite,
clusterNamespace, poolName, storageClassName, blockName, podName string, version cephv1.CephVersionSpec) {
// Check initial number of blocks
initialBlocks, err := helper.BlockClient.List(clusterNamespace)
require.Nil(s.T(), err)
initBlockCount := len(initialBlocks)
assert.Equal(s.T(), 0, initBlockCount, "why is there already a block image in the new pool?")
logger.Infof("step : Create Pool,StorageClass and PVC")
err = helper.PoolClient.CreateStorageClassAndPvc(clusterNamespace, poolName, storageClassName, "Delete", blockName, "ReadWriteOnce")
require.NoError(s.T(), err)
require.True(s.T(), k8sh.WaitUntilPVCIsBound(defaultNamespace, blockName))
// Make sure new block is created
b, err := helper.BlockClient.List(clusterNamespace)
assert.Nil(s.T(), err)
assert.Equal(s.T(), 1, len(b), "Make sure new block image is created")
poolExists, err := helper.PoolClient.CephPoolExists(clusterNamespace, poolName)
assert.Nil(s.T(), err)
assert.True(s.T(), poolExists)
}
func deleteBlockLite(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite, clusterNamespace, poolName, storageClassName, blockName string) {
logger.Infof("deleteBlockLite: cleaning up after test")
// Delete pvc and storageclass
err := helper.PoolClient.DeletePvc(defaultNamespace, blockName)
assertNoErrorUnlessNotFound(s, err)
assert.True(s.T(), k8sh.WaitUntilPVCIsDeleted(defaultNamespace, blockName))
assert.True(s.T(), retryBlockImageCountCheck(helper, 0, clusterNamespace), "Make sure block images were deleted")
err = helper.PoolClient.DeletePool(helper.BlockClient, clusterNamespace, poolName)
assertNoErrorUnlessNotFound(s, err)
err = helper.PoolClient.DeleteStorageClass(storageClassName)
assertNoErrorUnlessNotFound(s, err)
b, _ := helper.BlockClient.List(clusterNamespace)
assert.Equal(s.T(), 0, len(b), "Make sure new block image is deleted")
checkPoolDeleted(helper, s, clusterNamespace, poolName)
}
func assertNoErrorUnlessNotFound(s suite.Suite, err error) {
if err == nil || errors.IsNotFound(err) {
return
}
assert.NoError(s.T(), err)
}
func checkPoolDeleted(helper *clients.TestClient, s suite.Suite, namespace, name string) {
i := 0
for i < utils.RetryLoop {
found, err := helper.PoolClient.CephPoolExists(namespace, name)
if err != nil {
// try again on failure since the pool may have been in an unexpected state while deleting
logger.Warningf("error getting pools. %+v", err)
} else if !found {
logger.Infof("pool %s is deleted", name)
return
}
i++
logger.Infof("pool %s still exists", name)
time.Sleep(time.Second * utils.RetryInterval)
}
assert.Fail(s.T(), fmt.Sprintf("pool %s was not deleted", name))
}
func blockTestDataCleanUp(helper *clients.TestClient, k8sh *utils.K8sHelper, s suite.Suite, namespace, poolname, storageclassname, blockname, podName string) {
logger.Infof("Cleaning up block storage")
k8sh.DeletePod(k8sutil.DefaultNamespace, podName)
deleteBlockLite(helper, k8sh, s, namespace, poolname, storageclassname, blockname)
}
// periodically checking if block image count has changed to expected value
// When creating pvc in k8s platform, it may take some time for the block Image to be bounded
func retryBlockImageCountCheck(helper *clients.TestClient, expectedImageCount int, namespace string) bool {
inc := 0
for inc < utils.RetryLoop {
logger.Infof("Getting list of blocks (expecting %d)", (expectedImageCount))
blockImages, _ := helper.BlockClient.List(namespace)
if expectedImageCount == len(blockImages) {
return true
}
time.Sleep(time.Second * utils.RetryInterval)
inc++
}
return false
}
func retryPVCheck(k8sh *utils.K8sHelper, name string, exists bool, status string) bool {
inc := 0
for inc < utils.RetryLoop {
pv, err := k8sh.GetPV(name)
if err != nil {
if !exists {
return true
}
}
if exists {
if string((*pv).Status.Phase) == status {
return true
}
}
time.Sleep(time.Second * utils.RetryInterval)
inc++
}
return false
}
func getBlockPodDefinition(podName, blockName string, readOnly bool) string {
return `apiVersion: v1
kind: Pod
metadata:
name: ` + podName + `
spec:
containers:
- image: busybox
name: block-test1
command:
- sleep
- "3600"
imagePullPolicy: IfNotPresent
volumeMounts:
- name: block-persistent-storage
mountPath: ` + utils.TestMountPath + `
volumes:
- name: block-persistent-storage
persistentVolumeClaim:
claimName: ` + blockName + `
readOnly: ` + strconv.FormatBool(readOnly) + `
restartPolicy: Never`
}
func getBlockStatefulSetAndServiceDefinition(namespace, statefulsetName, podName, StorageClassName string) (*v1.Service, *appsv1.StatefulSet) {
service := &v1.Service{
TypeMeta: metav1.TypeMeta{
APIVersion: "v1",
Kind: "Service",
},
ObjectMeta: metav1.ObjectMeta{
Name: statefulsetName,
Namespace: namespace,
Labels: map[string]string{
"app": statefulsetName,
},
},
Spec: v1.ServiceSpec{
Ports: []v1.ServicePort{
{
Name: statefulsetName,
Port: 80,
},
},
ClusterIP: "None",
Selector: map[string]string{
"app": statefulsetName,
},
},
}
var replica int32 = 1
labels := map[string]string{
"app": statefulsetName,
}
statefulSet := &appsv1.StatefulSet{
TypeMeta: metav1.TypeMeta{
APIVersion: "apps/v1",
Kind: "StatefulSet",
},
ObjectMeta: metav1.ObjectMeta{
Name: podName,
Namespace: namespace,
},
Spec: appsv1.StatefulSetSpec{
ServiceName: statefulsetName,
Selector: &metav1.LabelSelector{
MatchLabels: labels,
},
Replicas: &replica,
Template: v1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: labels,
},
Spec: v1.PodSpec{
Containers: []v1.Container{
{
Name: statefulsetName,
Image: "busybox",
Command: []string{"sleep", "3600"},
Ports: []v1.ContainerPort{
{
ContainerPort: 80,
Name: podName,
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "rookpvc",
MountPath: "/tmp/rook",
},
},
},
},
},
},
VolumeClaimTemplates: []v1.PersistentVolumeClaim{
{
ObjectMeta: metav1.ObjectMeta{
Name: "rookpvc",
Annotations: map[string]string{
"volume.beta.kubernetes.io/storage-class": StorageClassName,
},
},
Spec: v1.PersistentVolumeClaimSpec{
AccessModes: []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce},
Resources: v1.ResourceRequirements{
Requests: v1.ResourceList{
v1.ResourceStorage: *resource.NewQuantity(1.0, resource.BinarySI),
},
},
},
},
},
},
}
return service, statefulSet
}