Files
my-rook-config/pkg/operator/ceph/cluster/mgr/dashboard_test.go
T
Travis Nielsen 4ad432ffcf ceph: only restart ceph dashboard module if settings changed
If ssl was not enabled, the dashboard was being restarted with every
reconcile. Instead, the dashboard should only be restarted when
the settings have changed in order to reduce the frequency that
the dashboard is restarted.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
2021-01-12 16:00:13 -07:00

157 lines
5.0 KiB
Go

/*
Copyright 2018 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package mgr
import (
"context"
"testing"
"time"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/daemon/ceph/client"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
cephver "github.com/rook/rook/pkg/operator/ceph/version"
"github.com/rook/rook/pkg/operator/test"
exectest "github.com/rook/rook/pkg/util/exec/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
func TestGeneratePassword(t *testing.T) {
password, err := GeneratePassword(0)
require.Nil(t, err)
assert.Equal(t, "", password)
password, err = GeneratePassword(1)
require.Nil(t, err)
assert.Equal(t, 1, len(password))
logger.Infof("password: %s", password)
password, err = GeneratePassword(10)
require.Nil(t, err)
assert.Equal(t, 10, len(password))
logger.Infof("password: %s", password)
}
func TestGetOrGeneratePassword(t *testing.T) {
ctx := context.TODO()
clientset := test.New(t, 3)
clusterInfo := &client.ClusterInfo{Namespace: "myns"}
c := &Cluster{context: &clusterd.Context{Clientset: clientset}, clusterInfo: clusterInfo}
_, err := c.context.Clientset.CoreV1().Secrets(clusterInfo.Namespace).Get(ctx, dashboardPasswordName, metav1.GetOptions{})
assert.True(t, kerrors.IsNotFound(err))
// Generate a password
password, err := c.getOrGenerateDashboardPassword()
require.Nil(t, err)
assert.Equal(t, passwordLength, len(password))
secret, err := c.context.Clientset.CoreV1().Secrets(clusterInfo.Namespace).Get(ctx, dashboardPasswordName, metav1.GetOptions{})
assert.Nil(t, err)
assert.Equal(t, 1, len(secret.Data))
passwordFromSecret, err := decodeSecret(secret)
assert.NoError(t, err)
assert.Equal(t, password, passwordFromSecret)
// We should retrieve the same password on the second call
retrievedPassword, err := c.getOrGenerateDashboardPassword()
assert.Nil(t, err)
assert.Equal(t, password, retrievedPassword)
}
func TestStartSecureDashboard(t *testing.T) {
ctx := context.TODO()
enables := 0
disables := 0
moduleRetries := 0
exitCodeResponse := 0
clientset := test.New(t, 3)
executor := &exectest.MockExecutor{
MockExecuteCommandWithOutputFile: func(command string, outFileArg string, args ...string) (string, error) {
logger.Infof("command: %s %v", command, args)
exitCodeResponse = 0
if args[1] == "module" {
if args[2] == "enable" {
enables++
} else if args[2] == "disable" {
disables++
}
}
if args[0] == "dashboard" && args[1] == "create-self-signed-cert" {
if moduleRetries < 2 {
logger.Infof("simulating retry...")
exitCodeResponse = invalidArgErrorCode
moduleRetries++
return "", errors.New("test failure")
}
}
return "", nil
},
}
executor.MockExecuteCommandWithOutputFileTimeout = func(timeout time.Duration, command, outfileArg string, arg ...string) (string, error) {
return executor.MockExecuteCommandWithOutputFile(command, outfileArg, arg...)
}
clusterInfo := &cephclient.ClusterInfo{
Namespace: "myns",
CephVersion: cephver.Nautilus,
}
c := &Cluster{clusterInfo: clusterInfo, context: &clusterd.Context{Clientset: clientset, Executor: executor},
spec: cephv1.ClusterSpec{
Dashboard: cephv1.DashboardSpec{Port: dashboardPortHTTP, Enabled: true, SSL: true},
CephVersion: cephv1.CephVersionSpec{Image: "ceph/ceph:v15"},
},
}
c.exitCode = func(err error) (int, bool) {
if exitCodeResponse != 0 {
return exitCodeResponse, true
}
return exitCodeResponse, false
}
dashboardInitWaitTime = 0
err := c.configureDashboardService()
assert.NoError(t, err)
err = c.configureDashboardModules()
assert.NoError(t, err)
// the dashboard is enabled once with the new dashboard and modules
assert.Equal(t, 1, enables)
assert.Equal(t, 0, disables)
assert.Equal(t, 2, moduleRetries)
svc, err := c.context.Clientset.CoreV1().Services(clusterInfo.Namespace).Get(ctx, "rook-ceph-mgr-dashboard", metav1.GetOptions{})
assert.Nil(t, err)
assert.NotNil(t, svc)
// disable the dashboard
c.spec.Dashboard.Enabled = false
err = c.configureDashboardService()
assert.Nil(t, err)
err = c.configureDashboardModules()
assert.NoError(t, err)
assert.Equal(t, 1, enables)
assert.Equal(t, 1, disables)
svc, err = c.context.Clientset.CoreV1().Services(clusterInfo.Namespace).Get(ctx, "rook-ceph-mgr-dashboard", metav1.GetOptions{})
assert.NotNil(t, err)
assert.True(t, kerrors.IsNotFound(err))
assert.Nil(t, svc)
}