Files
my-rook-config/pkg/operator/ceph/controller/mirror_peer.go
T
Blaine Gardner 2fd9c9a88c core: finalize CephCluster CephX status handling
Cleanup up overall usage of CephX statuses in CephCluster.

Convert all CephX statuses to non-pointer types. There is no specific
need for pointer types, and keeping these as non-pointers means there is
not a risk of nil pointer exceptions in all the various Rook controllers
for upgraded clusters.

Move initialization of CephCluster CephX status items to
`preMonStartupActions()`. This helps resolve 2 issues:

1. 'Uninitialized' state was being set for external CephClusters where
   CephX statuses are not relevant.
2. 'Uninitialized' state was being set for upgraded clusters whose key
   status cannot be determined.

Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
2025-08-18 14:53:08 -06:00

281 lines
11 KiB
Go

/*
Copyright 2021 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package controller provides Kubernetes controller/pod/container spec items used for many Ceph daemons
package controller
import (
"encoding/base64"
"encoding/json"
"fmt"
"github.com/pkg/errors"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
cephclient "github.com/rook/rook/pkg/daemon/ceph/client"
"github.com/rook/rook/pkg/operator/ceph/config/keyring"
"github.com/rook/rook/pkg/operator/ceph/reporting"
"github.com/rook/rook/pkg/operator/k8sutil"
v1 "k8s.io/api/core/v1"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/util/retry"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)
const (
//nolint:gosec // since this is not leaking any hardcoded credentials, it's just the prefix of the secret name
poolMirrorBootstrapPeerSecretName = "pool-peer-token"
//nolint:gosec // since this is not leaking any hardcoded credentials, it's just the prefix of the secret name
fsMirrorBootstrapPeerSecretName = "fs-peer-token"
//nolint:gosec // // since this is not leaking any hardcoded credentials, it's just the prefix of the secret name
clusterMirrorBootstrapPeerSecretName = "cluster-peer-token"
//nolint:gosec // since this is not leaking any hardcoded credentials, it's just the prefix of the secret name
RBDMirrorBootstrapPeerSecretName = "rbdMirrorBootstrapPeerSecretName"
//nolint:gosec // since this is not leaking any hardcoded credentials, it's just the prefix of the secret name
FSMirrorBootstrapPeerSecretName = "fsMirrorBootstrapPeerSecretName"
)
func CreateBootstrapPeerSecret(ctx *clusterd.Context, clusterInfo *cephclient.ClusterInfo, object client.Object, ownerInfo *k8sutil.OwnerInfo) (reconcile.Result, error) {
var err error
var ns, name, daemonType string
var bootstrapToken []byte
switch objectType := object.(type) {
case *cephv1.CephBlockPool:
ns = objectType.Namespace
name = objectType.Name
daemonType = "rbd"
// Create rbd mirror bootstrap peer token
bootstrapToken, err = cephclient.CreateRBDMirrorBootstrapPeer(ctx, clusterInfo, name)
if err != nil {
return ImmediateRetryResult, errors.Wrapf(err, "failed to create %s-mirror bootstrap peer", daemonType)
}
// Add additional information to the peer token
bootstrapToken, err = expandBootstrapPeerToken(ctx, clusterInfo, bootstrapToken)
if err != nil {
return ImmediateRetryResult, errors.Wrap(err, "failed to add extra information to rbd-mirror bootstrap peer")
}
case *cephv1.CephCluster:
ns = objectType.Namespace
daemonType = "cluster-rbd"
// check if rbd-mirror-peer user needs to be rotated
shouldRotateKeys, err := shouldRotateMirrorPeerKeys(ctx, clusterInfo)
if err != nil {
return ImmediateRetryResult, errors.Wrap(err, "failed to check if rbd-mirror-peer keys should be rotated or not")
}
// Create rbd mirror bootstrap peer token
bootstrapToken, err = cephclient.CreateRBDMirrorBootstrapPeerWithoutPool(ctx, clusterInfo, shouldRotateKeys)
if err != nil {
return ImmediateRetryResult, errors.Wrapf(err, "failed to create %s-mirror bootstrap peer", daemonType)
}
// update rbd mirror peer cephx status in cephCluster resource
err = updateCephClusterCephxRbdMirrorStatus(ctx, clusterInfo, shouldRotateKeys)
if err != nil {
return ImmediateRetryResult, errors.Wrapf(err, "failed to update rbd-mirror-peer cephx status in the ceph cluster")
}
// Add additional information to the peer token
bootstrapToken, err = expandBootstrapPeerToken(ctx, clusterInfo, bootstrapToken)
if err != nil {
return ImmediateRetryResult, errors.Wrap(err, "failed to add extra information to rbd-mirror bootstrap peer")
}
case *cephv1.CephFilesystem:
ns = objectType.Namespace
name = objectType.Name
daemonType = "cephfs"
bootstrapToken, err = cephclient.CreateFSMirrorBootstrapPeer(ctx, clusterInfo, name)
if err != nil {
return ImmediateRetryResult, errors.Wrapf(err, "failed to create %s-mirror bootstrap peer", daemonType)
}
default:
return ImmediateRetryResult, errors.Wrap(err, "failed to create bootstrap peer unknown daemon type")
}
// Generate and create a Kubernetes Secret with this token
s := GenerateBootstrapPeerSecret(object, bootstrapToken)
// set ownerref to the Secret
err = ownerInfo.SetControllerReference(s)
if err != nil {
return ImmediateRetryResult, errors.Wrapf(err, "failed to set owner reference for %s-mirror bootstrap peer secret %q", daemonType, s.Name)
}
// Create Secret
logger.Debugf("store %s-mirror bootstrap token in a Kubernetes Secret %q in namespace %q", daemonType, s.Name, ns)
_, err = k8sutil.CreateOrUpdateSecret(clusterInfo.Context, ctx.Clientset, s)
if err != nil && !kerrors.IsAlreadyExists(err) {
return ImmediateRetryResult, errors.Wrapf(err, "failed to create %s-mirror bootstrap peer %q secret", daemonType, s.Name)
}
return reconcile.Result{}, nil
}
// GenerateBootstrapPeerSecret generates a Kubernetes Secret for the mirror bootstrap peer token
func GenerateBootstrapPeerSecret(object client.Object, token []byte) *v1.Secret {
var entityType, entityName, entityNamespace string
switch objectType := object.(type) {
case *cephv1.CephFilesystem:
entityType = "fs"
entityName = objectType.Name
entityNamespace = objectType.Namespace
case *cephv1.CephBlockPool:
entityType = "pool"
entityName = objectType.Name
entityNamespace = objectType.Namespace
case *cephv1.CephCluster:
entityType = "cluster"
entityName = objectType.Name
entityNamespace = objectType.Namespace
}
s := &v1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: buildBootstrapPeerSecretName(object),
Namespace: entityNamespace,
},
Data: map[string][]byte{
"token": token,
entityType: []byte(entityName),
},
Type: k8sutil.RookType,
}
return s
}
func buildBootstrapPeerSecretName(object client.Object) string {
switch objectType := object.(type) {
case *cephv1.CephFilesystem:
return fmt.Sprintf("%s-%s", fsMirrorBootstrapPeerSecretName, objectType.Name)
case *cephv1.CephBlockPool:
return fmt.Sprintf("%s-%s", poolMirrorBootstrapPeerSecretName, objectType.Name)
case *cephv1.CephCluster:
return fmt.Sprintf("%s-%s", clusterMirrorBootstrapPeerSecretName, objectType.Name)
}
return ""
}
func GenerateStatusInfo(object client.Object) map[string]string {
m := make(map[string]string)
switch object.(type) {
case *cephv1.CephFilesystem:
m[FSMirrorBootstrapPeerSecretName] = buildBootstrapPeerSecretName(object)
case *cephv1.CephBlockPool:
m[RBDMirrorBootstrapPeerSecretName] = buildBootstrapPeerSecretName(object)
}
return m
}
func ValidatePeerToken(object client.Object, data map[string][]byte) error {
if len(data) == 0 {
return errors.Errorf("failed to lookup 'data' secret field (empty)")
}
// Lookup Secret keys and content
keysToTest := []string{"token"}
switch object.(type) {
case *cephv1.CephRBDMirror:
keysToTest = append(keysToTest, "pool")
}
for _, key := range keysToTest {
k, ok := data[key]
if !ok || len(k) == 0 {
return errors.Errorf("failed to lookup %q key in secret bootstrap peer (missing or empty)", key)
}
}
return nil
}
func expandBootstrapPeerToken(ctx *clusterd.Context, clusterInfo *cephclient.ClusterInfo, token []byte) ([]byte, error) {
// First decode the token, it's base64 encoded
decodedToken, err := base64.StdEncoding.DecodeString(string(token))
if err != nil {
return nil, errors.Wrap(err, "failed to decode bootstrap peer token")
}
// Unmarshal the decoded value to a Go type
var decodedTokenToGo cephclient.PeerToken
err = json.Unmarshal(decodedToken, &decodedTokenToGo)
if err != nil {
return nil, errors.Wrap(err, "failed to unmarshal decoded token")
}
decodedTokenToGo.Namespace = clusterInfo.Namespace
// Marshal the Go type back to JSON
decodedTokenBackToJSON, err := json.Marshal(decodedTokenToGo)
if err != nil {
return nil, errors.Wrap(err, "failed to encode go type back to json")
}
// Return the base64 encoded token
return []byte(base64.StdEncoding.EncodeToString(decodedTokenBackToJSON)), nil
}
func shouldRotateMirrorPeerKeys(c *clusterd.Context, clusterInfo *cephclient.ClusterInfo) (bool, error) {
cephObj := &cephv1.CephCluster{}
if err := c.Client.Get(clusterInfo.Context, clusterInfo.NamespacedName(), cephObj); err != nil {
return false, errors.Wrapf(err, "failed to get cluster %v to get the cephx keys to rotate.", clusterInfo.NamespacedName())
}
// TODO: for rotation WithCephVersionUpdate fix this to have the right runningCephVersion and desiredCephVersion
desiredCephVersion := clusterInfo.CephVersion
runningCephVersion := clusterInfo.CephVersion
shouldRotateKeys, err := keyring.ShouldRotateCephxKeys(cephObj.Spec.Security.CephX.RBDMirrorPeer, runningCephVersion, desiredCephVersion, cephObj.Status.Cephx.RBDMirrorPeer)
if err != nil {
return false, errors.Wrap(err, "failed to check if mirror peer keys should be rotated or not")
}
return shouldRotateKeys, nil
}
// updateCephClusterCephxRbdMirrorStatus fetches the latest cephCluster instance and updates mirror peer cephx status
func updateCephClusterCephxRbdMirrorStatus(c *clusterd.Context, clusterInfo *cephclient.ClusterInfo, didRotate bool) error {
err := retry.RetryOnConflict(retry.DefaultRetry, func() error {
cluster := &cephv1.CephCluster{}
if err := c.Client.Get(clusterInfo.Context, clusterInfo.NamespacedName(), cluster); err != nil {
return errors.Wrapf(err, "failed to get cluster %v to update the conditions.", clusterInfo.NamespacedName())
}
updatedStatus := keyring.UpdatedCephxStatus(didRotate, cluster.Spec.Security.CephX.RBDMirrorPeer, clusterInfo.CephVersion, cluster.Status.Cephx.RBDMirrorPeer)
cluster.Status.Cephx.RBDMirrorPeer = updatedStatus
logger.Debugf("updating rbd-mirror cephx status to %+v", cluster.Status.Cephx.RBDMirrorPeer)
if err := reporting.UpdateStatus(c.Client, cluster); err != nil {
return errors.Wrap(err, "failed to update cluster cephx status for rbd-mirror")
}
return nil
})
if err != nil {
return err
}
logger.Debugf("successfully updated rbd-mirror cephx status on the cluster %q", clusterInfo.NamespacedName())
return nil
}