forked from rook/rook
Sébastien Han
7c994441c3
Currently, we need to configure the Ceph external Admin keyi in the Rook deployment to be able to connect to an external Ceph cluster. If we wanted to run in a multi-tenant fashion were several K8s/Rook clusters wanted to connect to the same external ceph cluster, each K8s deployment would have the access to the External Ceph Admin key and could potentially access or delete the Data from pools that belong to other k8s/Rook Clusters. Now the admin key is optional but the helper script create-external-cluster-resources.sh will help create the necessary keys/users to connect to that cluster. Closes: https://github.com/rook/rook/issues/4917 and https://github.com/rook/rook/pull/5227 Signed-off-by: Sébastien Han <seb@redhat.com>
113 lines
3.0 KiB
Go
113 lines
3.0 KiB
Go
/*
|
|
Copyright 2019 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package client
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestFinalizeCephCommandArgs(t *testing.T) {
|
|
RunAllCephCommandsInToolbox = false
|
|
clusterName := "rook"
|
|
configDir := "/var/lib/rook/rook-ceph"
|
|
expectedCommand := "ceph"
|
|
args := []string{"quorum_status"}
|
|
expectedArgs := []string{
|
|
"quorum_status",
|
|
"--connect-timeout=15",
|
|
"--cluster=rook",
|
|
"--conf=/var/lib/rook/rook-ceph/rook/rook.config",
|
|
"--name=client.admin",
|
|
"--keyring=/var/lib/rook/rook-ceph/rook/client.admin.keyring",
|
|
}
|
|
|
|
cmd, args := FinalizeCephCommandArgs(expectedCommand, args, configDir, clusterName, "client.admin")
|
|
assert.Exactly(t, expectedCommand, cmd)
|
|
assert.Exactly(t, expectedArgs, args)
|
|
}
|
|
|
|
func TestFinalizeRadosGWAdminCommandArgs(t *testing.T) {
|
|
RunAllCephCommandsInToolbox = false
|
|
clusterName := "rook"
|
|
configDir := "/var/lib/rook/rook-ceph"
|
|
expectedCommand := "radosgw-admin"
|
|
args := []string{
|
|
"realm",
|
|
"create",
|
|
"--default",
|
|
"--rgw-realm=default-rook",
|
|
"--rgw-zonegroup=default-rook",
|
|
}
|
|
|
|
expectedArgs := []string{
|
|
"realm",
|
|
"create",
|
|
"--default",
|
|
"--rgw-realm=default-rook",
|
|
"--rgw-zonegroup=default-rook",
|
|
"--cluster=rook",
|
|
"--conf=/var/lib/rook/rook-ceph/rook/rook.config",
|
|
"--name=client.admin",
|
|
"--keyring=/var/lib/rook/rook-ceph/rook/client.admin.keyring",
|
|
}
|
|
|
|
cmd, args := FinalizeCephCommandArgs(expectedCommand, args, configDir, clusterName, "client.admin")
|
|
assert.Exactly(t, expectedCommand, cmd)
|
|
assert.Exactly(t, expectedArgs, args)
|
|
}
|
|
|
|
func TestFinalizeCephCommandArgsToolBox(t *testing.T) {
|
|
RunAllCephCommandsInToolbox = true
|
|
clusterName := "rook"
|
|
configDir := "/var/lib/rook/rook-ceph"
|
|
expectedCommand := "ceph"
|
|
args := []string{"health"}
|
|
expectedArgs := []string{
|
|
"-it",
|
|
"exec",
|
|
"rook-ceph-tools",
|
|
"-n",
|
|
"rook",
|
|
"--",
|
|
"ceph",
|
|
"health",
|
|
"--connect-timeout=15",
|
|
}
|
|
|
|
cmd, args := FinalizeCephCommandArgs(expectedCommand, args, configDir, clusterName, "client.admin")
|
|
assert.Exactly(t, "kubectl", cmd)
|
|
assert.Exactly(t, expectedArgs, args)
|
|
}
|
|
|
|
func TestFinalizeCephCommandArgsClusterDefaultName(t *testing.T) {
|
|
RunAllCephCommandsInToolbox = false
|
|
clusterName := "ceph"
|
|
configDir := "/etc"
|
|
expectedCommand := "ceph"
|
|
args := []string{"quorum_status"}
|
|
expectedArgs := []string{
|
|
"quorum_status",
|
|
"--connect-timeout=15",
|
|
}
|
|
|
|
cmd, args := FinalizeCephCommandArgs(expectedCommand, args, configDir, clusterName, "client.admin")
|
|
assert.Exactly(t, expectedCommand, cmd)
|
|
assert.Exactly(t, expectedArgs, args)
|
|
}
|