forked from rook/rook
Satoru Takeuchi
30e4fbb01f
Sometimes the default 15s is not enough for timeout of ceph commands. For examples, I encountered that `radosgw-admin` command took dozens of seconds under heavy load. Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
107 lines
3.2 KiB
Go
107 lines
3.2 KiB
Go
/*
|
|
Copyright 2020 The Rook Authors. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
|
|
"github.com/rook/rook/pkg/clusterd"
|
|
"github.com/rook/rook/pkg/util/exec"
|
|
"github.com/stretchr/testify/assert"
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/kubernetes/fake"
|
|
)
|
|
|
|
func CreateTestClusterFromStatusDetails(details map[string]cephv1.CephHealthMessage) cephv1.CephCluster {
|
|
return cephv1.CephCluster{
|
|
Status: cephv1.ClusterStatus{
|
|
CephStatus: &cephv1.CephStatus{
|
|
Details: details,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestCanIgnoreHealthErrStatusInReconcile(t *testing.T) {
|
|
var cluster = CreateTestClusterFromStatusDetails(map[string]cephv1.CephHealthMessage{
|
|
"MDS_ALL_DOWN": {
|
|
Severity: "HEALTH_ERR",
|
|
Message: "MDS_ALL_DOWN",
|
|
},
|
|
"TEST_OTHER": {
|
|
Severity: "HEALTH_WARN",
|
|
Message: "TEST_OTHER",
|
|
},
|
|
"TEST_ANOTHER": {
|
|
Severity: "HEALTH_OK",
|
|
Message: "TEST_ANOTHER",
|
|
},
|
|
})
|
|
assert.True(t, canIgnoreHealthErrStatusInReconcile(cluster, "controller"))
|
|
|
|
cluster = CreateTestClusterFromStatusDetails(map[string]cephv1.CephHealthMessage{
|
|
"MDS_ALL_DOWN": {
|
|
Severity: "HEALTH_ERR",
|
|
Message: "MDS_ALL_DOWN",
|
|
},
|
|
"TEST_UNIGNORABLE": {
|
|
Severity: "HEALTH_ERR",
|
|
Message: "TEST_UNIGNORABLE",
|
|
},
|
|
})
|
|
assert.False(t, canIgnoreHealthErrStatusInReconcile(cluster, "controller"))
|
|
|
|
cluster = CreateTestClusterFromStatusDetails(map[string]cephv1.CephHealthMessage{
|
|
"TEST_UNIGNORABLE": {
|
|
Severity: "HEALTH_ERR",
|
|
Message: "TEST_UNIGNORABLE",
|
|
},
|
|
})
|
|
assert.False(t, canIgnoreHealthErrStatusInReconcile(cluster, "controller"))
|
|
}
|
|
|
|
func TestSetCephCommandsTimeout(t *testing.T) {
|
|
clientset := fake.NewSimpleClientset()
|
|
ctx := context.TODO()
|
|
cm := &v1.ConfigMap{}
|
|
cm.Name = "rook-ceph-operator-config"
|
|
_, err := clientset.CoreV1().ConfigMaps("").Create(ctx, cm, metav1.CreateOptions{})
|
|
assert.NoError(t, err)
|
|
context := &clusterd.Context{Clientset: clientset}
|
|
|
|
SetCephCommandsTimeout(context)
|
|
assert.Equal(t, 15*time.Second, exec.CephCommandsTimeout)
|
|
|
|
exec.CephCommandsTimeout = 0
|
|
cm.Data = map[string]string{"ROOK_CEPH_COMMANDS_TIMEOUT_SECONDS": "0"}
|
|
_, err = clientset.CoreV1().ConfigMaps("").Update(ctx, cm, metav1.UpdateOptions{})
|
|
assert.NoError(t, err)
|
|
SetCephCommandsTimeout(context)
|
|
assert.Equal(t, 15*time.Second, exec.CephCommandsTimeout)
|
|
|
|
exec.CephCommandsTimeout = 0
|
|
cm.Data = map[string]string{"ROOK_CEPH_COMMANDS_TIMEOUT_SECONDS": "1"}
|
|
_, err = clientset.CoreV1().ConfigMaps("").Update(ctx, cm, metav1.UpdateOptions{})
|
|
assert.NoError(t, err)
|
|
SetCephCommandsTimeout(context)
|
|
assert.Equal(t, 1*time.Second, exec.CephCommandsTimeout)
|
|
}
|