Files
my-rook-config/pkg/operator/ceph/object/rgw.go
T
Sébastien Han 93b2448619 ceph: refactor rgw bootstrap
This commit does multiple things:

* remove support for AllNodes where we would deploy one rgw per node on
all the nodes.
* a transition path is implemented in the code so that if someone has an
existing deployment, daemonsets will be removed and replaced by an
deployments.
* when using "instances", each rgw deployed has its own key which makes
Ceph reporting the exact number of rgw running, see:

```
[root@rook-ceph-operator-775cf575c5-bh4sr /]# ceph -s
  cluster:
    id:     611fcf39-0669-4864-9a12-debb35c0397a
    health: HEALTH_OK

  services:
    mon: 3 daemons, quorum a,b,c (age 12h)
    mgr: a(active, since 12h)
    osd: 3 osds: 3 up (since 12h), 3 in (since 12h)
    rgw: 3 daemons active (my.store.a, my.store.b, my.store.c)

  data:
    pools:   6 pools, 600 pgs
    objects: 235 objects, 3.8 KiB
    usage:   3.0 GiB used, 84 GiB / 87 GiB avail
    pgs:     600 active+clean
```

Closes: https://github.com/rook/rook/issues/2474, https://github.com/rook/rook/issues/2957 and https://github.com/rook/rook/issues/3245
Signed-off-by: Sébastien Han <seb@redhat.com>
2019-06-14 17:55:15 +02:00

353 lines
12 KiB
Go

/*
Copyright 2016 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package object for the Ceph object store.
package object
import (
"fmt"
"strings"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/daemon/ceph/client"
cephconfig "github.com/rook/rook/pkg/daemon/ceph/config"
"github.com/rook/rook/pkg/operator/ceph/config"
"github.com/rook/rook/pkg/operator/ceph/pool"
"github.com/rook/rook/pkg/operator/k8sutil"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
type clusterConfig struct {
clusterInfo *cephconfig.ClusterInfo
context *clusterd.Context
store cephv1.CephObjectStore
rookVersion string
cephVersion cephv1.CephVersionSpec
hostNetwork bool
ownerRefs []metav1.OwnerReference
DataPathMap *config.DataPathMap
}
type rgwConfig struct {
ResourceName string
DaemonID string
}
const (
oldRgwKeyName = "client.radosgw.gateway"
)
// Start the rgw manager
func (c *clusterConfig) createStore() error {
return c.createOrUpdate(false)
}
func (c *clusterConfig) updateStore() error {
return c.createOrUpdate(true)
}
func (c *clusterConfig) createOrUpdate(update bool) error {
// validate the object store settings
if err := validateStore(c.context, c.store); err != nil {
return fmt.Errorf("invalid object store %s arguments. %+v", c.store.Name, err)
}
// check if the object store already exists
exists, err := c.storeExists()
if err == nil && exists {
if !update {
logger.Infof("object store %s exists in namespace %s", c.store.Name, c.store.Namespace)
return c.startRGWPods(update)
}
logger.Infof("object store %s exists in namespace %s. checking for updates", c.store.Name, c.store.Namespace)
}
logger.Infof("creating object store %s in namespace %s", c.store.Name, c.store.Namespace)
// start the service
serviceIP, err := c.startService()
if err != nil {
return fmt.Errorf("failed to start rgw service. %+v", err)
}
// create the ceph artifacts for the object store
objContext := NewContext(c.context, c.store.Name, c.store.Namespace)
err = createObjectStore(objContext, *c.store.Spec.MetadataPool.ToModel(""), *c.store.Spec.DataPool.ToModel(""), serviceIP, c.store.Spec.Gateway.Port)
if err != nil {
return fmt.Errorf("failed to create pools. %+v", err)
}
if err := c.startRGWPods(update); err != nil {
return fmt.Errorf("failed to start pods. %+v", err)
}
logger.Infof("created object store %s", c.store.Name)
return nil
}
func (c *clusterConfig) startRGWPods(update bool) error {
// backward compatibility, triggered during updates
if c.store.Spec.Gateway.AllNodes {
// log we don't support that anymore
logger.Warningf(
"setting 'AllNodes' to %t is not supported anymore, please use 'instances' instead, removing old DaemonSets if any and replace them with Deployments in object store %s",
c.store.Spec.Gateway.AllNodes, c.store.Name)
}
if c.store.Spec.Gateway.Instances < 1 {
// Set the minimum of at least one instance
logger.Warningf("spec.gateway.instances must be set to at least 1")
c.store.Spec.Gateway.Instances = 1
}
// start a new deployment and scale up
desiredRgwInstances := int(c.store.Spec.Gateway.Instances)
for i := 0; i < desiredRgwInstances; i++ {
daemonLetterID := k8sutil.IndexToName(i)
// Each rgw is id'ed by <store_name>-<letterID>
daemonName := fmt.Sprintf("%s-%s", c.store.Name, daemonLetterID)
// resource name is rook-ceph-rgw-<store_name>-<daemon_name>
resourceName := fmt.Sprintf("%s-%s-%s", AppName, c.store.Name, daemonLetterID)
rgwConfig := &rgwConfig{
ResourceName: resourceName,
DaemonID: daemonName,
}
deployment, err := c.startDeployment(rgwConfig)
if err != nil {
return err
}
resourceControllerOwnerRef := &metav1.OwnerReference{
UID: deployment.UID,
APIVersion: "v1",
Kind: "deployment",
Name: rgwConfig.ResourceName,
}
// Generate the keyring after starting the replication controller so that the keyring may use
// the controller as its owner reference; the keyring is deleted with the controller
err = c.generateKeyring(resourceControllerOwnerRef)
if err != nil {
return fmt.Errorf("failed to create rgw keyring. %+v", err)
}
// Generate the mime.types file after the rep. controller as well for the same reason as keyring
if err := c.generateMimeTypes(resourceControllerOwnerRef); err != nil {
return fmt.Errorf("failed to generate the rgw mime.types config. %+v", err)
}
}
// scale down scenario
deps, err := k8sutil.GetDeployments(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
if err != nil {
logger.Warning("could not get deployments for object store %s (matching label selector '%s'): %+v", c.store.Name, c.storeLabelSelector(), err)
}
currentRgwInstances := int(len(deps.Items))
if currentRgwInstances > desiredRgwInstances {
logger.Infof("found more rgw deployments %d than desired %d in object store %s, scaling down", currentRgwInstances, c.store.Spec.Gateway.Instances, c.store.Name)
diffCount := currentRgwInstances - desiredRgwInstances
for i := 0; i < diffCount; {
depIDToRemove := currentRgwInstances - 1
depNameToRemove := fmt.Sprintf("%s-%s-%s", AppName, c.store.Name, k8sutil.IndexToName(depIDToRemove))
if err := k8sutil.DeleteDeployment(c.context.Clientset, c.store.Namespace, depNameToRemove); err != nil {
logger.Warning("error during deletion of deployment %s resource: %+v", depNameToRemove, err)
}
currentRgwInstances = currentRgwInstances - 1
i++
// Delete the auth key
err = client.AuthDelete(c.context, c.store.Namespace, generateCephXUser(depNameToRemove))
if err != nil {
logger.Infof("failed to delete rgw key %s. %+v", depNameToRemove, err)
}
}
// verify scale down was successful
deps, err = k8sutil.GetDeployments(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
if err != nil {
logger.Warning("could not get deployments for object store %s (matching label selector '%s'): %+v", c.store.Name, c.storeLabelSelector(), err)
}
currentRgwInstances = len(deps.Items)
if currentRgwInstances == desiredRgwInstances {
logger.Infof("successfully scaled down rgw deployments to %d in object store %s", desiredRgwInstances, c.store.Name)
}
}
c.deleteLegacyDaemons()
return nil
}
// deleteLegacyDaemons removes legacy rgw components that might have existed in Rook v1.0
func (c *clusterConfig) deleteLegacyDaemons() {
// Make a best effort to delete the rgw pods daemonsets
daemons, err := k8sutil.GetDaemonsets(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
if err != nil {
logger.Warningf("could not get deployments for object store %s (matching label selector '%s'): %+v", c.store.Name, c.storeLabelSelector(), err)
}
daemonsetNum := len(daemons.Items)
if daemonsetNum > 0 {
for _, d := range daemons.Items {
// Delete any existing daemonset
if err := k8sutil.DeleteDaemonset(c.context.Clientset, c.store.Namespace, d.Name); err != nil {
logger.Errorf("error during deletion of daemonset %s resource: %+v", d.Name, err)
}
}
// Delete legacy rgw key
err = client.AuthDelete(c.context, c.store.Namespace, oldRgwKeyName)
if err != nil {
logger.Infof("failed to delete legacy rgw key %s. %+v", oldRgwKeyName, err)
}
}
// legacy deployment detection
logger.Debugf("looking for legacy deployment in object store %s", c.store.Name)
deps, err := k8sutil.GetDeployments(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
if err != nil {
logger.Warning("could not get deployments for object store %s (matching label selector '%s'): %+v", c.store.Name, c.storeLabelSelector(), err)
}
for _, d := range deps.Items {
if d.Name == c.instanceName() {
logger.Infof("legacy deployment in object store %s found %s", c.store.Name, d.Name)
if err := k8sutil.DeleteDeployment(c.context.Clientset, c.store.Namespace, d.Name); err != nil {
logger.Warning("error during deletion of deployment %s resource: %+v", d.Name, err)
}
// Delete legacy rgw key
err = client.AuthDelete(c.context, c.store.Namespace, oldRgwKeyName)
if err != nil {
logger.Infof("failed to delete legacy rgw key %s. %+v", oldRgwKeyName, err)
}
}
}
}
// Delete the object store.
// WARNING: This is a very destructive action that deletes all metadata and data pools.
func (c *clusterConfig) deleteStore() error {
// check if the object store exists
exists, err := c.storeExists()
if err != nil {
return fmt.Errorf("failed to detect if there is an object store to delete. %+v", err)
}
if !exists {
logger.Infof("Object store %s does not exist in namespace %s", c.store.Name, c.store.Namespace)
return nil
}
logger.Infof("Deleting object store %s from namespace %s", c.store.Name, c.store.Namespace)
var gracePeriod int64
propagation := metav1.DeletePropagationForeground
options := &metav1.DeleteOptions{GracePeriodSeconds: &gracePeriod, PropagationPolicy: &propagation}
// Delete the rgw service
err = c.context.Clientset.CoreV1().Services(c.store.Namespace).Delete(c.instanceName(), options)
if err != nil && !errors.IsNotFound(err) {
logger.Warningf("failed to delete rgw service. %+v", err)
}
// Make a best effort to delete the rgw pods deployments
deps, err := k8sutil.GetDeployments(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
if err != nil {
logger.Warning("could not get deployments for object store %s (matching label selector '%s'): %+v", c.store.Namespace, c.storeLabelSelector(), err)
}
for _, d := range deps.Items {
if err := k8sutil.DeleteDeployment(c.context.Clientset, c.store.Namespace, d.Name); err != nil {
logger.Warning("error during deletion of deployment %s resource: %+v", d.Name, err)
}
}
// Delete the rgw config map keyrings
err = c.context.Clientset.CoreV1().Secrets(c.store.Namespace).Delete(c.instanceName(), options)
if err != nil && !errors.IsNotFound(err) {
logger.Warningf("failed to delete rgw secret. %+v", err)
}
// Delete rgw CephX keys
for i := 0; i < int(c.store.Spec.Gateway.Instances); i++ {
daemonLetterID := k8sutil.IndexToName(i)
keyName := fmt.Sprintf("client.%s.%s", strings.Replace(c.store.Name, "-", ".", -1), daemonLetterID)
err = client.AuthDelete(c.context, c.store.Namespace, keyName)
if err != nil {
return err
}
}
// Delete the realm and pools
objContext := NewContext(c.context, c.store.Name, c.store.Namespace)
err = deleteRealmAndPools(objContext)
if err != nil {
return fmt.Errorf("failed to delete the realm and pools. %+v", err)
}
logger.Infof("Completed deleting object store %s", c.store.Name)
return nil
}
// Check if the object store exists depending on either the deployment or the daemonset
func (c *clusterConfig) storeExists() (bool, error) {
d, err := k8sutil.GetDeployments(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
// k8sutil.GetDeployments can return an empty list!
if err == nil && len(d.Items) != 0 {
// the deployment was found
return true, nil
}
if err != nil && !errors.IsNotFound(err) {
return false, err
}
dd, err := k8sutil.GetDaemonsets(c.context.Clientset, c.store.Namespace, c.storeLabelSelector())
// k8sutil.GetDaemonsets can return an empty list!
if err == nil && len(dd.Items) != 0 {
// the daemonset was found
return true, nil
}
if err != nil && !errors.IsNotFound(err) {
return false, err
}
// neither one was found
return false, nil
}
func (c *clusterConfig) instanceName() string {
return fmt.Sprintf("%s-%s", AppName, c.store.Name)
}
func (c *clusterConfig) storeLabelSelector() string {
return fmt.Sprintf("rook_object_store=%s", c.store.Name)
}
// Validate the object store arguments
func validateStore(context *clusterd.Context, s cephv1.CephObjectStore) error {
if s.Name == "" {
return fmt.Errorf("missing name")
}
if s.Namespace == "" {
return fmt.Errorf("missing namespace")
}
if err := pool.ValidatePoolSpec(context, s.Namespace, &s.Spec.MetadataPool); err != nil {
return fmt.Errorf("invalid metadata pool spec. %+v", err)
}
if err := pool.ValidatePoolSpec(context, s.Namespace, &s.Spec.DataPool); err != nil {
return fmt.Errorf("invalid data pool spec. %+v", err)
}
return nil
}