feedc0de/optional
1
0
Fork 0
forked from TartanLlama/optional
Code Pull Requests Activity

Fix assignment chaining

Browse Source
This commit is contained in:
Simon Brand
2017-10-21 21:29:29 +01:00
parent 0950f2e721
commit 9d61ea3a45
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
optional.hpp
View File

@@ -930,6 +930,8 @@ public:
new (std::addressof(this->m_value)) T(rhs.m_value); new (std::addressof(this->m_value)) T(rhs.m_value);
this->m_has_value = true; this->m_has_value = true;
} }
return *this;
} }
// TODO conditionally delete, check exception guarantee // TODO conditionally delete, check exception guarantee
@@ -952,6 +954,8 @@ public:
new (std::addressof(this->m_value)) T(std::move(rhs.m_value)); new (std::addressof(this->m_value)) T(std::move(rhs.m_value));
this->m_has_value = true; this->m_has_value = true;
} }
return *this;
} }
// TODO conditionally delete, check exception guarantee // TODO conditionally delete, check exception guarantee
@@ -965,6 +969,8 @@ public:
new (std::addressof(this->m_value)) T(std::forward<U>(u)); new (std::addressof(this->m_value)) T(std::forward<U>(u));
this->m_has_value = true; this->m_has_value = true;
} }
return *this;
} }
// TODO check exception guarantee // TODO check exception guarantee
@@ -988,6 +994,8 @@ public:
new (std::addressof(this->m_value)) T(*rhs); new (std::addressof(this->m_value)) T(*rhs);
this->m_has_value = true; this->m_has_value = true;
} }
return *this;
} }
// TODO check exception guarantee // TODO check exception guarantee
@@ -1010,6 +1018,8 @@ public:
new (std::addressof(this->m_value)) T(std::move(*rhs)); new (std::addressof(this->m_value)) T(std::move(*rhs));
this->m_has_value = true; this->m_has_value = true;
} }
return *this;
} }
/// Constructs the value in-place, destroying the current one if there is one. /// Constructs the value in-place, destroying the current one if there is one.