Update to experimental state in master :D #2

2019-09-22T19:16:16+02:00

neuron303 commented

2019-09-22 19:16:16 +02:00

(Migrated from github.com)

No description provided.

neuron303 commented

2019-09-22 19:31:01 +02:00

(Migrated from github.com)

LGTM :P
Travis fails but just does not support C++14 .. lets fix that later :D
totally not talking to myself

LGTM :P Travis fails but just does not support C++14 .. lets fix that later :D *totally not talking to myself*

0xFEEDC0DE64 (Migrated from github.com) requested changes 2019-09-23 15:19:08 +02:00

.travis.yml

0xFEEDC0DE64 (Migrated from github.com) commented

2019-09-23 12:14:58 +02:00

replace apt-get with new apt
install all in one command

Can we use this from travis: https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages

1. replace apt-get with new apt 2. install all in one command Can we use this from travis: https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages

osciwidget.cpp

						
				@@ -15,0 +17,4 @@

				OsciWidget::OsciWidget(QWidget *parent)

				    : QOpenGLWidget{parent}

				    , m_bufferOffset{m_buffer.begin()}

				    , m_lastBufferUpdate{0}

0xFEEDC0DE64 (Migrated from github.com) commented

2019-09-23 12:15:47 +02:00

anonymous namespace?

neuron303 (Migrated from github.com) reviewed 2019-09-23 21:46:23 +02:00

osciwidget.cpp

						
				@@ -15,0 +17,4 @@

				OsciWidget::OsciWidget(QWidget *parent)

				    : QOpenGLWidget{parent}

				    , m_bufferOffset{m_buffer.begin()}

				    , m_lastBufferUpdate{0}

neuron303 (Migrated from github.com) commented

2019-09-23 21:46:23 +02:00

Why? It is in its own compilation unit anyways. Is there a way this can be visible somewhere else? I use anonymous namespaces only for files that will be included, but I do not know best practices for this

neuron303 (Migrated from github.com) reviewed 2019-09-23 21:49:14 +02:00

osciwidget.cpp

						
				@@ -15,0 +17,4 @@

				OsciWidget::OsciWidget(QWidget *parent)

				    : QOpenGLWidget{parent}

				    , m_bufferOffset{m_buffer.begin()}

				    , m_lastBufferUpdate{0}

neuron303 (Migrated from github.com) commented

2019-09-23 21:49:14 +02:00

Well you are right of course .. you could link against it if you reuse the name :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: feedc0de/oscilloscope#2