feedc0de/platformio-core
1
0
Fork 0
forked from platformio/platformio-core
Code Pull Requests Activity

Fix PyLint's "use-dict-literal" and "use-list-literal"

Browse Source
This commit is contained in:
Ivan Kravets
2021-08-28 13:14:40 +03:00
parent d819617d2b
commit 131f4be4ea
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
platformio/builder/tools/piolib.py
View File

@ -128,9 +128,9 @@ class LibBuilderBase(object):
self._is_dependent = False self._is_dependent = False
self._is_built = False self._is_built = False
self._depbuilders = list() self._depbuilders = []
self._circular_deps = list() self._circular_deps = []
self._processed_files = list() self._processed_files = []
# reset source filter, could be overridden with extra script # reset source filter, could be overridden with extra script
self.env["SRC_FILTER"] = "" self.env["SRC_FILTER"] = ""

4
platformio/builder/tools/piosize.py
View File

@ -220,7 +220,7 @@ def DumpSizeData(_, target, source, env): # pylint: disable=unused-argument
"sections": sections, "sections": sections,
} }
files = dict() files = {}
for symbol in _collect_symbols_info(env, elffile, elf_path, sections): for symbol in _collect_symbols_info(env, elffile, elf_path, sections):
file_path = symbol.get("file") or "unknown" file_path = symbol.get("file") or "unknown"
if not files.get(file_path, {}): if not files.get(file_path, {}):
@ -235,7 +235,7 @@ def DumpSizeData(_, target, source, env): # pylint: disable=unused-argument
files[file_path]["symbols"].append(symbol) files[file_path]["symbols"].append(symbol)
data["memory"]["files"] = list() data["memory"]["files"] = []
for k, v in files.items(): for k, v in files.items():
file_data = {"path": k} file_data = {"path": k}
file_data.update(v) file_data.update(v)

4
platformio/commands/check/command.py
View File

@ -215,7 +215,7 @@ def print_processing_footer(result):
def collect_component_stats(result): def collect_component_stats(result):
components = dict() components = {}
def _append_defect(component, defect): def _append_defect(component, defect):
if not components.get(component): if not components.get(component):
@ -250,7 +250,7 @@ def print_defects_stats(results):
severity_labels = list(DefectItem.SEVERITY_LABELS.values()) severity_labels = list(DefectItem.SEVERITY_LABELS.values())
severity_labels.reverse() severity_labels.reverse()
tabular_data = list() tabular_data = []
for k, v in component_stats.items(): for k, v in component_stats.items():
tool_defect = [v.get(s, 0) for s in severity_labels] tool_defect = [v.get(s, 0) for s in severity_labels]
tabular_data.append([k] + tool_defect) tabular_data.append([k] + tool_defect)

2
platformio/commands/check/tools/cppcheck.py
View File

@ -64,7 +64,7 @@ class CppcheckCheckTool(CheckToolBase):
if any(f not in self._buffer for f in self.defect_fields): if any(f not in self._buffer for f in self.defect_fields):
return None return None
args = dict() args = {}
for field in self._buffer.split(self._field_delimiter): for field in self._buffer.split(self._field_delimiter):
field = field.strip().replace('"', "") field = field.strip().replace('"', "")
name, value = field.split("=", 1) name, value = field.split("=", 1)

4
platformio/package/lockfile.py
View File

@ -62,9 +62,9 @@ class LockFile(object):
else: else:
raise LockFileExists raise LockFileExists
self._fp = open( self._fp = open( # pylint: disable=consider-using-with
self._lock_path, mode="w", encoding="utf8" self._lock_path, mode="w", encoding="utf8"
) # pylint: disable=consider-using-with )
try: try:
if LOCKFILE_CURRENT_INTERFACE == LOCKFILE_INTERFACE_FCNTL: if LOCKFILE_CURRENT_INTERFACE == LOCKFILE_INTERFACE_FCNTL:
fcntl.flock(self._fp.fileno(), fcntl.LOCK_EX | fcntl.LOCK_NB) fcntl.flock(self._fp.fileno(), fcntl.LOCK_EX | fcntl.LOCK_NB)