feedc0de/platformio-core
1
0
Fork 0
forked from platformio/platformio-core
Code Pull Requests Activity

Fix "Unnecessary "else/elif" after "raise"" by PyLint

Browse Source
This commit is contained in:
Ivan Kravets
2019-03-07 12:35:34 +02:00
parent 5a72e3f2a1
commit 237d55208c
4 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platformio/commands/upgrade.py
View File

@ -84,9 +84,7 @@ WARNING! Don't use `sudo` for the rest PlatformIO commands.
fg="yellow", fg="yellow",
err=True) err=True)
raise exception.ReturnErrorCode(1) raise exception.ReturnErrorCode(1)
else: raise exception.UpgradeError("\n".join([str(cmd), r['out'], r['err']]))
raise exception.UpgradeError("\n".join(
[str(cmd), r['out'], r['err']]))
return True return True

3
platformio/managers/lib.py
View File

@ -277,8 +277,7 @@ class LibraryManager(BasePkgManager):
if not lib_info: if not lib_info:
if list(filters) == ["name"]: if list(filters) == ["name"]:
raise exception.LibNotFound(filters['name']) raise exception.LibNotFound(filters['name'])
else: raise exception.LibNotFound(str(filters))
raise exception.LibNotFound(str(filters))
if not silent: if not silent:
click.echo("Found: %s" % click.style( click.echo("Found: %s" % click.style(
"https://platformio.org/lib/show/{id}/{name}".format( "https://platformio.org/lib/show/{id}/{name}".format(

2
platformio/managers/package.py
View File

@ -481,7 +481,7 @@ class PkgInstallerMixin(object):
if versions is None: if versions is None:
util.internet_on(raise_exception=True) util.internet_on(raise_exception=True)
raise exception.UnknownPackage(name) raise exception.UnknownPackage(name)
elif not pkgdata: if not pkgdata:
raise exception.UndefinedPackageVersion(requirements or "latest", raise exception.UndefinedPackageVersion(requirements or "latest",
util.get_systype()) util.get_systype())
return pkg_dir return pkg_dir

5
platformio/util.py
View File

@ -643,10 +643,9 @@ def _get_api_result(
except requests.exceptions.HTTPError as e: except requests.exceptions.HTTPError as e:
if result and "message" in result: if result and "message" in result:
raise exception.APIRequestError(result['message']) raise exception.APIRequestError(result['message'])
elif result and "errors" in result: if result and "errors" in result:
raise exception.APIRequestError(result['errors'][0]['title']) raise exception.APIRequestError(result['errors'][0]['title'])
else: raise exception.APIRequestError(e)
raise exception.APIRequestError(e)
except ValueError: except ValueError:
raise exception.APIRequestError( raise exception.APIRequestError(
"Invalid response: %s" % r.text.encode("utf-8")) "Invalid response: %s" % r.text.encode("utf-8"))