Renamed "enable_ssl" setting to "strict_ssl"

HISTORY.rst

@@ -9,10 +9,11 @@ PlatformIO 4.0
 4.0.1 (2019-??-??)
 ~~~~~~~~~~~~~~~~~~
 
-* Print `debug tool <http://docs.platformio.org/en/latest/plus/debugging.html#tools-debug-probes>`__ name for the active debugging session
+* Print `debug tool <http://docs.platformio.org/page/plus/debugging.html#tools-debug-probes>`__ name for the active debugging session
 * Do not shutdown PIO Home Server for "upgrade" operations (`issue #2784 <https://github.com/platformio/platformio-core/issues/2784>`_)
 * Improved computing of project check sum (structure, configuration) and avoid unnecessary rebuilding
-* Fixed an issue with incorrect escaping of Windows slashes when using `PIO Unified Debugger <http://docs.platformio.org/en/latest/plus/debugging.html>`__ and "piped" openOCD
+* Renamed "enable_ssl" setting to `strict_ssl <http://docs.platformio.org/page/userguide/cmd_settings.html#strict-ssl>`__
+* Fixed an issue with incorrect escaping of Windows slashes when using `PIO Unified Debugger <http://docs.platformio.org/page/plus/debugging.html>`__ and "piped" openOCD
 
 4.0.0 (2019-07-10)
 ~~~~~~~~~~~~~~~~~~

README.rst

@@ -129,12 +129,13 @@ Contributing
 See `contributing guidelines <https://github.com/platformio/platformio/blob/develop/CONTRIBUTING.md>`_.
 
 Telemetry / Privacy Policy
----------------------------
+--------------------------
 
-Share diagnostics and usage information to help us make PlatformIO better. It is enabled by default. For more information see:
+Share minimal diagnostics and usage information to help us make PlatformIO better.
+It is enabled by default. For more information see:
 
 * `Telemetry Setting <https://docs.platformio.org/en/latest/userguide/cmd_settings.html?utm_source=github&utm_medium=core#enable-telemetry>`_
-* `SSL Setting <https://docs.platformio.org/en/latest/userguide/cmd_settings.html?utm_source=github&utm_medium=core#enable-ssl>`_
+* `SSL Setting <https://docs.platformio.org/en/latest/userguide/cmd_settings.html?utm_source=github&utm_medium=core#strict-ssl>`_
 
 License
 -------

platformio/app.py

@@ -73,8 +73,8 @@ DEFAULT_SETTINGS = {
         "description": "Enable caching for API requests and Library Manager",
         "value": True
     },
-    "enable_ssl": {
-        "description": "Enable SSL for PlatformIO Services",
+    "strict_ssl": {
+        "description": "Strict SSL for PlatformIO Services",
         "value": False
     },
     "enable_telemetry": {

platformio/managers/lib.py

@@ -211,7 +211,7 @@ class LibraryManager(BasePkgManager):
 
         return self._install_from_url(
             name, dl_data['url'].replace("http://", "https://")
-            if app.get_setting("enable_ssl") else dl_data['url'], requirements)
+            if app.get_setting("strict_ssl") else dl_data['url'], requirements)
 
     def search_lib_id(  # pylint: disable=too-many-branches
             self,

platformio/managers/platform.py

@@ -47,7 +47,7 @@ class PlatformManager(BasePkgManager):
             repositories = [
                 "https://dl.bintray.com/platformio/dl-platforms/manifest.json",
                 "{0}://dl.platformio.org/platforms/manifest.json".format(
-                    "https" if app.get_setting("enable_ssl") else "http")
+                    "https" if app.get_setting("strict_ssl") else "http")
             ]
         BasePkgManager.__init__(self, package_dir
                                 or get_project_platforms_dir(), repositories)

platformio/telemetry.py

@@ -302,6 +302,9 @@ def measure_ci():
         },
         "DRONE": {
             "label": getenv("DRONE_REPO_SLUG")
+        },
+        "GITLAB": {
+            "label": getenv("CI_PROJECT_PATH_SLUG")
         }
     }
 

platformio/util.py

@@ -333,7 +333,7 @@ def _get_api_result(
     headers = get_request_defheaders()
     if not url.startswith("http"):
         url = __apiurl__ + url
-        if not get_setting("enable_ssl"):
+        if not get_setting("strict_ssl"):
             url = url.replace("https://", "http://")
 
     try: