Keep custom "unwantedRecommendations" when generating projects for VSCode // Resolve #4383

platformio/project/integration/tpls/vscode/.vscode/extensions.json.tpl

@@ -3,13 +3,20 @@
 % import re
 %
 % recommendations = set(["platformio.platformio-ide"])
+% unwantedRecommendations = set(["ms-vscode.cpptools-extension-pack"])
 % previous_json = os.path.join(project_dir, ".vscode", "extensions.json")
 % if os.path.isfile(previous_json):
 %   fp = open(previous_json)
 %   contents = re.sub(r"^\s*//.*$", "", fp.read(), flags=re.M).strip()
 %   fp.close()
 %   if contents:
-%       recommendations |= set(json.loads(contents).get("recommendations", []))
+%       try:
+%           data = json.loads(contents)
+%           recommendations |= set(data.get("recommendations", []))
+%           unwantedRecommendations |= set(data.get("unwantedRecommendations", []))
+%       except ValueError:
+%           pass
+%       end
 %   end
 % end
 {
@@ -21,6 +28,8 @@
 % end
     ],
     "unwantedRecommendations": [
-        "ms-vscode.cpptools-extension-pack"
+% for i, item in enumerate(sorted(unwantedRecommendations)):
+        "{{ item }}"{{ ("," if (i + 1) < len(unwantedRecommendations) else "") }}
+% end
     ]
 }