From c193a4ceb7c795acef8534c36091db0bf24ed1f1 Mon Sep 17 00:00:00 2001 From: Ivan Kravets Date: Thu, 23 Jul 2020 19:07:29 +0300 Subject: [PATCH] Handle proxy environment variables in lower case // Resolve #3606 --- platformio/util.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/platformio/util.py b/platformio/util.py index 6a664c49..c2223109 100644 --- a/platformio/util.py +++ b/platformio/util.py @@ -377,10 +377,12 @@ def _internet_on(): socket.setdefaulttimeout(timeout) for host in PING_REMOTE_HOSTS: try: - if os.getenv("HTTP_PROXY", os.getenv("HTTPS_PROXY")): + for var in ("HTTP_PROXY", "HTTPS_PROXY"): + if not os.getenv(var, var.lower()): + continue requests.get("http://%s" % host, allow_redirects=False, timeout=timeout) - else: - socket.socket(socket.AF_INET, socket.SOCK_STREAM).connect((host, 80)) + return True + socket.socket(socket.AF_INET, socket.SOCK_STREAM).connect((host, 80)) return True except: # pylint: disable=bare-except pass