feedc0de/platformio-core
1
0
Fork 0
forked from platformio/platformio-core
Code Pull Requests Activity

Iterating the dictionary directly instead of calling .keys()

Browse Source
This commit is contained in:
Ivan Kravets
2016-07-09 15:26:38 +03:00
parent a73a710364
commit f12c721f44
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platformio/platforms/base.py
View File

@ -330,7 +330,7 @@ class BasePlatform(object):
def get_installed_packages(self): def get_installed_packages(self):
pm = PackageManager() pm = PackageManager()
return [n for n in self.get_packages().keys() if pm.is_installed(n)] return [n for n in self.get_packages() if pm.is_installed(n)]
def install(self, with_packages=None, without_packages=None, def install(self, with_packages=None, without_packages=None,
skip_default_packages=False): skip_default_packages=False):
@ -380,7 +380,7 @@ class BasePlatform(object):
deppkgs = deppkgs.union(set(p.get_packages().keys())) deppkgs = deppkgs.union(set(p.get_packages().keys()))
pm = PackageManager() pm = PackageManager()
for name in self.get_packages().keys(): for name in self.get_packages():
if not pm.is_installed(name) or name in deppkgs: if not pm.is_installed(name) or name in deppkgs:
continue continue
pm.uninstall(name) pm.uninstall(name)