From 0b09d08fb1991b8f6c36d2ade71f069650a7f8a8 Mon Sep 17 00:00:00 2001
From: Matthew Bucci <buccim2@gene.com>
Date: Tue, 16 Jan 2024 22:17:07 -0800
Subject: [PATCH] remove unncessary string replacement for != to <>

---
 pg4wp/rewriters/SelectSQLRewriter.php |  1 -
 tests/rewriteTest.php                 | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/pg4wp/rewriters/SelectSQLRewriter.php b/pg4wp/rewriters/SelectSQLRewriter.php
index 90b6d37..d90b8f0 100644
--- a/pg4wp/rewriters/SelectSQLRewriter.php
+++ b/pg4wp/rewriters/SelectSQLRewriter.php
@@ -110,7 +110,6 @@ class SelectSQLRewriter extends AbstractSQLRewriter
         if(isset($wpdb)) {
             $sql = str_replace('GROUP BY ' . $wpdb->prefix . 'posts.ID', '', $sql);
         }
-        $sql = str_replace("!= ''", '<> 0', $sql);
 
         // MySQL 'LIKE' is case insensitive by default, whereas PostgreSQL 'LIKE' is
         $sql = str_replace(' LIKE ', ' ILIKE ', $sql);
diff --git a/tests/rewriteTest.php b/tests/rewriteTest.php
index 786c3a3..5ea4c30 100644
--- a/tests/rewriteTest.php
+++ b/tests/rewriteTest.php
@@ -382,6 +382,27 @@ final class rewriteTest extends TestCase
         $this->assertSame(trim($expected), trim($postgresql));
     }
 
+    public function test_it_doesnt_rewrite_when_it_doesnt_need_to()
+    {
+        $sql = <<<SQL
+            SELECT p.ID FROM wp_posts p 
+            WHERE post_type='scheduled-action' 
+            AND p.post_status IN ('pending') 
+            AND p.post_modified_gmt <= '2023-11-27 14:23:34' 
+            AND p.post_password != '' ORDER BY p.post_date_gmt ASC LIMIT 0, 20
+        SQL;
+
+        $expected = <<<SQL
+            SELECT p."ID" , p.post_date_gmt FROM wp_posts p 
+            WHERE post_type='scheduled-action' 
+            AND p.post_status IN ('pending') 
+            AND p.post_modified_gmt <= '2023-11-27 14:23:34' 
+            AND p.post_password != '' ORDER BY p.post_date_gmt ASC LIMIT 20 OFFSET 0
+        SQL;
+
+        $postgresql = pg4wp_rewrite($sql);
+        $this->assertSame(trim($expected), trim($postgresql));
+    }
 
 
     protected function setUp(): void