feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
Files
05d7343018c452beb9027f27134e902e18c05004
qt-creator/tests/unit/unittest/sqlitetransaction-test.cpp

373 lines
12 KiB
C++
Raw Normal View History

Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "googletest.h"
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
#include "mocksqlitetransactionbackend.h"
Sqlite: Move result count to class declaration It move the magic number of column results to the sql statement and improves the mock a little bit. Change-Id: I101067444cf27ec5dea0c72de7fd484a7e8710f0 Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-24 18:10:55 +01:00
#include <sqlitedatabasemock.h>
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
#include <sqliteexception.h>
Sqlite: Move result count to class declaration It move the magic number of column results to the sql statement and improves the mock a little bit. Change-Id: I101067444cf27ec5dea0c72de7fd484a7e8710f0 Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-03-24 18:10:55 +01:00
#include <sqlitetransaction.h>
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
namespace {
Sqlite: Add session support Session are captured by hooking in the sqlite changes. They are saved in blobs and containing inserts, update and deletes. Because the are semantically coupled to translactions we add a Change-Id: Ie095558ebc50601fcaae32958ebeeb98b72d73b9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-27 23:48:03 +02:00
using Sqlite::DeferredNonThrowingDestructorTransaction;
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
using Sqlite::DeferredTransaction;
Sqlite: Add session support Session are captured by hooking in the sqlite changes. They are saved in blobs and containing inserts, update and deletes. Because the are semantically coupled to translactions we add a Change-Id: Ie095558ebc50601fcaae32958ebeeb98b72d73b9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-27 23:48:03 +02:00
using Sqlite::ExclusiveNonThrowingDestructorTransaction;
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
using Sqlite::ExclusiveTransaction;
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
using Sqlite::ImmediateNonThrowingDestructorTransaction;
Sqlite: Add session support Session are captured by hooking in the sqlite changes. They are saved in blobs and containing inserts, update and deletes. Because the are semantically coupled to translactions we add a Change-Id: Ie095558ebc50601fcaae32958ebeeb98b72d73b9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-27 23:48:03 +02:00
using Sqlite::ImmediateSessionTransaction;
using Sqlite::ImmediateTransaction;
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
class SqliteTransaction : public testing::Test
{
protected:
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
NiceMock<MockSqliteTransactionBackend> mockTransactionBackend;
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
};
TEST_F(SqliteTransaction, DeferredTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
DeferredTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, DeferredTransactionCommitCallsInterface)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
DeferredTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
transaction.commit();
}
TEST_F(SqliteTransaction, DeferredTransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
DeferredTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
}
TEST_F(SqliteTransaction, ImmediateTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, immediateBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
ImmediateTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
transaction.commit();
}
TEST_F(SqliteTransaction, ImmediateTransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, immediateBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
ImmediateTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
}
TEST_F(SqliteTransaction, ExclusiveTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, exclusiveBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
ExclusiveTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
transaction.commit();
}
TEST_F(SqliteTransaction, ExclusiveTransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
EXPECT_CALL(mockTransactionBackend, exclusiveBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
ExclusiveTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
}
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
TEST_F(SqliteTransaction, DeferredNonThrowingDestructorTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
DeferredNonThrowingDestructorTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, DeferredNonThrowingDestructorTransactionCommitCallsInterface)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
DeferredNonThrowingDestructorTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, DeferredNonThrowingDestructorTransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, deferredBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
DeferredNonThrowingDestructorTransaction transaction{mockTransactionBackend};
}
TEST_F(SqliteTransaction, ImmediateNonThrowingDestructorTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, immediateBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ImmediateNonThrowingDestructorTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, ImmediateNonThrowingDestructorTransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, immediateBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ImmediateNonThrowingDestructorTransaction transaction{mockTransactionBackend};
}
TEST_F(SqliteTransaction, ExclusiveNonThrowingDestructorTransactionCommit)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, exclusiveBegin());
EXPECT_CALL(mockTransactionBackend, commit());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ExclusiveNonThrowingDestructorTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, ExclusiveTNonThrowingDestructorransactionRollBack)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, exclusiveBegin());
EXPECT_CALL(mockTransactionBackend, rollback());
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ExclusiveNonThrowingDestructorTransaction transaction{mockTransactionBackend};
}
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
TEST_F(SqliteTransaction, DeferredTransactionBeginThrows)
{
ON_CALL(mockTransactionBackend, deferredBegin())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(DeferredTransaction{mockTransactionBackend},
Sqlite::Exception);
}
TEST_F(SqliteTransaction, ImmediateTransactionBeginThrows)
{
ON_CALL(mockTransactionBackend, immediateBegin())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(ImmediateTransaction{mockTransactionBackend},
Sqlite::Exception);
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
}
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
TEST_F(SqliteTransaction, ExclusiveTransactionBeginThrows)
{
ON_CALL(mockTransactionBackend, exclusiveBegin())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(ExclusiveTransaction{mockTransactionBackend},
Sqlite::Exception);
}
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
TEST_F(SqliteTransaction, DeferredTransactionBeginThrowsAndNotRollback)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, deferredBegin())
.WillOnce(Throw(Sqlite::Exception("foo")));
EXPECT_CALL(mockTransactionBackend, rollback()).Times(0);
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ASSERT_ANY_THROW(DeferredTransaction{mockTransactionBackend});
}
TEST_F(SqliteTransaction, ImmediateTransactionBeginThrowsAndNotRollback)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, immediateBegin())
.WillOnce(Throw(Sqlite::Exception("foo")));
EXPECT_CALL(mockTransactionBackend, rollback()).Times(0);
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ASSERT_ANY_THROW(ImmediateTransaction{mockTransactionBackend});
}
TEST_F(SqliteTransaction, ExclusiveTransactionBeginThrowsAndNotRollback)
{
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
EXPECT_CALL(mockTransactionBackend, exclusiveBegin())
.WillOnce(Throw(Sqlite::Exception("foo")));
EXPECT_CALL(mockTransactionBackend, rollback()).Times(0);
Clang: Cleanup transaction statements in the database Change-Id: I795248492fe952c230fd3a9cf8bf16f3c831f161 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 10:38:04 +02:00
EXPECT_CALL(mockTransactionBackend, unlock());
Clang: Handle a busy database in the PCH plugin This can be always happen for write statements. It fixes the wrong behavior of the transaction that it tried to rollback if begin fails. If begin fails the transaction never started so there is nothing to rollback. Change-Id: I8a03162257fa22a0bb66ccb844f90c6afbc7db64 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-28 16:25:01 +02:00
ASSERT_ANY_THROW(ExclusiveTransaction{mockTransactionBackend});
}
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
TEST_F(SqliteTransaction, TransactionCommitThrows)
{
ON_CALL(mockTransactionBackend, commit())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ImmediateTransaction transaction{mockTransactionBackend};
Sqlite: Add locking for sqlite transactions If you use the database in a multi-threaded environment, you must always your statements in transactions. For read-only statements, you use DeferredTransaction and write statements you use ImmediateTransaction. If you mix read and write statements you have to use ImmediateTransaction. Don't use DeferredTransaction because it leads to undefined behavior. Change-Id: Ida298a20f33423c8da09e768a7b658dd8e918f46 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io> Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-09-19 11:48:47 +02:00
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
ASSERT_THROW(transaction.commit(),
Sqlite::Exception);
}
TEST_F(SqliteTransaction, TransactionRollbackInDestructorThrows)
{
ON_CALL(mockTransactionBackend, rollback())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(ExclusiveTransaction{mockTransactionBackend},
Sqlite::Exception);
}
TEST_F(SqliteTransaction, TransactionRollbackInDestructorDontThrows)
{
ON_CALL(mockTransactionBackend, rollback())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_NO_THROW(ExclusiveNonThrowingDestructorTransaction{mockTransactionBackend});
}
Sqlite: Add session support Session are captured by hooking in the sqlite changes. They are saved in blobs and containing inserts, update and deletes. Because the are semantically coupled to translactions we add a Change-Id: Ie095558ebc50601fcaae32958ebeeb98b72d73b9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-27 23:48:03 +02:00
TEST_F(SqliteTransaction, ImmediateSessionTransactionCommit)
{
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
EXPECT_CALL(mockTransactionBackend, immediateSessionBegin());
EXPECT_CALL(mockTransactionBackend, sessionCommit());
EXPECT_CALL(mockTransactionBackend, unlock());
ImmediateSessionTransaction transaction{mockTransactionBackend};
transaction.commit();
}
TEST_F(SqliteTransaction, ImmediateSessionTransactionRollBack)
{
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
EXPECT_CALL(mockTransactionBackend, immediateSessionBegin());
EXPECT_CALL(mockTransactionBackend, sessionRollback());
EXPECT_CALL(mockTransactionBackend, unlock());
ImmediateSessionTransaction transaction{mockTransactionBackend};
}
TEST_F(SqliteTransaction, SessionTransactionRollbackInDestructorThrows)
{
ON_CALL(mockTransactionBackend, sessionRollback()).WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(ImmediateSessionTransaction{mockTransactionBackend}, Sqlite::Exception);
}
TEST_F(SqliteTransaction, ImmidiateSessionTransactionBeginThrows)
{
ON_CALL(mockTransactionBackend, immediateSessionBegin())
.WillByDefault(Throw(Sqlite::Exception("foo")));
ASSERT_THROW(ImmediateSessionTransaction{mockTransactionBackend}, Sqlite::Exception);
Sqlite: Transaction catch exception in destructor Fixes coverity warning. We want to throw an exception in the destructor in this case, which is save because it is a RAII pattern and holds only trivial values. Actually this is the only way to communicate that rollback was failing. It is quite rare that it will be happen without an exception is already thrown. There is a non throwing variant too if you want to use it as a class member. Change-Id: Ie71ead19678619465c6ad9334d36ee666225dce7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-05 11:23:36 +01:00
}
Sqlite: Add session support Session are captured by hooking in the sqlite changes. They are saved in blobs and containing inserts, update and deletes. Because the are semantically coupled to translactions we add a Change-Id: Ie095558ebc50601fcaae32958ebeeb98b72d73b9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-05-27 23:48:03 +02:00
TEST_F(SqliteTransaction, ImmediateSessionTransactionBeginThrowsAndNotRollback)
{
InSequence s;
EXPECT_CALL(mockTransactionBackend, lock());
EXPECT_CALL(mockTransactionBackend, immediateSessionBegin()).WillOnce(Throw(Sqlite::Exception("foo")));
EXPECT_CALL(mockTransactionBackend, sessionRollback()).Times(0);
EXPECT_CALL(mockTransactionBackend, unlock());
ASSERT_ANY_THROW(ImmediateSessionTransaction{mockTransactionBackend});
}
} // namespace
Copy Permalink