2010-02-16 10:36:09 +01:00
|
|
|
/**************************************************************************
|
|
|
|
**
|
|
|
|
** This file is part of Qt Creator
|
|
|
|
**
|
2010-03-05 11:25:49 +01:00
|
|
|
** Copyright (c) 2010 Nokia Corporation and/or its subsidiary(-ies).
|
2010-02-16 10:36:09 +01:00
|
|
|
**
|
|
|
|
** Contact: Nokia Corporation (qt-info@nokia.com)
|
|
|
|
**
|
|
|
|
** Commercial Usage
|
|
|
|
**
|
|
|
|
** Licensees holding valid Qt Commercial licenses may use this file in
|
|
|
|
** accordance with the Qt Commercial License Agreement provided with the
|
|
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
|
|
** a written agreement between you and Nokia.
|
|
|
|
**
|
|
|
|
** GNU Lesser General Public License Usage
|
|
|
|
**
|
|
|
|
** Alternatively, this file may be used under the terms of the GNU Lesser
|
|
|
|
** General Public License version 2.1 as published by the Free Software
|
|
|
|
** Foundation and appearing in the file LICENSE.LGPL included in the
|
|
|
|
** packaging of this file. Please review the following information to
|
|
|
|
** ensure the GNU Lesser General Public License version 2.1 requirements
|
|
|
|
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
|
|
|
|
**
|
|
|
|
** If you are unsure which license is appropriate for your use, please
|
|
|
|
** contact the sales department at http://qt.nokia.com/contact.
|
|
|
|
**
|
|
|
|
**************************************************************************/
|
|
|
|
|
|
|
|
#include "qmljscheck.h"
|
|
|
|
#include "qmljsbind.h"
|
|
|
|
#include "qmljsinterpreter.h"
|
2010-02-16 11:53:21 +01:00
|
|
|
#include "qmljsevaluate.h"
|
2010-02-16 10:36:09 +01:00
|
|
|
#include "parser/qmljsast_p.h"
|
|
|
|
|
|
|
|
#include <QtCore/QDebug>
|
2010-02-23 14:36:38 +01:00
|
|
|
#include <QtGui/QColor>
|
2010-02-23 12:36:12 +01:00
|
|
|
#include <QtGui/QApplication>
|
2010-02-16 10:36:09 +01:00
|
|
|
|
|
|
|
using namespace QmlJS;
|
|
|
|
using namespace QmlJS::AST;
|
|
|
|
using namespace QmlJS::Interpreter;
|
|
|
|
|
2010-07-29 11:20:06 +02:00
|
|
|
QColor QmlJS::toQColor(const QString &qmlColorString)
|
|
|
|
{
|
|
|
|
QColor color;
|
|
|
|
if (qmlColorString.size() == 9 && qmlColorString.at(0) == QLatin1Char('#')) {
|
|
|
|
bool ok;
|
|
|
|
const int alpha = qmlColorString.mid(1, 2).toInt(&ok, 16);
|
|
|
|
if (ok) {
|
|
|
|
QString name(qmlColorString.at(0));
|
|
|
|
name.append(qmlColorString.right(6));
|
|
|
|
if (QColor::isValidColor(name)) {
|
|
|
|
color.setNamedColor(name);
|
|
|
|
color.setAlpha(alpha);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (QColor::isValidColor(qmlColorString))
|
|
|
|
color.setNamedColor(qmlColorString);
|
|
|
|
}
|
|
|
|
return color;
|
|
|
|
}
|
2010-02-23 17:02:50 +01:00
|
|
|
|
2010-09-16 15:29:37 +02:00
|
|
|
SourceLocation QmlJS::locationFromRange(const SourceLocation &start,
|
|
|
|
const SourceLocation &end)
|
|
|
|
{
|
|
|
|
return SourceLocation(start.offset,
|
|
|
|
end.end() - start.begin(),
|
|
|
|
start.startLine,
|
|
|
|
start.startColumn);
|
|
|
|
}
|
|
|
|
|
|
|
|
DiagnosticMessage QmlJS::errorMessage(const AST::SourceLocation &loc, const QString &message)
|
|
|
|
{
|
|
|
|
return DiagnosticMessage(DiagnosticMessage::Error, loc, message);
|
|
|
|
}
|
|
|
|
|
2010-02-23 17:02:50 +01:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
class AssignmentCheck : public ValueVisitor
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
DiagnosticMessage operator()(
|
|
|
|
const SourceLocation &location,
|
|
|
|
const Interpreter::Value *lhsValue,
|
|
|
|
const Interpreter::Value *rhsValue,
|
|
|
|
ExpressionNode *ast)
|
|
|
|
{
|
|
|
|
_message = DiagnosticMessage(DiagnosticMessage::Error, location, QString());
|
|
|
|
_rhsValue = rhsValue;
|
|
|
|
_ast = ast;
|
|
|
|
|
|
|
|
if (lhsValue)
|
|
|
|
lhsValue->accept(this);
|
|
|
|
|
|
|
|
return _message;
|
|
|
|
}
|
|
|
|
|
2010-05-19 12:23:55 +02:00
|
|
|
virtual void visit(const NumberValue *value)
|
2010-02-23 17:02:50 +01:00
|
|
|
{
|
2010-05-19 12:23:55 +02:00
|
|
|
if (const QmlEnumValue *enumValue = dynamic_cast<const QmlEnumValue *>(value)) {
|
|
|
|
if (StringLiteral *stringLiteral = cast<StringLiteral *>(_ast)) {
|
|
|
|
const QString valueName = stringLiteral->value->asString();
|
|
|
|
|
|
|
|
if (!enumValue->keys().contains(valueName)) {
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("unknown value for enum");
|
2010-05-19 12:23:55 +02:00
|
|
|
}
|
|
|
|
} else if (_rhsValue->asUndefinedValue()) {
|
|
|
|
_message.kind = DiagnosticMessage::Warning;
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("value might be 'undefined'");
|
2010-05-19 12:23:55 +02:00
|
|
|
} else if (! _rhsValue->asStringValue() && ! _rhsValue->asNumberValue()) {
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("enum value is not a string or number");
|
2010-05-19 12:23:55 +02:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (/*cast<StringLiteral *>(_ast)
|
2010-02-23 17:02:50 +01:00
|
|
|
||*/ _ast->kind == Node::Kind_TrueLiteral
|
2010-05-19 12:23:55 +02:00
|
|
|
|| _ast->kind == Node::Kind_FalseLiteral) {
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("numerical value expected");
|
2010-05-19 12:23:55 +02:00
|
|
|
}
|
2010-02-23 17:02:50 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void visit(const BooleanValue *)
|
|
|
|
{
|
|
|
|
UnaryMinusExpression *unaryMinus = cast<UnaryMinusExpression *>(_ast);
|
|
|
|
|
|
|
|
if (cast<StringLiteral *>(_ast)
|
|
|
|
|| cast<NumericLiteral *>(_ast)
|
|
|
|
|| (unaryMinus && cast<NumericLiteral *>(unaryMinus->expression))) {
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("boolean value expected");
|
2010-02-23 17:02:50 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void visit(const StringValue *)
|
|
|
|
{
|
|
|
|
UnaryMinusExpression *unaryMinus = cast<UnaryMinusExpression *>(_ast);
|
|
|
|
|
|
|
|
if (cast<NumericLiteral *>(_ast)
|
|
|
|
|| (unaryMinus && cast<NumericLiteral *>(unaryMinus->expression))
|
|
|
|
|| _ast->kind == Node::Kind_TrueLiteral
|
|
|
|
|| _ast->kind == Node::Kind_FalseLiteral) {
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("string value expected");
|
2010-02-23 17:02:50 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void visit(const ColorValue *)
|
|
|
|
{
|
|
|
|
if (StringLiteral *stringLiteral = cast<StringLiteral *>(_ast)) {
|
2010-07-29 11:20:06 +02:00
|
|
|
if (!toQColor(stringLiteral->value->asString()).isValid())
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("not a valid color");
|
2010-02-23 17:02:50 +01:00
|
|
|
} else {
|
|
|
|
visit((StringValue *)0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void visit(const AnchorLineValue *)
|
|
|
|
{
|
|
|
|
if (! (_rhsValue->asAnchorLineValue() || _rhsValue->asUndefinedValue()))
|
2010-05-19 13:32:11 +02:00
|
|
|
_message.message = Check::tr("expected anchor line");
|
2010-02-23 17:02:50 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
DiagnosticMessage _message;
|
|
|
|
const Value *_rhsValue;
|
|
|
|
ExpressionNode *_ast;
|
|
|
|
};
|
|
|
|
|
|
|
|
} // end of anonymous namespace
|
|
|
|
|
|
|
|
|
2010-08-31 10:39:07 +02:00
|
|
|
Check::Check(Document::Ptr doc, const Snapshot &snapshot, const Context *linkedContextNoScope)
|
2010-02-16 10:36:09 +01:00
|
|
|
: _doc(doc)
|
|
|
|
, _snapshot(snapshot)
|
2010-08-31 10:39:07 +02:00
|
|
|
, _context(*linkedContextNoScope)
|
2010-02-19 15:55:11 +01:00
|
|
|
, _scopeBuilder(doc, &_context)
|
2010-08-26 10:50:00 +02:00
|
|
|
, _ignoreTypeErrors(false)
|
2010-02-16 10:36:09 +01:00
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
Check::~Check()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
QList<DiagnosticMessage> Check::operator()()
|
|
|
|
{
|
|
|
|
_messages.clear();
|
|
|
|
Node::accept(_doc->ast(), this);
|
|
|
|
return _messages;
|
|
|
|
}
|
|
|
|
|
2010-02-19 12:25:26 +01:00
|
|
|
bool Check::visit(UiProgram *)
|
2010-02-16 10:36:09 +01:00
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Check::visit(UiObjectDefinition *ast)
|
|
|
|
{
|
2010-02-16 13:28:43 +01:00
|
|
|
visitQmlObject(ast, ast->qualifiedTypeNameId, ast->initializer);
|
2010-02-16 10:36:09 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Check::visit(UiObjectBinding *ast)
|
|
|
|
{
|
|
|
|
checkScopeObjectMember(ast->qualifiedId);
|
|
|
|
|
2010-02-16 13:28:43 +01:00
|
|
|
visitQmlObject(ast, ast->qualifiedTypeNameId, ast->initializer);
|
2010-02-16 11:53:21 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2010-02-16 13:28:43 +01:00
|
|
|
void Check::visitQmlObject(Node *ast, UiQualifiedId *typeId,
|
|
|
|
UiObjectInitializer *initializer)
|
2010-02-16 11:53:21 +01:00
|
|
|
{
|
2010-02-17 09:29:13 +01:00
|
|
|
// If the 'typeId' starts with a lower-case letter, it doesn't define
|
|
|
|
// a new object instance. For instance: anchors { ... }
|
|
|
|
if (typeId->name->asString().at(0).isLower() && ! typeId->next) {
|
|
|
|
checkScopeObjectMember(typeId);
|
|
|
|
// ### don't give up!
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-02-19 15:55:11 +01:00
|
|
|
_scopeBuilder.push(ast);
|
2010-02-18 14:24:46 +01:00
|
|
|
|
2010-02-16 13:28:43 +01:00
|
|
|
if (! _context.lookupType(_doc.data(), typeId)) {
|
2010-04-07 10:43:09 +02:00
|
|
|
if (! _ignoreTypeErrors)
|
2010-04-28 10:32:45 +02:00
|
|
|
error(typeId->identifierToken,
|
2010-05-19 13:32:11 +02:00
|
|
|
Check::tr("unknown type"));
|
2010-02-19 15:55:11 +01:00
|
|
|
// suppress subsequent errors about scope object lookup by clearing
|
|
|
|
// the scope object list
|
|
|
|
// ### todo: better way?
|
|
|
|
_context.scopeChain().qmlScopeObjects.clear();
|
|
|
|
_context.scopeChain().update();
|
2010-02-16 13:28:43 +01:00
|
|
|
}
|
|
|
|
|
2010-02-16 11:53:21 +01:00
|
|
|
Node::accept(initializer, this);
|
2010-02-16 10:36:09 +01:00
|
|
|
|
2010-02-19 15:55:11 +01:00
|
|
|
_scopeBuilder.pop();
|
2010-02-16 10:36:09 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
bool Check::visit(UiScriptBinding *ast)
|
|
|
|
{
|
2010-02-23 14:55:38 +01:00
|
|
|
// special case for id property
|
|
|
|
if (ast->qualifiedId->name->asString() == QLatin1String("id") && ! ast->qualifiedId->next) {
|
|
|
|
if (! ast->statement)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const SourceLocation loc = locationFromRange(ast->statement->firstSourceLocation(),
|
|
|
|
ast->statement->lastSourceLocation());
|
|
|
|
|
|
|
|
ExpressionStatement *expStmt = cast<ExpressionStatement *>(ast->statement);
|
|
|
|
if (!expStmt) {
|
2010-05-19 13:32:11 +02:00
|
|
|
error(loc, Check::tr("expected id"));
|
2010-02-23 14:55:38 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2010-03-04 16:40:47 +01:00
|
|
|
QString id;
|
|
|
|
if (IdentifierExpression *idExp = cast<IdentifierExpression *>(expStmt->expression)) {
|
|
|
|
id = idExp->name->asString();
|
|
|
|
} else if (StringLiteral *strExp = cast<StringLiteral *>(expStmt->expression)) {
|
|
|
|
id = strExp->value->asString();
|
2010-05-19 13:32:11 +02:00
|
|
|
warning(loc, Check::tr("using string literals for ids is discouraged"));
|
2010-03-04 16:40:47 +01:00
|
|
|
} else {
|
2010-05-19 13:32:11 +02:00
|
|
|
error(loc, Check::tr("expected id"));
|
2010-02-23 14:55:38 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2010-03-04 16:40:47 +01:00
|
|
|
if (id.isEmpty() || ! id[0].isLower()) {
|
2010-05-19 13:32:11 +02:00
|
|
|
error(loc, Check::tr("ids must be lower case"));
|
2010-02-23 14:55:38 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-02-19 15:10:39 +01:00
|
|
|
const Value *lhsValue = checkScopeObjectMember(ast->qualifiedId);
|
|
|
|
if (lhsValue) {
|
|
|
|
// ### Fix the evaluator to accept statements!
|
|
|
|
if (ExpressionStatement *expStmt = cast<ExpressionStatement *>(ast->statement)) {
|
2010-02-23 12:36:12 +01:00
|
|
|
ExpressionNode *expr = expStmt->expression;
|
2010-02-23 14:36:38 +01:00
|
|
|
|
|
|
|
Evaluate evaluator(&_context);
|
|
|
|
const Value *rhsValue = evaluator(expr);
|
|
|
|
|
|
|
|
const SourceLocation loc = locationFromRange(expStmt->firstSourceLocation(),
|
|
|
|
expStmt->lastSourceLocation());
|
2010-02-23 17:02:50 +01:00
|
|
|
AssignmentCheck assignmentCheck;
|
|
|
|
DiagnosticMessage message = assignmentCheck(loc, lhsValue, rhsValue, expr);
|
|
|
|
if (! message.message.isEmpty())
|
|
|
|
_messages += message;
|
2010-02-19 15:10:39 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
2010-02-16 10:36:09 +01:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Check::visit(UiArrayBinding *ast)
|
|
|
|
{
|
|
|
|
checkScopeObjectMember(ast->qualifiedId);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2010-04-06 11:44:55 +02:00
|
|
|
/// When something is changed here, also change ReadingContext::lookupProperty in
|
|
|
|
/// texttomodelmerger.cpp
|
|
|
|
/// ### Maybe put this into the context as a helper method.
|
2010-02-19 15:10:39 +01:00
|
|
|
const Value *Check::checkScopeObjectMember(const UiQualifiedId *id)
|
2010-02-16 10:36:09 +01:00
|
|
|
{
|
2010-02-19 10:14:34 +01:00
|
|
|
QList<const ObjectValue *> scopeObjects = _context.scopeChain().qmlScopeObjects;
|
2010-02-19 15:55:11 +01:00
|
|
|
if (scopeObjects.isEmpty())
|
|
|
|
return 0;
|
2010-02-16 10:36:09 +01:00
|
|
|
|
|
|
|
if (! id)
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0; // ### error?
|
2010-02-16 10:36:09 +01:00
|
|
|
|
2010-04-06 11:44:55 +02:00
|
|
|
if (! id->name) // possible after error recovery
|
|
|
|
return 0;
|
|
|
|
|
2010-02-18 14:21:53 +01:00
|
|
|
QString propertyName = id->name->asString();
|
2010-02-16 10:36:09 +01:00
|
|
|
|
|
|
|
if (propertyName == QLatin1String("id") && ! id->next)
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0; // ### should probably be a special value
|
2010-02-16 10:36:09 +01:00
|
|
|
|
|
|
|
// attached properties
|
2010-02-18 15:01:26 +01:00
|
|
|
bool isAttachedProperty = false;
|
|
|
|
if (! propertyName.isEmpty() && propertyName[0].isUpper()) {
|
|
|
|
isAttachedProperty = true;
|
2010-08-30 13:31:50 +02:00
|
|
|
if (const ObjectValue *qmlTypes = _context.scopeChain().qmlTypes)
|
|
|
|
scopeObjects += qmlTypes;
|
2010-02-18 15:01:26 +01:00
|
|
|
}
|
2010-02-18 10:42:15 +01:00
|
|
|
|
2010-02-19 10:14:34 +01:00
|
|
|
if (scopeObjects.isEmpty())
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0;
|
2010-02-16 10:36:09 +01:00
|
|
|
|
2010-02-18 14:21:53 +01:00
|
|
|
// global lookup for first part of id
|
2010-02-19 10:14:34 +01:00
|
|
|
const Value *value = 0;
|
|
|
|
for (int i = scopeObjects.size() - 1; i >= 0; --i) {
|
|
|
|
value = scopeObjects[i]->lookupMember(propertyName, &_context);
|
|
|
|
if (value)
|
|
|
|
break;
|
|
|
|
}
|
2010-02-16 10:36:09 +01:00
|
|
|
if (!value) {
|
|
|
|
error(id->identifierToken,
|
2010-05-19 13:32:11 +02:00
|
|
|
Check::tr("'%1' is not a valid property name").arg(propertyName));
|
2010-02-16 10:36:09 +01:00
|
|
|
}
|
|
|
|
|
2010-02-18 15:01:26 +01:00
|
|
|
// can't look up members for attached properties
|
|
|
|
if (isAttachedProperty)
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0;
|
2010-02-18 15:01:26 +01:00
|
|
|
|
2010-02-18 14:21:53 +01:00
|
|
|
// member lookup
|
|
|
|
const UiQualifiedId *idPart = id;
|
|
|
|
while (idPart->next) {
|
|
|
|
const ObjectValue *objectValue = value_cast<const ObjectValue *>(value);
|
|
|
|
if (! objectValue) {
|
|
|
|
error(idPart->identifierToken,
|
2010-05-19 13:32:11 +02:00
|
|
|
Check::tr("'%1' does not have members").arg(propertyName));
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0;
|
2010-02-18 14:21:53 +01:00
|
|
|
}
|
|
|
|
|
2010-02-24 17:14:14 +01:00
|
|
|
if (! idPart->next->name) {
|
|
|
|
// somebody typed "id." and error recovery still gave us a valid tree,
|
|
|
|
// so just bail out here.
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-02-18 14:21:53 +01:00
|
|
|
idPart = idPart->next;
|
|
|
|
propertyName = idPart->name->asString();
|
|
|
|
|
|
|
|
value = objectValue->lookupMember(propertyName, &_context);
|
|
|
|
if (! value) {
|
|
|
|
error(idPart->identifierToken,
|
2010-05-19 13:32:11 +02:00
|
|
|
Check::tr("'%1' is not a member of '%2'").arg(
|
2010-04-28 10:32:45 +02:00
|
|
|
propertyName, objectValue->className()));
|
2010-02-19 15:10:39 +01:00
|
|
|
return 0;
|
2010-02-18 14:21:53 +01:00
|
|
|
}
|
|
|
|
}
|
2010-02-19 15:10:39 +01:00
|
|
|
|
|
|
|
return value;
|
2010-02-16 10:36:09 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void Check::error(const AST::SourceLocation &loc, const QString &message)
|
|
|
|
{
|
|
|
|
_messages.append(DiagnosticMessage(DiagnosticMessage::Error, loc, message));
|
|
|
|
}
|
|
|
|
|
|
|
|
void Check::warning(const AST::SourceLocation &loc, const QString &message)
|
|
|
|
{
|
|
|
|
_messages.append(DiagnosticMessage(DiagnosticMessage::Warning, loc, message));
|
|
|
|
}
|