feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
Files
69c6c9f7d5d585cb01ccbe6f9c7a14fc6420a3e2
qt-creator/src/plugins/qtsupport/qtparser.cpp

250 lines
12 KiB
C++
Raw Normal View History

Adjust license headers Change-Id: Ice592c6de9951ee3b2c4cb52ed0bb3b6770e0825 Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2012-10-02 09:12:39 +02:00
/****************************************************************************
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
**
Update License according to agreement with Free Qt Foundation * Update files in src/plugins Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-15 14:57:40 +01:00
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
**
Adjust license headers Change-Id: Ice592c6de9951ee3b2c4cb52ed0bb3b6770e0825 Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2012-10-02 09:12:39 +02:00
** This file is part of Qt Creator.
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
**
Adjust license headers Change-Id: Ice592c6de9951ee3b2c4cb52ed0bb3b6770e0825 Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2012-10-02 09:12:39 +02:00
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
Update License according to agreement with Free Qt Foundation * Update files in src/plugins Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-15 14:57:40 +01:00
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
**
Update License according to agreement with Free Qt Foundation * Update files in src/plugins Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
2016-01-15 14:57:40 +01:00
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
License headers.
2010-12-17 16:01:08 +01:00
**
Adjust license headers Change-Id: Ice592c6de9951ee3b2c4cb52ed0bb3b6770e0825 Reviewed-by: Eike Ziller <eike.ziller@digia.com>
2012-10-02 09:12:39 +02:00
****************************************************************************/
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
#include "qtparser.h"
Header cleanup in ProjectExplorer. Change-Id: I19f100003427ba43aaae5ba0dc7078088017cb09 Reviewed-on: http://codereview.qt.nokia.com/3178 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-08-18 13:46:52 +02:00
#include <projectexplorer/task.h>
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
#include <projectexplorer/projectexplorerconstants.h>
Header cleanup in ProjectExplorer. Change-Id: I19f100003427ba43aaae5ba0dc7078088017cb09 Reviewed-on: http://codereview.qt.nokia.com/3178 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-08-18 13:46:52 +02:00
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
#include <QFileInfo>
#ifdef WITH_TESTS
#include "qtsupportplugin.h"
#include <projectexplorer/outputparser_test.h>
#include <QTest>
#endif
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
using namespace ProjectExplorer;
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
namespace QtSupport {
Header cleanup in QtSupport. Change-Id: I681bab48aafb029f4869209382493dfa36233a2d Reviewed-on: http://codereview.qt.nokia.com/3081 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-08-17 11:34:57 +02:00
// opt. drive letter + filename: (2 brackets)
QtSupport: Fix moc output parser for Qt 6 Fixes: QTCREATORBUG-25959 Change-Id: Iba03fd31b1759ae99bd6567003b020e8ad35872f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:51:55 +02:00
#define FILE_PATTERN R"(^(?<file>(?:[A-Za-z]:)?[^:\(]+\.[^:\(]+))"
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
Header cleanup in ProjectExplorer. Change-Id: I19f100003427ba43aaae5ba0dc7078088017cb09 Reviewed-on: http://codereview.qt.nokia.com/3178 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
2011-08-18 13:46:52 +02:00
QtParser::QtParser() :
QtSupport: Fix moc output parser for Qt 6 Fixes: QTCREATORBUG-25959 Change-Id: Iba03fd31b1759ae99bd6567003b020e8ad35872f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:51:55 +02:00
m_mocRegExp(FILE_PATTERN R"([:\(](?<line>\d+)?(?::(?<column>\d+))?\)?:\s(?<level>[Ww]arning|[Ee]rror|[Nn]ote):\s(?<description>.+?)$)"),
QtSupport: De-noise regexes in output parsers a bit Use raw string literals to reduce the number of backslashes, and remove unneeded QLatin1String wrappers. Change-Id: I3b359e238311987d60e0307bad66c9c37f44b777 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 16:54:14 +02:00
m_uicRegExp(FILE_PATTERN R"(: Warning:\s(?<msg>.+?)$)"),
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
m_translationRegExp(R"(^(?<level>[Ww]arning|[Ee]rror):\s+(?<description>.*?) in '(?<file>.*?)'$)")
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
{
Parser debugging/testing improvements * Set objectname on all parsers to be able to distinguish between them more easily when debugging * Add some unit tests about pass-through of data we need in the gcc parser to the parsers that enhd up in front of the gcc parser This is to address QTCREATORBUG-1917.
2010-09-15 13:55:01 +02:00
setObjectName(QLatin1String("QtParser"));
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
}
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
Utils::OutputLineParser::Result QtParser::handleLine(const QString &line, Utils::OutputFormat type)
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
{
Output parsers: Replace the chaining approach Use "flat" aggregation instead. This is another step towards the formatter/parser merger. Along the way, also fix some some subclasses (mostly in BareMetal) that erroneously forwarded handled output to other parsers. Task-number: QTCREATORBUG-22665 Change-Id: I12947349ca663d2e6bbfc99efd069d69e2b54969 Reviewed-by: hjk <hjk@qt.io>
2020-04-08 17:45:39 +02:00
if (type != Utils::StdErrFormat)
return Status::NotHandled;
IOutputParser: Make sure to not cut too much output Introduce a method to cut away whitespaces from the end of a string and use it consistently. This avoids a chain of parsers to repeatedly cut away the last character, assuming that will be the line-break. Task-number: QTCREATORBUG-9032 Change-Id: I68261c10873535faf94c885c914cd00510ed75d8 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-04-02 15:21:59 +02:00
QString lne = rightTrimmed(line);
QtSupport: Replace QRegExp by QRegularExpression Task-number: QTCREATORBUG-24098 Change-Id: I1eefae2473919e3d2f9fa93d7d54797effd4a5f2 Reviewed-by: hjk <hjk@qt.io>
2020-06-16 08:59:54 +02:00
QRegularExpressionMatch match = m_mocRegExp.match(lne);
if (match.hasMatch()) {
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
bool ok;
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
int lineno = match.captured("line").toInt(&ok);
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
if (!ok)
lineno = -1;
Fix icons in tasks Create Tasks in such a way that they have the correct TaskType from the start. This makes sure the icon chosen by default is the correct one for that type and avoids the need to override the icon again later. Change-Id: Ic47f1d119a7d8f85fcb6f2ee9aaaeadf074f8348 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-01-14 10:28:16 +01:00
Task::TaskType type = Task::Error;
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
const QString level = match.captured("level");
QtParser: Also handle notes from moc Change-Id: I4ecbeb91be0890d8ab56ed6fe247fb8494856e74 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-24 11:46:58 +02:00
if (level.compare(QLatin1String("Warning"), Qt::CaseInsensitive) == 0)
Fix icons in tasks Create Tasks in such a way that they have the correct TaskType from the start. This makes sure the icon chosen by default is the correct one for that type and avoids the need to override the icon again later. Change-Id: Ic47f1d119a7d8f85fcb6f2ee9aaaeadf074f8348 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-01-14 10:28:16 +01:00
type = Task::Warning;
QtParser: Also handle notes from moc Change-Id: I4ecbeb91be0890d8ab56ed6fe247fb8494856e74 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-24 11:46:58 +02:00
if (level.compare(QLatin1String("Note"), Qt::CaseInsensitive) == 0)
type = Task::Unknown;
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
LinkSpecs linkSpecs;
const Utils::FilePath file
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
= absoluteFilePath(Utils::FilePath::fromUserInput(match.captured("file")));
addLinkSpecForAbsoluteFilePath(linkSpecs, file, lineno, match, "file");
CompileTask task(type, match.captured("description").trimmed(), file, lineno);
QtSupport: Fix moc output parser for Qt 6 Fixes: QTCREATORBUG-25959 Change-Id: Iba03fd31b1759ae99bd6567003b020e8ad35872f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:51:55 +02:00
task.column = match.captured("column").toInt();
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
scheduleTask(task, 1);
return {Status::Done, linkSpecs};
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
}
ProjectExplorer: Remove some Qt-specific parser tests Warnings from uic and moc should be caught by the QtParser, not by the LdParser, as they currently are. We move the uic test case to QtSupport, and we remove the three identical moc test cases, as the exact same output is already checked in QtSupport. Task-number: QTCREATORBUG-25677 Change-Id: Iec0203c2be60a80bd6ef0a090a9828f59ae6b482 Reviewed-by: hjk <hjk@qt.io>
2021-05-06 16:29:42 +02:00
match = m_uicRegExp.match(lne);
if (match.hasMatch()) {
const QString fileName = match.captured(1);
QString message = match.captured("msg").trimmed();
Utils::FilePath filePath;
LinkSpecs linkSpecs;
bool isUicMessage = true;
if (fileName == "uic" || fileName == "stdin") {
message.prepend(": ").prepend(fileName);
} else if (fileName.endsWith(".ui")) {
filePath = absoluteFilePath(Utils::FilePath::fromUserInput(fileName));
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
addLinkSpecForAbsoluteFilePath(linkSpecs, filePath, -1, match, "file");
ProjectExplorer: Remove some Qt-specific parser tests Warnings from uic and moc should be caught by the QtParser, not by the LdParser, as they currently are. We move the uic test case to QtSupport, and we remove the three identical moc test cases, as the exact same output is already checked in QtSupport. Task-number: QTCREATORBUG-25677 Change-Id: Iec0203c2be60a80bd6ef0a090a9828f59ae6b482 Reviewed-by: hjk <hjk@qt.io>
2021-05-06 16:29:42 +02:00
} else {
isUicMessage = false;
}
if (isUicMessage) {
scheduleTask(CompileTask(Task::Warning, message, filePath), 1);
return {Status::Done, linkSpecs};
}
}
QtSupport: Replace QRegExp by QRegularExpression Task-number: QTCREATORBUG-24098 Change-Id: I1eefae2473919e3d2f9fa93d7d54797effd4a5f2 Reviewed-by: hjk <hjk@qt.io>
2020-06-16 08:59:54 +02:00
match = m_translationRegExp.match(line);
if (match.hasMatch()) {
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
Task::TaskType type = Task::Warning;
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
if (match.captured("level") == QLatin1String("Error"))
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
type = Task::Error;
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
LinkSpecs linkSpecs;
const Utils::FilePath file
QtSupport: Use named capture groups in output parsers The regular expressions are easier to understand this way. Change-Id: Iae225b0214b12833ae6d6094e70250700a1c0e52 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:07:04 +02:00
= absoluteFilePath(Utils::FilePath::fromUserInput(match.captured("file")));
addLinkSpecForAbsoluteFilePath(linkSpecs, file, 0, match, "file");
CompileTask task(type, match.captured("description"), file);
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
scheduleTask(task, 1);
return {Status::Done, linkSpecs};
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
}
Output parsers: Replace the chaining approach Use "flat" aggregation instead. This is another step towards the formatter/parser merger. Along the way, also fix some some subclasses (mostly in BareMetal) that erroneously forwarded handled output to other parsers. Task-number: QTCREATORBUG-22665 Change-Id: I12947349ca663d2e6bbfc99efd069d69e2b54969 Reviewed-by: hjk <hjk@qt.io>
2020-04-08 17:45:39 +02:00
return Status::NotHandled;
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
}
// Unit tests:
#ifdef WITH_TESTS
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
namespace Internal {
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
Move QtParser to QtSupport plugin This way we can make use of it in the cmake plugin Change-Id: Ie1887d49ea616ec62d91a73b4daa75d69cef61c9 Reviewed-on: http://codereview.qt.nokia.com/91 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
2011-05-24 16:15:15 +02:00
void QtSupportPlugin::testQtOutputParser_data()
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
{
QTest::addColumn<QString>("input");
QTest::addColumn<OutputParserTester::Channel>("inputChannel");
QTest::addColumn<QString>("childStdOutLines");
QTest::addColumn<QString>("childStdErrLines");
ProjectExplorer: Introduce a alias for QList<Tasks> Change-Id: I91391ad22b420926b0f512cac23cfe009048b218 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-27 16:09:44 +02:00
QTest::addColumn<Tasks >("tasks");
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
QTest::addColumn<QString>("outputLines");
QTest::newRow("pass-through stdout")
<< QString::fromLatin1("Sometext") << OutputParserTester::STDOUT
Parser: Make parser test engine more strict * Fix unit tests to work with this stricter version Change-Id: Iaf6d333e4b4df54ddc340d261ce28538bfa1f3cf
2011-05-18 18:39:14 +02:00
<< QString::fromLatin1("Sometext\n") << QString()
ProjectExplorer: Introduce a alias for QList<Tasks> Change-Id: I91391ad22b420926b0f512cac23cfe009048b218 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-27 16:09:44 +02:00
<< Tasks()
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
<< QString();
QTest::newRow("pass-through stderr")
<< QString::fromLatin1("Sometext") << OutputParserTester::STDERR
Parser: Make parser test engine more strict * Fix unit tests to work with this stricter version Change-Id: Iaf6d333e4b4df54ddc340d261ce28538bfa1f3cf
2011-05-18 18:39:14 +02:00
<< QString() << QString::fromLatin1("Sometext\n")
ProjectExplorer: Introduce a alias for QList<Tasks> Change-Id: I91391ad22b420926b0f512cac23cfe009048b218 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-27 16:09:44 +02:00
<< Tasks()
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
<< QString();
Parser debugging/testing improvements * Set objectname on all parsers to be able to distinguish between them more easily when debugging * Add some unit tests about pass-through of data we need in the gcc parser to the parsers that enhd up in front of the gcc parser This is to address QTCREATORBUG-1917.
2010-09-15 13:55:01 +02:00
QTest::newRow("pass-through gcc infos")
<< QString::fromLatin1("/temp/test/untitled8/main.cpp: In function `int main(int, char**)':\n"
"../../scriptbug/main.cpp: At global scope:\n"
"../../scriptbug/main.cpp: In instantiation of void bar(i) [with i = double]:\n"
"../../scriptbug/main.cpp:8: instantiated from void foo(i) [with i = double]\n"
Parser: Make parser test engine more strict * Fix unit tests to work with this stricter version Change-Id: Iaf6d333e4b4df54ddc340d261ce28538bfa1f3cf
2011-05-18 18:39:14 +02:00
"../../scriptbug/main.cpp:22: instantiated from here")
Parser debugging/testing improvements * Set objectname on all parsers to be able to distinguish between them more easily when debugging * Add some unit tests about pass-through of data we need in the gcc parser to the parsers that enhd up in front of the gcc parser This is to address QTCREATORBUG-1917.
2010-09-15 13:55:01 +02:00
<< OutputParserTester::STDERR
<< QString()
<< QString::fromLatin1("/temp/test/untitled8/main.cpp: In function `int main(int, char**)':\n"
"../../scriptbug/main.cpp: At global scope:\n"
"../../scriptbug/main.cpp: In instantiation of void bar(i) [with i = double]:\n"
"../../scriptbug/main.cpp:8: instantiated from void foo(i) [with i = double]\n"
"../../scriptbug/main.cpp:22: instantiated from here\n")
ProjectExplorer: Introduce a alias for QList<Tasks> Change-Id: I91391ad22b420926b0f512cac23cfe009048b218 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-27 16:09:44 +02:00
<< Tasks()
Parser debugging/testing improvements * Set objectname on all parsers to be able to distinguish between them more easily when debugging * Add some unit tests about pass-through of data we need in the gcc parser to the parsers that enhd up in front of the gcc parser This is to address QTCREATORBUG-1917.
2010-09-15 13:55:01 +02:00
<< QString();
QtParser handles qdoc errors too (case-insensitive error/warning) I thought this was already working but it turns out that gccparser was catching it instead. That probably won't work on Windows. https://codereview.qt-project.org/#change,35510 - qdoc will output the text "error:" or "warning:" now so that creator will make proper "issues" in the issue list. Change-Id: I9db13062335c1a2325b0937e43041058510d05dd Reviewed-by: Martin Smith <martin.smith@digia.com> Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-10-11 18:32:08 +02:00
QTest::newRow("qdoc warning")
<< QString::fromLatin1("/home/user/dev/qt5/qtscript/src/script/api/qscriptengine.cpp:295: warning: Can't create link to 'Object Trees & Ownership'")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Warning,
QtParser handles qdoc errors too (case-insensitive error/warning) I thought this was already working but it turns out that gccparser was catching it instead. That probably won't work on Windows. https://codereview.qt-project.org/#change,35510 - qdoc will output the text "error:" or "warning:" now so that creator will make proper "issues" in the issue list. Change-Id: I9db13062335c1a2325b0937e43041058510d05dd Reviewed-by: Martin Smith <martin.smith@digia.com> Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-10-11 18:32:08 +02:00
QLatin1String("Can't create link to 'Object Trees & Ownership'"),
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
Utils::FilePath::fromUserInput(QLatin1String("/home/user/dev/qt5/qtscript/src/script/api/qscriptengine.cpp")), 295))
QtParser handles qdoc errors too (case-insensitive error/warning) I thought this was already working but it turns out that gccparser was catching it instead. That probably won't work on Windows. https://codereview.qt-project.org/#change,35510 - qdoc will output the text "error:" or "warning:" now so that creator will make proper "issues" in the issue list. Change-Id: I9db13062335c1a2325b0937e43041058510d05dd Reviewed-by: Martin Smith <martin.smith@digia.com> Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-10-11 18:32:08 +02:00
<< QString();
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
QTest::newRow("moc warning")
<< QString::fromLatin1("..\\untitled\\errorfile.h:0: Warning: No relevant classes found. No output generated.")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Warning,
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
QLatin1String("No relevant classes found. No output generated."),
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
Utils::FilePath::fromUserInput(QLatin1String("..\\untitled\\errorfile.h")), -1))
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
<< QString();
Parser: Handle changed moc error reporting
2011-01-20 11:16:00 +01:00
QTest::newRow("moc warning 2")
<< QString::fromLatin1("c:\\code\\test.h(96): Warning: Property declaration ) has no READ accessor function. The property will be invalid.")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Warning,
Parser: Handle changed moc error reporting
2011-01-20 11:16:00 +01:00
QLatin1String("Property declaration ) has no READ accessor function. The property will be invalid."),
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
Utils::FilePath::fromUserInput(QLatin1String("c:\\code\\test.h")), 96))
Parser: Handle changed moc error reporting
2011-01-20 11:16:00 +01:00
<< QString();
QtSupport: Fix moc output parser for Qt 6 Fixes: QTCREATORBUG-25959 Change-Id: Iba03fd31b1759ae99bd6567003b020e8ad35872f Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-07-26 17:51:55 +02:00
QTest::newRow("moc warning (Qt 6/Windows)")
<< QString::fromLatin1(R"(C:/Users/alportal/dev/qt-creator-qt6/src/plugins/qmlprofiler/qmlprofilerplugin.h(38:1): error: Plugin Metadata file "QmlProfiler.json" does not exist. Declaration will be ignored)")
<< OutputParserTester::STDERR
<< QString() << QString()
<< (Tasks() << CompileTask(Task::Error,
R"(Plugin Metadata file "QmlProfiler.json" does not exist. Declaration will be ignored)",
Utils::FilePath::fromUserInput("C:/Users/alportal/dev/qt-creator-qt6/src/plugins/qmlprofiler/qmlprofilerplugin.h"), 38, 1))
<< QString();
QTest::newRow("moc warning (Qt 6/Unix)")
<< QString::fromLatin1(R"(/Users/alportal/dev/qt-creator-qt6/src/plugins/qmlprofiler/qmlprofilerplugin.h:38:1: error: Plugin Metadata file "QmlProfiler.json" does not exist. Declaration will be ignored)")
<< OutputParserTester::STDERR
<< QString() << QString()
<< (Tasks() << CompileTask(Task::Error,
R"(Plugin Metadata file "QmlProfiler.json" does not exist. Declaration will be ignored)",
Utils::FilePath::fromUserInput("/Users/alportal/dev/qt-creator-qt6/src/plugins/qmlprofiler/qmlprofilerplugin.h"), 38, 1))
<< QString();
QtParser: Also handle notes from moc Change-Id: I4ecbeb91be0890d8ab56ed6fe247fb8494856e74 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-24 11:46:58 +02:00
QTest::newRow("moc note")
<< QString::fromLatin1("/home/qtwebkithelpviewer.h:0: Note: No relevant classes found. No output generated.")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Unknown,
QtParser: Also handle notes from moc Change-Id: I4ecbeb91be0890d8ab56ed6fe247fb8494856e74 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-24 11:46:58 +02:00
QLatin1String("No relevant classes found. No output generated."),
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
Utils::FilePath::fromUserInput(QLatin1String("/home/qtwebkithelpviewer.h")), -1))
QtParser: Also handle notes from moc Change-Id: I4ecbeb91be0890d8ab56ed6fe247fb8494856e74 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2014-07-24 11:46:58 +02:00
<< QString();
Add unit test for moc with ninja Based on QTCREATORBUG-7932 Change-Id: I30afa90f3fe7ca8b3b262b7d236d762de1031f51 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-09-26 17:41:50 +02:00
QTest::newRow("ninja with moc")
<< QString::fromLatin1("E:/sandbox/creator/loaden/src/libs/utils/iwelcomepage.h(54): Error: Undefined interface")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Error,
Add unit test for moc with ninja Based on QTCREATORBUG-7932 Change-Id: I30afa90f3fe7ca8b3b262b7d236d762de1031f51 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-09-26 17:41:50 +02:00
QLatin1String("Undefined interface"),
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
Utils::FilePath::fromUserInput(QLatin1String("E:/sandbox/creator/loaden/src/libs/utils/iwelcomepage.h")), 54))
Add unit test for moc with ninja Based on QTCREATORBUG-7932 Change-Id: I30afa90f3fe7ca8b3b262b7d236d762de1031f51 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2012-09-26 17:41:50 +02:00
<< QString();
ProjectExplorer: Remove some Qt-specific parser tests Warnings from uic and moc should be caught by the QtParser, not by the LdParser, as they currently are. We move the uic test case to QtSupport, and we remove the three identical moc test cases, as the exact same output is already checked in QtSupport. Task-number: QTCREATORBUG-25677 Change-Id: Iec0203c2be60a80bd6ef0a090a9828f59ae6b482 Reviewed-by: hjk <hjk@qt.io>
2021-05-06 16:29:42 +02:00
QTest::newRow("uic warning")
<< QString::fromLatin1("mainwindow.ui: Warning: The name 'pushButton' (QPushButton) is already in use, defaulting to 'pushButton1'.")
<< OutputParserTester::STDERR
<< QString() << QString()
<< (Tasks()
<< CompileTask(Task::Warning,
"The name 'pushButton' (QPushButton) is already in use, defaulting to 'pushButton1'.",
Utils::FilePath::fromUserInput("mainwindow.ui")))
<< QString();
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
QTest::newRow("translation")
<< QString::fromLatin1("Warning: dropping duplicate messages in '/some/place/qtcreator_fr.qm'")
<< OutputParserTester::STDERR
<< QString() << QString()
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
<< (Tasks() << CompileTask(Task::Warning,
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
QLatin1String("dropping duplicate messages"),
ProjectManager: Add convenience Task subclasses For Compile, BuildSystem and Deployment. Unclutters user code and reduces binary size. Change-Id: Ia18e917bb411754162e9f4ec6056d752a020bb50 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-01-15 08:56:11 +01:00
Utils::FilePath::fromUserInput(QLatin1String("/some/place/qtcreator_fr.qm")), -1))
Qt: Recognize issues with translations as build issues Change-Id: I6ef0750d78ab2c935a34a047ffd49bc72c746dc2 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
2013-12-11 17:50:17 +01:00
<< QString();
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
}
Move QtParser to QtSupport plugin This way we can make use of it in the cmake plugin Change-Id: Ie1887d49ea616ec62d91a73b4daa75d69cef61c9 Reviewed-on: http://codereview.qt.nokia.com/91 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
2011-05-24 16:15:15 +02:00
void QtSupportPlugin::testQtOutputParser()
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
{
OutputParserTester testbench;
Output parsers: Replace the chaining approach Use "flat" aggregation instead. This is another step towards the formatter/parser merger. Along the way, also fix some some subclasses (mostly in BareMetal) that erroneously forwarded handled output to other parsers. Task-number: QTCREATORBUG-22665 Change-Id: I12947349ca663d2e6bbfc99efd069d69e2b54969 Reviewed-by: hjk <hjk@qt.io>
2020-04-08 17:45:39 +02:00
testbench.addLineParser(new QtParser);
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
QFETCH(QString, input);
QFETCH(OutputParserTester::Channel, inputChannel);
ProjectExplorer: Introduce a alias for QList<Tasks> Change-Id: I91391ad22b420926b0f512cac23cfe009048b218 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-27 16:09:44 +02:00
QFETCH(Tasks, tasks);
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
QFETCH(QString, childStdOutLines);
QFETCH(QString, childStdErrLines);
QFETCH(QString, outputLines);
testbench.testParsing(input, inputChannel, tasks, childStdOutLines, childStdErrLines, outputLines);
}
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
} // namespace Internal
Add output parser for Qt-specific utilities * Handle moc warnings there * Add unit tests * Use new parser in Qt's makestep Task-number: QTCREATORBUG-1908
2010-08-03 17:24:20 +02:00
#endif
Merge output formatters and output parsers Now only one piece of code needs to be written to both linkify output in an output pane and create tasks for it in the issues pane. The calling sites are also simplified. For instance, until now, build steps had to feed their output parsers manually and then push the created tasks up the signal stack in parallel with the actual output, which the build manager relied upon for cross-linking the output pane content. Afterwards, the output would get forwarded to the formatter (and parsed for ANSI escape codes a second time). In contrast, a build step now just forwards the process output, and task parsing as well as output formatting is done centrally further up the stack. Concrete user-visible improvements so far: - File paths in compiler/linker messages are clickable links now. - QtTest applications now create clickable links also when run as part of a build step, not just in the app output pane. Task-number: QTCREATORBUG-22665 Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-04-16 13:53:05 +02:00
} // namespace QtSupport
Copy Permalink