feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity
Files
9c9ca280ea4e65d84d3640a4f894152f25e56d24
qt-creator/tests/unit/unittest/symbolscollector-test.cpp

692 lines
24 KiB
C++
Raw Normal View History

Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
/****************************************************************************
**
** Copyright (C) 2017 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "googletest.h"
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
#include "filesystem-utilities.h"
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
#include <symbolscollector.h>
Clang: Rename FileInformation in FileStatus It's more near to the Unix convention and it has a plural too. Change-Id: I53f85911d8fcbaadba9947c70e9a375dc6995ed5 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 18:29:45 +01:00
#include <filestatus.h>
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
#include <filepathcaching.h>
UnitTests: Use memory database Tests get more reliable if the database is not shared between different tests and the testing is speed up by not accessing the file system. Change-Id: Ieb3c5495df4f0fae2293111949792774b01bf913 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-18 13:34:05 +02:00
#include <refactoringdatabaseinitializer.h>
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
Clang: Get file informations from symbols collector We need the same information like file size and the last modification time to check if a file has changed. This information will be saved to the database. Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-29 15:47:53 +01:00
#include <QDateTime>
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
#include <QDir>
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
#ifdef _WIN32
#include <windows.h>
#else
#include <utime.h>
#endif
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
using testing::PrintToString;
using testing::AllOf;
using testing::Contains;
using testing::Not;
using testing::Field;
using testing::Key;
using testing::Pair;
using testing::Value;
using testing::_;
Clang: Collect source files Change-Id: If0183cafd00ed7e42bacbdb72a1d65624dc03cee Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-10-26 13:23:27 +02:00
using ClangBackEnd::FilePath;
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
using ClangBackEnd::FilePathCaching;
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
using ClangBackEnd::FilePathId;
using ClangBackEnd::FileStatus;
Clang: Collect source dependencies It is quite easy because we track the include directives in the preprocessor callbacks. Change-Id: I2d7bd67b31f50c0d8d4a46c57e83dffa0c558dc7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-31 13:53:57 +01:00
using ClangBackEnd::SourceDependency;
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
using ClangBackEnd::SourceLocationEntry;
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
using ClangBackEnd::SourceLocationKind;
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
using ClangBackEnd::SymbolEntry;
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
using ClangBackEnd::SymbolIndex;
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
using ClangBackEnd::SymbolKind;
using ClangBackEnd::SymbolTag;
Clang: Rename defineName in macroName Change-Id: Iaf8da991032e5ed4726384c051290a77887351fa Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-25 15:20:47 +01:00
using ClangBackEnd::UsedMacro;
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
using ClangBackEnd::V2::FileContainers;
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
using Sqlite::Database;
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
namespace {
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
MATCHER_P5(IsSourceLocationEntry, symbolId, filePathId, line, column, kind,
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
std::string(negation ? "isn't" : "is")
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
+ PrintToString(SourceLocationEntry{symbolId, filePathId, {line, column}, kind})
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
)
{
const SourceLocationEntry &entry = arg;
return entry.filePathId == filePathId
&& entry.lineColumn.line == line
&& entry.lineColumn.column == column
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
&& entry.kind == kind
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
&& entry.symbolId == symbolId;
}
MATCHER_P2(HasLineColumn, line, column,
std::string(negation ? "isn't" : "is")
+ PrintToString(Utils::LineColumn{line, column})
)
{
const SourceLocationEntry &entry = arg;
return entry.lineColumn.line == line
&& entry.lineColumn.column == column;
}
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
MATCHER_P(HasSymbolName, symbolName,
std::string(negation ? "hasn't" : "has")
+ " symbol name: "
+ symbolName
)
{
const SymbolEntry &entry = arg.second;
return entry.symbolName == symbolName;
}
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
MATCHER_P(HasSymbolKind, symbolKind,
std::string(negation ? "hasn't" : "has")
+ " and symbol kind: "
+ PrintToString(symbolKind)
)
{
const SymbolEntry &entry = arg.second;
return entry.symbolKind == symbolKind;
}
MATCHER_P(HasSymbolTag, symbolTag,
std::string(negation ? "hasn't" : "has")
+ " and symbol tag: "
+ PrintToString(symbolTag)
)
{
const SymbolEntry &entry = arg.second;
return entry.symbolTags.contains(symbolTag);
}
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
class SymbolsCollector : public testing::Test
{
protected:
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
SymbolsCollector() { setFilePathCache(&filePathCache); }
~SymbolsCollector() { setFilePathCache({}); }
Clang: Get file informations from symbols collector We need the same information like file size and the last modification time to check if a file has changed. This information will be saved to the database. Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-29 15:47:53 +01:00
FilePathId filePathId(Utils::SmallStringView filePath) const
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
{
Clang: Get file informations from symbols collector We need the same information like file size and the last modification time to check if a file has changed. This information will be saved to the database. Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-29 15:47:53 +01:00
return filePathCache.filePathId(ClangBackEnd::FilePathView{filePath});
}
static off_t fileSize(Utils::SmallStringView filePath)
{
return QFileInfo(QString(filePath)).size();
}
static std::time_t lastModified(Utils::SmallStringView filePath)
{
CMake Build: Use same Qt compiler defines for tests Source code needed adjustments though. Change-Id: I78b4610a6bb895a385c7c30a6c92c97a276b89dd Reviewed-by: hjk <hjk@qt.io>
2019-09-10 13:13:30 +02:00
return QFileInfo(QString(filePath)).lastModified().toSecsSinceEpoch();
Clang: Get file informations from symbols collector We need the same information like file size and the last modification time to check if a file has changed. This information will be saved to the database. Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-29 15:47:53 +01:00
}
Clang: Rename FileInformation in FileStatus It's more near to the Unix convention and it has a plural too. Change-Id: I53f85911d8fcbaadba9947c70e9a375dc6995ed5 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-02-01 18:29:45 +01:00
ClangBackEnd::FileStatus fileStatus(Utils::SmallStringView filePath) const
Clang: Get file informations from symbols collector We need the same information like file size and the last modification time to check if a file has changed. This information will be saved to the database. Change-Id: Icf8eb9b6553945a563887e11aff9539c9b300b66 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-29 15:47:53 +01:00
{
Clang: Improve dependency building We want to use the cached values in the database because it is faster than to parse the the files again. Task-number: QTCREATORBUG-22035 Change-Id: I7ada7073887b1d89a06332fdb617701cb69ccd68 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-25 19:07:19 +01:00
return {filePathId(filePath), fileSize(filePath), lastModified(filePath)};
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
SymbolIndex symbolId(const Utils::SmallString &symbolName)
{
for (const auto &entry : collector.symbols()) {
if (entry.second.symbolName == symbolName)
return entry.first;
}
return 0;
}
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
void touchFile(const char *filePath)
{
#ifdef _WIN32
QFile::resize(QString::fromUtf8(filePath), QFileInfo(QString::fromUtf8(filePath)).size());
#else
utime(filePath, nullptr);
#endif
}
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
protected:
UnitTests: Use memory database Tests get more reliable if the database is not shared between different tests and the testing is speed up by not accessing the file system. Change-Id: Ieb3c5495df4f0fae2293111949792774b01bf913 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-10-18 13:34:05 +02:00
Sqlite::Database database{":memory:", Sqlite::JournalMode::Memory};
ClangBackEnd::RefactoringDatabaseInitializer<Sqlite::Database> initializer{database};
Clang: Add file cache The database is using file path integer ids to handle file paths because otherwise we would save many redundant data. This patch is improving it further with the introduction of a database based file path cache. The entries are now divided in a directory path and file name. This is quite handy for directory based file watching. Change-Id: I03f2e388e43f3d521d6bf8e39dfb95eb2309dc73 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-09-21 11:43:59 +02:00
FilePathCaching filePathCache{database};
Clang: Optimize file path cache We now fetch all directories and sources from the database at file path cache creation. Change-Id: I92510b49a234128f4c82b840611db82ead3f1a54 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-06 13:12:03 +02:00
ClangBackEnd::SymbolsCollector collector{filePathCache};
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
};
TEST_F(SymbolsCollector, CollectSymbolName)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Clang: Don't parse system headers Change-Id: I6474fbe4f43daaac930ad6ba49fd9cb3145a3bbd Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-14 11:46:16 +02:00
Contains(HasSymbolName("function")));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
CppRefactoring: Disable failing tests Has to fixed later or removed completely. Change-Id: I3a62b4ecde60f6877164e994e664f7b015b9d3fc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 17:13:07 +01:00
TEST_F(SymbolsCollector, DISABLED_SymbolMatchesLocation)
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Contains(
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
AllOf(Field(&SourceLocationEntry::symbolId, symbolId("function")),
HasLineColumn(1, 6))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
CppRefactoring: Disable failing tests Has to fixed later or removed completely. Change-Id: I3a62b4ecde60f6877164e994e664f7b015b9d3fc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 17:13:07 +01:00
TEST_F(SymbolsCollector, DISABLED_OtherSymboldMatchesLocation)
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Contains(
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
AllOf(Field(&SourceLocationEntry::symbolId, symbolId("function")),
HasLineColumn(2, 6))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
TEST_F(SymbolsCollector, CollectFilePath)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
Contains(AllOf(Field(&SourceLocationEntry::filePathId,
filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp")),
Field(&SourceLocationEntry::kind, SourceLocationKind::Declaration))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
TEST_F(SymbolsCollector, CollectLineColumn)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Contains(
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
AllOf(HasLineColumn(1, 6),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Field(&SourceLocationEntry::kind, SourceLocationKind::Declaration))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
TEST_F(SymbolsCollector, CollectReference)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Contains(
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
AllOf(HasLineColumn(14, 5),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Field(&SourceLocationEntry::kind, SourceLocationKind::DeclarationReference))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
CppRefactoring: Disable failing tests Has to fixed later or removed completely. Change-Id: I3a62b4ecde60f6877164e994e664f7b015b9d3fc Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-10-27 17:13:07 +01:00
TEST_F(SymbolsCollector, DISABLED_ReferencedSymboldMatchesLocation)
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Contains(
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
AllOf(Field(&SourceLocationEntry::symbolId, symbolId("function")),
HasLineColumn(14, 5))));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
Clang: Add Symbol Indexing It is a first step and now a database is generated if you start QtCreator. Some code is now shared with the PchManager which can be improved in the future. Change-Id: Ic267fe7960f6c455d91832859a673ce98f269aa2 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-17 12:44:52 +02:00
TEST_F(SymbolsCollector, DISABLED_ON_WINDOWS(CollectInUnsavedFile))
{
Clang: Reduce database accesses If we prefetch data from the database to the caches we reduce the database transaction calls which are quite expensive. Change-Id: I617a0d886807402e0a94291a913a77f989970b55 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-20 14:45:01 +02:00
FileContainers unsaved{{{TESTDATA_DIR, "symbolscollector/generated_file.h"},
filePathId({TESTDATA_DIR, "symbolscollector/generated_file.h"}),
"void function();",
{}}};
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unsaved.cpp"), {"cc"});
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setUnsavedFiles(std::move(unsaved));
Clang: Add Symbol Indexing It is a first step and now a database is generated if you start QtCreator. Some code is now shared with the PchManager which can be improved in the future. Change-Id: Ic267fe7960f6c455d91832859a673ce98f269aa2 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-17 12:44:52 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
Contains(HasSymbolName("function")));
Clang: Add Symbol Indexing It is a first step and now a database is generated if you start QtCreator. Some code is now shared with the PchManager which can be improved in the future. Change-Id: Ic267fe7960f6c455d91832859a673ce98f269aa2 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-17 12:44:52 +02:00
}
Clang: Clear SymbolCollector before updating new project parts Change-Id: I82e9bb4f66a7597bb911fbc97d6022ff3fdb0b35 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-12-13 12:04:19 +01:00
TEST_F(SymbolsCollector, ClearSymbols)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
Clang: Clear SymbolCollector before updating new project parts Change-Id: I82e9bb4f66a7597bb911fbc97d6022ff3fdb0b35 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-12-13 12:04:19 +01:00
collector.collectSymbols();
collector.clear();
ASSERT_THAT(collector.symbols(), IsEmpty());
}
TEST_F(SymbolsCollector, ClearSourceLocations)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
Clang: Clear SymbolCollector before updating new project parts Change-Id: I82e9bb4f66a7597bb911fbc97d6022ff3fdb0b35 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-12-13 12:04:19 +01:00
collector.collectSymbols();
collector.clear();
ASSERT_THAT(collector.sourceLocations(), IsEmpty());
}
TEST_F(SymbolsCollector, DontCollectSymbolsAfterFilesAreCleared)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
Clang: Clear SymbolCollector before updating new project parts Change-Id: I82e9bb4f66a7597bb911fbc97d6022ff3fdb0b35 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2017-12-13 12:04:19 +01:00
collector.clear();
collector.collectSymbols();
ASSERT_THAT(collector.symbols(), IsEmpty());
}
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
TEST_F(SymbolsCollector, CollectMacroDefinitionSourceLocation)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("IF_NOT_DEFINE"), fileId, 4, 9, SourceLocationKind::MacroDefinition)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroUsageInIfNotDefSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("IF_NOT_DEFINE"), fileId, 6, 9, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectSecondMacroUsageInIfNotDefSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("IF_NOT_DEFINE"), fileId, 9, 9, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroUsageCompilerArgumentSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("COMPILER_ARGUMENT"), fileId, 12, 9, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroUsageInIfDefSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("IF_DEFINE"), fileId, 17, 8, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroUsageInDefinedSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("DEFINED"), fileId, 22, 13, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
TEST_F(SymbolsCollector, CollectMacroUsageExpansionSourceLocation)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("MACRO_EXPANSION"), fileId, 27, 10, SourceLocationKind::MacroUsage)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
TEST_F(SymbolsCollector, CollectMacroUsageUndefSourceLocation)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("UN_DEFINE"), fileId, 34, 8, SourceLocationKind::MacroUndefinition)));
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroUsageBuiltInSourceLocation)
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: On the road to update and preprocessor support This patch has grown in a quite big change set and it is really hard to divide it in different parts. V2::ProjectPartContainer is now using FileIds instead of file paths. This cleans code up because it is a big step in the direction that internally only file ids are used. But it is depending on the file cache, so the file cache has to be provided as an argument. There is now an interface for transactions too which are ease the testing of them and enables the support of preprocessor. It adds macros as symbols and is saving used macros. The used macro support is enabling update improvements because only if a changed macro is used it needs to be recompiled. This is still in flux and can be changed in later patches. Change-Id: I492a2c9af1201d40fdd9f46a0045f7878bbbaa3d Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-22 14:21:01 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(),
Clang: Locator filter for the symbol database There are no symbol queries for the locator filters. The signature generation is still not implemented but for simple cases it should work. Change-Id: Ic6b04fbe1e7e057892f194ac139615c47d6ec33f Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-09 13:30:30 +02:00
Contains(IsSourceLocationEntry(symbolId("__clang__"), fileId, 29, 9, SourceLocationKind::MacroUsage)));
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
TEST_F(SymbolsCollector, CollectMacroDefinitionSymbols)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc"});
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
Contains(AllOf(HasSymbolName("IF_NOT_DEFINE"), HasSymbolKind(SymbolKind::Macro))));
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroBuiltInSymbols)
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc"});
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
Contains(AllOf(HasSymbolName("__clang__"), HasSymbolKind(SymbolKind::Macro))));
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
}
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
TEST_F(SymbolsCollector, DISABLED_CollectMacroCompilerArgumentSymbols)
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
Clang: Improve generated files handling Generated files are referenced by the system collector directly to set the unsaved files. Change-Id: I24be3ee544b7824b8b0e518eafd409f32bd002ab Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-09-03 14:38:01 +02:00
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
Contains(AllOf(HasSymbolName("COMPILER_ARGUMENT"), HasSymbolKind(SymbolKind::Macro))));
Clang: Improve Macro collection Now undefined macros are added to used macros but we filter out header guards and dynamic libraries export. The export is quite simple but without we would think that exports change the AST. Change-Id: Ic16f60a6675e397dfd769c53caf77056708d8459 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-01-23 14:10:17 +01:00
}
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
TEST_F(SymbolsCollector, IsClassSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("Class"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Record),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
HasSymbolTag(SymbolTag::Class))));
}
TEST_F(SymbolsCollector, IsStructSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("Struct"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Record),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
HasSymbolTag(SymbolTag::Struct))));
}
TEST_F(SymbolsCollector, IsEnumerationSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
AllOf(
Contains(
AllOf(
HasSymbolName("Enumeration"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Enumeration))),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
Contains(
AllOf(
HasSymbolName("ScopedEnumeration"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Enumeration)))));
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
}
TEST_F(SymbolsCollector, IsUnionSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("Union"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Record),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
HasSymbolTag(SymbolTag::Union))));
}
TEST_F(SymbolsCollector, DISABLED_ON_NON_WINDOWS(IsMsvcInterfaceSymbol))
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("MsvcInterface"),
Clang: Distinguish between Enum and Records Creator is distinguishing enumerations and records, so we should do too. Change-Id: I114cfd207464abd9afd96c26c7504cf8a3a1cb8c Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-04-04 16:58:47 +02:00
HasSymbolKind(SymbolKind::Record),
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
HasSymbolTag(SymbolTag::MsvcInterface))));
}
TEST_F(SymbolsCollector, IsFunctionSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("Function"),
HasSymbolKind(SymbolKind::Function))));
}
TEST_F(SymbolsCollector, IsVariableSymbol)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
Clang: Process SymbolKind and SymbolTags with the indexer We add the infrastructure to compute the SymbolKind and SymbolTags in the indexer. Later we have to add more for templates, virtual functions etc.. Change-Id: I9203c5cfbfffed3065337292010de5fce5736453 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-22 17:46:43 +01:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
Contains(
AllOf(
HasSymbolName("Variable"),
HasSymbolKind(SymbolKind::Variable))));
}
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
TEST_F(SymbolsCollector, IndexUnmodifiedHeaderFilesAtFirstRun)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
AllOf(
Contains(HasSymbolName("MemberReference")),
Contains(HasSymbolName("HeaderFunction")),
Contains(HasSymbolName("HeaderFunctionReference")),
Contains(HasSymbolName("Class")),
Contains(HasSymbolName("Member")),
Contains(HasSymbolName("HEADER_DEFINE")),
Contains(HasSymbolName("FunctionLocalVariable"))));
}
TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtSecondRun)
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
collector.collectSymbols();
collector.clear();
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified2.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
AllOf(Contains(HasSymbolName("HeaderFunctionReferenceInMainFile")),
Not(Contains(HasSymbolName("MemberReference"))),
Not(Contains(HasSymbolName("HeaderFunctionReference"))),
Not(Contains(HasSymbolName("HeaderFunction"))),
Not(Contains(HasSymbolName("Class"))),
Not(Contains(HasSymbolName("Member"))),
Not(Contains(HasSymbolName("HEADER_DEFINE")))));
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
}
TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtTouchHeader)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified3.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
collector.collectSymbols();
collector.clear();
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
touchFile(TESTDATA_DIR "/symbolscollector/include/unmodified_header2.h");
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified3.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
ClangRefactoring: Improve indexing Fix some bugs in the indexing and use the new macro indexer from clang. Change-Id: I2ba1b28097a8751aea942071851a60d164c6f371 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-23 18:32:47 +02:00
AllOf(Contains(HasSymbolName("TouchHeaderFunction")),
Contains(HasSymbolName("HeaderFunctionReferenceInMainFile")),
Not(Contains(HasSymbolName("MemberReference"))),
Not(Contains(HasSymbolName("HeaderFunctionReference"))),
Not(Contains(HasSymbolName("HeaderFunction"))),
Not(Contains(HasSymbolName("Class"))),
Not(Contains(HasSymbolName("Member"))),
Not(Contains(HasSymbolName("HEADER_DEFINE")))));
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
}
TEST_F(SymbolsCollector, DontIndexSystemIncudes)
{
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-isystem", {TESTDATA_DIR, "/symbolscollector/include"}});
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
collector.collectSymbols();
ASSERT_THAT(collector.symbols(),
AllOf(
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
Contains(HasSymbolName("MainFileFunction")),
Contains(HasSymbolName("HeaderFunctionReferenceInMainFile")),
Not(Contains(HasSymbolName("MemberReference"))),
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
Not(Contains(HasSymbolName("HeaderFunction"))),
Not(Contains(HasSymbolName("Class"))),
Not(Contains(HasSymbolName("Member"))),
ClangRefactoring: Improve symbol parsing Declarations are only indexed if their file has been changed and references has to be indexed if the file or any included file has been changed. Change-Id: I07c6de1379bce2462c1e0fad34d4378a3da4397b Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-16 18:17:42 +02:00
Not(Contains(HasSymbolName("HEADER_DEFINE"))),
Not(Contains(HasSymbolName("FunctionLocalVariable")))));
Clang: Don't index already indexed symbols We don't index system headers any more and introduce a first step to decrease double indexing. For that we introduces the SourcesManager which so far tells you only if a file was already indexed for a certain time stamp. Change-Id: Icde54465693ca84a622764c595635cac365c0111 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-08-13 16:56:41 +02:00
}
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
TEST_F(SymbolsCollector, CollectReturnsFalseIfThereIsError)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/error.cpp"), {"cc"});
bool success = collector.collectSymbols();
ASSERT_FALSE(success);
}
TEST_F(SymbolsCollector, CollectReturnsFalseIfThereIsNoError)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
bool success = collector.collectSymbols();
ASSERT_TRUE(success);
Clang: Add symbols collector Change-Id: I64c25eef8eaa6cc6c3ff09d41866972b6c7248d0 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-07-24 14:55:51 +02:00
}
ClangRefactoring: Clear input files after collecting symbols Change-Id: Ic4fbaac7ad3b3f80223d6cbb84a34dffa741fc4f Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-05-06 15:37:55 +02:00
TEST_F(SymbolsCollector, ClearInputFilesAfterCollectingSymbols)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main2.cpp"), {"cc"});
collector.collectSymbols();
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols();
ASSERT_TRUE(collector.isClean());
}
ClangRefactoring: Improve follow symbol and usage Change-Id: Idb42010443e4560489ef067e54d05b4e567598e9 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-22 16:10:38 +02:00
TEST_F(SymbolsCollector, ClassDeclarations)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"), {"cc"});
collector.collectSymbols();
ASSERT_THAT(
collector.sourceLocations(),
AllOf(Contains(IsSourceLocationEntry(symbolId("Class"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
1,
7,
SourceLocationKind::Definition)),
Contains(IsSourceLocationEntry(symbolId("bar"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
8,
8,
SourceLocationKind::Definition)),
Contains(IsSourceLocationEntry(symbolId("foo"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
11,
13,
SourceLocationKind::Definition)),
Contains(IsSourceLocationEntry(symbolId("foo"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
6,
8,
SourceLocationKind::Declaration)),
Contains(IsSourceLocationEntry(symbolId("Class"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
11,
6,
SourceLocationKind::DeclarationReference)),
Contains(IsSourceLocationEntry(symbolId("bar"),
filePathId(TESTDATA_DIR "/symbolscollector/class.cpp"),
13,
5,
SourceLocationKind::DeclarationReference))));
}
UnitTests: Move symbolscollector data to sub directory Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-02-07 12:20:39 +01:00
} // namespace
Copy Permalink