Files
qt-creator/src/libs/ssh/sshconnection.cpp

407 lines
13 KiB
C++
Raw Normal View History

/****************************************************************************
2010-07-12 09:33:22 +02:00
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
2010-07-12 09:33:22 +02:00
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
2010-12-17 16:01:08 +01:00
**
****************************************************************************/
#include "sshconnection.h"
#include "sftpsession.h"
#include "sftptransfer.h"
#include "sshlogging_p.h"
#include "sshprocess.h"
#include "sshremoteprocess.h"
#include "sshsettings.h"
#include <utils/fileutils.h>
#include <utils/hostosinfo.h>
#include <utils/qtcassert.h>
#include <utils/qtcprocess.h>
#include <QByteArrayList>
#include <QTemporaryDir>
#include <QTimer>
#include <memory>
/*!
\class QSsh::SshConnection
\brief The SshConnection class provides an SSH connection via an OpenSSH client
running in master mode.
It operates asynchronously (non-blocking) and is not thread-safe.
If connection sharing is turned off, the class operates as a simple factory
for processes etc and "connecting" always succeeds. The actual connection
is then established later, e.g. when starting the remote process.
*/
namespace QSsh {
using namespace Internal;
using namespace Utils;
SshConnectionParameters::SshConnectionParameters()
{
url.setPort(0);
}
QStringList SshConnectionParameters::connectionOptions(const FilePath &binary) const
{
QString hostKeyCheckingString;
switch (hostKeyCheckingMode) {
case SshHostKeyCheckingNone:
case SshHostKeyCheckingAllowNoMatch:
// There is "accept-new" as well, but only since 7.6.
hostKeyCheckingString = "no";
break;
case SshHostKeyCheckingStrict:
hostKeyCheckingString = "yes";
break;
}
QStringList args{"-o", "StrictHostKeyChecking=" + hostKeyCheckingString,
"-o", "Port=" + QString::number(port())};
if (!userName().isEmpty())
args.append({"-o", "User=" + userName()});
const bool keyOnly = authenticationType ==
SshConnectionParameters::AuthenticationTypeSpecificKey;
if (keyOnly) {
args << "-o" << "IdentitiesOnly=yes";
args << "-i" << privateKeyFile.path();
}
if (keyOnly || SshSettings::askpassFilePath().isEmpty())
args << "-o" << "BatchMode=yes";
bool useTimeout = timeout != 0;
if (useTimeout && HostOsInfo::isWindowsHost()
&& binary.toString().toLower().contains("/system32/")) {
useTimeout = false;
}
if (useTimeout)
args << "-o" << ("ConnectTimeout=" + QString::number(timeout));
return args;
}
static inline bool equals(const SshConnectionParameters &p1, const SshConnectionParameters &p2)
{
return p1.url == p2.url
2011-02-28 17:01:53 +01:00
&& p1.authenticationType == p2.authenticationType
&& p1.privateKeyFile == p2.privateKeyFile
&& p1.hostKeyCheckingMode == p2.hostKeyCheckingMode
&& p1.x11DisplayName == p2.x11DisplayName
&& p1.timeout == p2.timeout;
}
bool operator==(const SshConnectionParameters &p1, const SshConnectionParameters &p2)
{
return equals(p1, p2);
}
bool operator!=(const SshConnectionParameters &p1, const SshConnectionParameters &p2)
{
return !equals(p1, p2);
2010-07-12 09:33:22 +02:00
}
struct SshConnection::SshConnectionPrivate
{
SshConnectionPrivate(const SshConnectionParameters &sshParameters)
: connParams(sshParameters) {}
QString fullProcessError()
{
QString error;
if (masterProcess.exitStatus() != QProcess::NormalExit)
error = masterProcess.errorString();
const QByteArray stdErr = masterProcess.readAllStandardError();
if (!stdErr.isEmpty()) {
if (!error.isEmpty())
error.append('\n');
error.append(QString::fromLocal8Bit(stdErr));
}
return error;
}
QString socketFilePath() const
{
QTC_ASSERT(masterSocketDir, return QString());
return masterSocketDir->path() + "/cs";
}
QStringList connectionOptions(const FilePath &binary) const
{
QStringList options = connParams.connectionOptions(binary);
if (sharingEnabled)
options << "-o" << ("ControlPath=" + socketFilePath());
return options;
}
QStringList connectionArgs(const FilePath &binary) const
{
return connectionOptions(binary) << connParams.host();
}
const SshConnectionParameters connParams;
SshConnectionInfo connInfo;
SshProcess masterProcess;
QString errorString;
std::unique_ptr<QTemporaryDir> masterSocketDir;
State state = Unconnected;
const bool sharingEnabled = SshSettings::connectionSharingEnabled();
};
2010-05-05 10:06:31 +02:00
SshConnection::SshConnection(const SshConnectionParameters &serverInfo, QObject *parent)
: QObject(parent), d(new SshConnectionPrivate(serverInfo))
2010-07-12 09:33:22 +02:00
{
qRegisterMetaType<QSsh::SftpFileInfo>("QSsh::SftpFileInfo");
qRegisterMetaType<QList <QSsh::SftpFileInfo> >("QList<QSsh::SftpFileInfo>");
Get rid of Utils::FileSystemWatcher from SshConnection When we are starting master process for ssh (-M option specified) we don't know whether everything went fine, since the process just starts and doesn't print anything to the output in case all went fine. It may also happen that when there are issues the master process finishes soon after it was started. When everything went fine the master process should create a socket (specified by ControlPath option). But when we receive a started() signal from the process, the socket isn't yet ready. So, in order to detect that connection was established properly, the old implementation created a FileSystemWatcher on the expected socket file to appear. There are 2 issues with the approach above: 1. There might be a race condition inside the started() handler of the master process. After checking that the expected socket isn't created yet and before setting up the file system watcher, the socket file could have been created in meantime what wouldn't be noticed. 2. The use of Utils::FileSystemWatcher excludes the usage in non-main threads. Thus in general: usage of SshConnection outside of main thread is dangerous. This patch implements it in a different way. Instead of installing a file system watcher we make use of local command of ssh master process. We enable it by "PermitLocalCommand=yes" and specify a local command by "LocalCommand=echo". This means that local command will be executed after successfully connecting to the server. Our command is very simple - just empty echo, which means that we should expect the "\n" on master process output after successful run. So, instead of connecting to started() signal we are connected to readyReadStandardOutput() and detect successful connection after receiving newline char. This eliminates both issues with the old approach and makes a step towards thread safe shared ssh connections. Change-Id: I2e20c82aeff09b297e3cad5644d4d2c956db82d0 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-12-14 13:28:55 +01:00
connect(&d->masterProcess, &QtcProcess::readyReadStandardOutput, [this] {
const QByteArray reply = d->masterProcess.readAllStandardOutput();
if (reply == "\n")
emitConnected();
});
connect(&d->masterProcess, &QtcProcess::errorOccurred, [this] (QProcess::ProcessError error) {
switch (error) {
case QProcess::FailedToStart:
emitError(tr("Cannot establish SSH connection: Control process failed to start: %1")
.arg(d->fullProcessError()));
break;
case QProcess::Crashed: // Handled by finished() handler.
case QProcess::Timedout:
case QProcess::ReadError:
case QProcess::WriteError:
case QProcess::UnknownError:
break; // Cannot happen.
}
});
connect(&d->masterProcess, &QtcProcess::finished, [this] {
if (d->state == Disconnecting) {
emitDisconnected();
return;
}
const QString procError = d->fullProcessError();
QString errorMsg = tr("SSH connection failure.");
if (!procError.isEmpty())
errorMsg.append('\n').append(procError);
emitError(errorMsg);
});
if (!d->connParams.x11DisplayName.isEmpty()) {
Environment env = d->masterProcess.environment();
env.set("DISPLAY", d->connParams.x11DisplayName);
d->masterProcess.setEnvironment(env);
2010-07-12 09:33:22 +02:00
}
}
void SshConnection::connectToHost()
2010-05-10 11:01:56 +02:00
{
d->state = Connecting;
QTimer::singleShot(0, this, &SshConnection::doConnectToHost);
2010-05-10 11:01:56 +02:00
}
void SshConnection::disconnectFromHost()
2010-07-12 09:33:22 +02:00
{
switch (d->state) {
case Connecting:
case Connected:
if (!d->sharingEnabled) {
QTimer::singleShot(0, this, &SshConnection::emitDisconnected);
return;
}
d->state = Disconnecting;
if (HostOsInfo::isWindowsHost())
d->masterProcess.kill();
else
d->masterProcess.terminate();
break;
case Unconnected:
case Disconnecting:
break;
2010-07-12 09:33:22 +02:00
}
}
SshConnection::State SshConnection::state() const
{
return d->state;
}
QString SshConnection::errorString() const
{
return d->errorString;
2010-07-12 09:33:22 +02:00
}
SshConnectionParameters SshConnection::connectionParameters() const
2010-07-12 09:33:22 +02:00
{
return d->connParams;
2010-07-12 09:33:22 +02:00
}
SshConnectionInfo SshConnection::connectionInfo() const
{
QTC_ASSERT(state() == Connected, return SshConnectionInfo());
if (d->connInfo.isValid())
return d->connInfo;
QtcProcess p;
const FilePath sshFilePath = SshSettings::sshFilePath();
p.setCommand({sshFilePath, d->connectionArgs(sshFilePath) << "echo" << "-n" << "$SSH_CLIENT"});
p.start();
if (!p.waitForStarted() || !p.waitForFinished()) {
qCWarning(Internal::sshLog) << "failed to retrieve connection info:" << p.errorString();
return SshConnectionInfo();
}
const QByteArrayList data = p.readAllStandardOutput().split(' ');
if (data.size() != 3) {
qCWarning(Internal::sshLog) << "failed to retrieve connection info: unexpected output";
return SshConnectionInfo();
}
d->connInfo.localPort = data.at(1).toInt();
if (d->connInfo.localPort == 0) {
qCWarning(Internal::sshLog) << "failed to retrieve connection info: unexpected output";
return SshConnectionInfo();
}
if (!d->connInfo.localAddress.setAddress(QString::fromLatin1(data.first()))) {
qCWarning(Internal::sshLog) << "failed to retrieve connection info: unexpected output";
return SshConnectionInfo();
}
d->connInfo.peerPort = d->connParams.port();
d->connInfo.peerAddress.setAddress(d->connParams.host());
return d->connInfo;
}
QStringList SshConnection::connectionOptions(const FilePath &binary) const
{
return d->connectionOptions(binary);
}
bool SshConnection::sharingEnabled() const
{
return d->sharingEnabled;
2010-07-12 09:33:22 +02:00
}
SshConnection::~SshConnection()
{
disconnect();
disconnectFromHost();
delete d;
}
SshRemoteProcessPtr SshConnection::createRemoteProcess(const QString &command, ProcessMode processMode)
{
QTC_ASSERT(state() == Connected, return SshRemoteProcessPtr());
return SshRemoteProcessPtr(new SshRemoteProcess(command,
d->connectionArgs(SshSettings::sshFilePath()),
processMode));
}
SshRemoteProcessPtr SshConnection::createRemoteShell(ProcessMode processMode)
{
return createRemoteProcess({}, processMode);
}
SftpTransferPtr SshConnection::createUpload(const FilesToTransfer &files,
FileTransferErrorHandling errorHandlingMode)
{
return setupTransfer(files, Internal::FileTransferType::Upload, errorHandlingMode);
}
SftpTransferPtr SshConnection::createDownload(const FilesToTransfer &files,
FileTransferErrorHandling errorHandlingMode)
{
return setupTransfer(files, Internal::FileTransferType::Download, errorHandlingMode);
}
SftpSessionPtr SshConnection::createSftpSession()
{
QTC_ASSERT(state() == Connected, return SftpSessionPtr());
return SftpSessionPtr(new SftpSession(d->connectionArgs(SshSettings::sftpFilePath())));
}
void SshConnection::doConnectToHost()
{
if (d->state != Connecting)
return;
const FilePath sshBinary = SshSettings::sshFilePath();
if (!sshBinary.exists()) {
emitError(tr("Cannot establish SSH connection: ssh binary \"%1\" does not exist.")
.arg(sshBinary.toUserOutput()));
return;
}
if (!d->sharingEnabled) {
emitConnected();
return;
}
d->masterSocketDir.reset(new QTemporaryDir);
if (!d->masterSocketDir->isValid()) {
emitError(tr("Cannot establish SSH connection: Failed to create temporary "
"directory for control socket: %1")
.arg(d->masterSocketDir->errorString()));
2010-07-12 09:33:22 +02:00
return;
}
Get rid of Utils::FileSystemWatcher from SshConnection When we are starting master process for ssh (-M option specified) we don't know whether everything went fine, since the process just starts and doesn't print anything to the output in case all went fine. It may also happen that when there are issues the master process finishes soon after it was started. When everything went fine the master process should create a socket (specified by ControlPath option). But when we receive a started() signal from the process, the socket isn't yet ready. So, in order to detect that connection was established properly, the old implementation created a FileSystemWatcher on the expected socket file to appear. There are 2 issues with the approach above: 1. There might be a race condition inside the started() handler of the master process. After checking that the expected socket isn't created yet and before setting up the file system watcher, the socket file could have been created in meantime what wouldn't be noticed. 2. The use of Utils::FileSystemWatcher excludes the usage in non-main threads. Thus in general: usage of SshConnection outside of main thread is dangerous. This patch implements it in a different way. Instead of installing a file system watcher we make use of local command of ssh master process. We enable it by "PermitLocalCommand=yes" and specify a local command by "LocalCommand=echo". This means that local command will be executed after successfully connecting to the server. Our command is very simple - just empty echo, which means that we should expect the "\n" on master process output after successful run. So, instead of connecting to started() signal we are connected to readyReadStandardOutput() and detect successful connection after receiving newline char. This eliminates both issues with the old approach and makes a step towards thread safe shared ssh connections. Change-Id: I2e20c82aeff09b297e3cad5644d4d2c956db82d0 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-12-14 13:28:55 +01:00
QStringList args = QStringList{"-M", "-N", "-o", "ControlPersist=no",
"-o", "PermitLocalCommand=yes", // Enable local command
"-o", "LocalCommand=echo"} // Local command is executed after successfully
// connecting to the server. "echo" will print "\n"
// on the process output if everything went fine.
<< d->connectionArgs(sshBinary);
if (!d->connParams.x11DisplayName.isEmpty())
args.prepend("-X");
qCDebug(sshLog) << "establishing connection:" << sshBinary.toUserOutput() << args;
d->masterProcess.setCommand(CommandLine(sshBinary, args));
d->masterProcess.start();
}
void SshConnection::emitError(const QString &reason)
{
const State oldState = d->state;
d->state = Unconnected;
d->errorString = reason;
emit errorOccurred();
if (oldState == Connected)
emitDisconnected();
}
void SshConnection::emitConnected()
{
d->state = Connected;
emit connected();
}
void SshConnection::emitDisconnected()
{
d->state = Unconnected;
emit disconnected();
}
SftpTransferPtr SshConnection::setupTransfer(
const FilesToTransfer &files, Internal::FileTransferType type,
FileTransferErrorHandling errorHandlingMode)
{
QTC_ASSERT(state() == Connected, return SftpTransferPtr());
return SftpTransferPtr(new SftpTransfer(files, type, errorHandlingMode,
d->connectionArgs(SshSettings::sftpFilePath())));
}
} // namespace QSsh