From 004330536932766a49dcc12bd986a57d73a91c02 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 25 Mar 2013 14:55:32 +0200 Subject: [PATCH] Fix MSVC compiler warnings D:\dev\qt-creator\src\plugins\projectexplorer\toolchain.cpp:198: warning: C4138: '*/' found outside of comment D:\dev\qt-creator\src\plugins\pythoneditor\pythoneditorplugin.cpp:217: warning: C4189: 'pCore' : local variable is initialized but not referenced Change-Id: I5e1447e98ac8cbff2c2b8981ddba7e08e7506e24 Reviewed-by: Friedemann Kleint --- src/plugins/projectexplorer/toolchain.cpp | 2 +- src/plugins/pythoneditor/pythoneditorplugin.cpp | 4 +--- .../qmldesigner/components/formeditor/abstractcustomtool.cpp | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/plugins/projectexplorer/toolchain.cpp b/src/plugins/projectexplorer/toolchain.cpp index 88a615967a9..4ee75602876 100644 --- a/src/plugins/projectexplorer/toolchain.cpp +++ b/src/plugins/projectexplorer/toolchain.cpp @@ -195,7 +195,7 @@ bool ToolChain::fromMap(const QVariantMap &data) \brief Used by the toolchainkitinformation to validate the kit. */ -QList ToolChain::validateKit(const Kit */*k*/) const +QList ToolChain::validateKit(const Kit *) const { return QList(); } diff --git a/src/plugins/pythoneditor/pythoneditorplugin.cpp b/src/plugins/pythoneditor/pythoneditorplugin.cpp index 893fac076de..a800aa39256 100644 --- a/src/plugins/pythoneditor/pythoneditorplugin.cpp +++ b/src/plugins/pythoneditor/pythoneditorplugin.cpp @@ -214,9 +214,7 @@ bool PythonEditorPlugin::initialize( { Q_UNUSED(arguments) - Core::ICore *pCore = Core::ICore::instance(); - - if (! pCore->mimeDatabase()->addMimeTypes( + if (! Core::ICore::mimeDatabase()->addMimeTypes( QLatin1String(RC_PY_MIME_XML), errorMessage)) { diff --git a/src/plugins/qmldesigner/components/formeditor/abstractcustomtool.cpp b/src/plugins/qmldesigner/components/formeditor/abstractcustomtool.cpp index 772ba71f8d8..d333ef21aff 100644 --- a/src/plugins/qmldesigner/components/formeditor/abstractcustomtool.cpp +++ b/src/plugins/qmldesigner/components/formeditor/abstractcustomtool.cpp @@ -9,7 +9,7 @@ AbstractCustomTool::AbstractCustomTool() { } -void AbstractCustomTool::selectedItemsChanged(const QList &itemList) +void AbstractCustomTool::selectedItemsChanged(const QList &) { view()->changeToSelectionTool(); }