forked from qt-creator/qt-creator
Clangd: Fix autocompletion for old style SIGNAL and SLOT
Fixes: QTCREATORBUG-20737 Change-Id: If6d3c6ea5924537386eca81d90d4bb1e8f1a1466 Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -751,9 +751,8 @@ ClangdClient::ClangdCompletionAssistProcessor::generateCompletionItems(
|
||||
return itemGenerator(items);
|
||||
const QString content = doc->toPlainText();
|
||||
const bool requiresSignal = CppEditor::CppModelManager::instance()
|
||||
->positionRequiresSignal(filePath().toString(),
|
||||
content.toUtf8(),
|
||||
pos);
|
||||
->getSignalSlotType(filePath().toString(), content.toUtf8(), pos)
|
||||
== CppEditor::SignalSlotType::NewStyleSignal;
|
||||
if (requiresSignal)
|
||||
return itemGenerator(Utils::filtered(items, criterion));
|
||||
return itemGenerator(items);
|
||||
@@ -2237,6 +2236,10 @@ IAssistProcessor *ClangdClient::ClangdCompletionAssistProvider::createProcessor(
|
||||
contextAnalyzer.positionEndOfExpression(),
|
||||
contextAnalyzer.completionOperator(),
|
||||
CustomAssistMode::Preprocessor);
|
||||
case ClangCompletionContextAnalyzer::CompleteSignal:
|
||||
case ClangCompletionContextAnalyzer::CompleteSlot:
|
||||
if (!interface->isBaseObject())
|
||||
return CppEditor::getCppCompletionAssistProcessor();
|
||||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user