feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Separate TestTreeItems

Browse Source 
Change-Id: I7592365832c6a24c9edc38c6fd3e38122711f2a4
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
Christian Stenger
2016-02-23 15:49:24 +01:00
parent cb9909083b
commit 009eef4e0d
3 changed files with 176 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

103
src/plugins/autotest/testtreeitem.cpp
View File

@@ -25,6 +25,7 @@
#include "autotestconstants.h"
#include "testtreeitem.h"
#include "testtreemodel.h"
#include <utils/qtcassert.h>
@@ -349,5 +350,107 @@ TestTreeItem *TestTreeItem::findChildBy(CompareFunction compare)
return 0;
}
AutoTestTreeItem *AutoTestTreeItem::createTestItem(const TestParseResult &result)
{
AutoTestTreeItem *item = new AutoTestTreeItem(result.testCaseName, result.fileName,
TestTreeItem::TestClass);
item->setReferencingFile(result.referencingFile);
item->setLine(result.line);
item->setColumn(result.column);
foreach (const QString &functionName, result.functions.keys()) {
const TestCodeLocationAndType &locationAndType = result.functions.value(functionName);
const QString qualifiedName = result.testCaseName + QLatin1String("::") + functionName;
item->appendChild(createFunctionItem(functionName, locationAndType,
result.dataTagsOrTestSets.value(qualifiedName)));
}
return item;
}
AutoTestTreeItem *AutoTestTreeItem::createFunctionItem(const QString &functionName,
const TestCodeLocationAndType &location,
const TestCodeLocationList &dataTags)
{
AutoTestTreeItem *item = new AutoTestTreeItem(functionName, location.m_name, location.m_type);
item->setLine(location.m_line);
item->setColumn(location.m_column);
// if there are any data tags for this function add them
foreach (const TestCodeLocationAndType &tagLocation, dataTags)
item->appendChild(createDataTagItem(location.m_name, tagLocation));
return item;
}
AutoTestTreeItem *AutoTestTreeItem::createDataTagItem(const QString &fileName,
const TestCodeLocationAndType &location)
{
AutoTestTreeItem *tagItem = new AutoTestTreeItem(location.m_name, fileName, location.m_type);
tagItem->setLine(location.m_line);
tagItem->setColumn(location.m_column);
return tagItem;
}
QuickTestTreeItem *QuickTestTreeItem::createTestItem(const TestParseResult &result)
{
QuickTestTreeItem *item = new QuickTestTreeItem(result.testCaseName, result.fileName,
TestTreeItem::TestClass);
item->setReferencingFile(result.referencingFile);
item->setLine(result.line);
item->setColumn(result.column);
foreach (const QString &functionName, result.functions.keys())
item->appendChild(createFunctionItem(functionName, result.functions.value(functionName)));
return item;
}
QuickTestTreeItem *QuickTestTreeItem::createFunctionItem(const QString &functionName,
const TestCodeLocationAndType &location)
{
QuickTestTreeItem *item = new QuickTestTreeItem(functionName, location.m_name, location.m_type);
item->setLine(location.m_line);
item->setColumn(location.m_column);
return item;
}
QuickTestTreeItem *QuickTestTreeItem::createUnnamedQuickTestItem(const TestParseResult &result)
{
QuickTestTreeItem *item = new QuickTestTreeItem(QString(), QString(), TestTreeItem::TestClass);
foreach (const QString &functionName, result.functions.keys())
item->appendChild(createUnnamedQuickFunctionItem(functionName, result));
return item;
}
QuickTestTreeItem *QuickTestTreeItem::createUnnamedQuickFunctionItem(const QString &functionName,
const TestParseResult &result)
{
const TestCodeLocationAndType &location = result.functions.value(functionName);
QuickTestTreeItem *item = new QuickTestTreeItem(functionName, location.m_name, location.m_type);
item->setLine(location.m_line);
item->setColumn(location.m_column);
item->setReferencingFile(result.referencingFile);
return item;
}
GoogleTestTreeItem *GoogleTestTreeItem::createTestItem(const TestParseResult &result)
{
GoogleTestTreeItem *item = new GoogleTestTreeItem(result.testCaseName, QString(),
result.parameterized ? TestTreeItem::GTestCaseParameterized : TestTreeItem::GTestCase);
item->setReferencingFile(result.referencingFile);
foreach (const TestCodeLocationAndType &location, result.dataTagsOrTestSets.first())
item->appendChild(createTestSetItem(result, location));
return item;
}
GoogleTestTreeItem *GoogleTestTreeItem::createTestSetItem(const TestParseResult &result,
const TestCodeLocationAndType &location)
{
GoogleTestTreeItem *item = new GoogleTestTreeItem(location.m_name, result.fileName,
location.m_type);
item->setState(location.m_state);
item->setLine(location.m_line);
item->setColumn(location.m_column);
item->setReferencingFile(result.referencingFile);
return item;
}
} // namespace Internal
} // namespace Autotest

54
src/plugins/autotest/testtreeitem.h
View File

@@ -45,6 +45,10 @@ namespace Autotest {
namespace Internal {
struct TestCodeLocationAndType;
class AutoTestTreeItem;
class QuickTestTreeItem;
class GoogleTestTreeItem;
struct TestParseResult;
class TestTreeItem : public Utils::TreeItem
{
@@ -111,6 +115,10 @@ public:
TestTreeItem *findChildByNameTypeAndFile(const QString &name,
TestTreeItem::Type type, const QString &referencingFile);
virtual AutoTestTreeItem *asAutoTestTreeItem() { return 0; }
virtual QuickTestTreeItem *asQuickTestTreeItem() { return 0; }
virtual GoogleTestTreeItem *asGoogleTestTreeItem() { return 0; }
private:
void revalidateCheckState();
bool modifyFilePath(const QString &filePath);
@@ -146,6 +154,52 @@ struct GTestCaseSpec
typedef QVector<TestCodeLocationAndType> TestCodeLocationList;
class AutoTestTreeItem : public TestTreeItem
{
public:
AutoTestTreeItem(const QString &name = QString(), const QString &filePath = QString(),
Type type = Root) : TestTreeItem(name, filePath, type) {}
virtual AutoTestTreeItem *asAutoTestTreeItem() override { return this; }
static AutoTestTreeItem *createTestItem(const TestParseResult &result);
static AutoTestTreeItem *createFunctionItem(const QString &functionName,
const TestCodeLocationAndType &location,
const TestCodeLocationList &dataTags);
static AutoTestTreeItem *createDataTagItem(const QString &fileName,
const TestCodeLocationAndType &location);
};
class QuickTestTreeItem : public TestTreeItem
{
public:
QuickTestTreeItem(const QString &name = QString(), const QString &filePath = QString(),
Type type = Root) : TestTreeItem(name, filePath, type) {}
virtual QuickTestTreeItem *asQuickTestTreeItem() override { return this; }
static QuickTestTreeItem *createTestItem(const TestParseResult &result);
static QuickTestTreeItem *createFunctionItem(const QString &functionName,
const TestCodeLocationAndType &location);
static QuickTestTreeItem *createUnnamedQuickTestItem(const TestParseResult &result);
static QuickTestTreeItem *createUnnamedQuickFunctionItem(const QString &functionName,
const TestParseResult &result);
};
class GoogleTestTreeItem : public TestTreeItem
{
public:
GoogleTestTreeItem(const QString &name = QString(), const QString &filePath = QString(),
Type type = Root) : TestTreeItem(name, filePath, type) {}
virtual GoogleTestTreeItem *asGoogleTestTreeItem() override { return this; }
static GoogleTestTreeItem *createTestItem(const TestParseResult &result);
static GoogleTestTreeItem *createTestSetItem(const TestParseResult &result,
const TestCodeLocationAndType &location);
};
} // namespace Internal
} // namespace Autotest

117
src/plugins/autotest/testtreemodel.cpp
View File

@@ -655,91 +655,6 @@ QMap<QString, QString> TestTreeModel::referencingFiles() const
return finder.referencingFiles();
}
static TestTreeItem *constructDataTagTestTreeItem(const QString &fileName,
const TestCodeLocationAndType &location)
{
TestTreeItem *tagTreeItem = new TestTreeItem(location.m_name, fileName, location.m_type);
tagTreeItem->setLine(location.m_line);
tagTreeItem->setColumn(location.m_column);
tagTreeItem->setState(location.m_state);
return tagTreeItem;
}
static TestTreeItem *constructUnnamedQuickFunctionTestTreeItem(const QString &functionName,
const QString &referencingFile,
const TestCodeLocationAndType &location)
{
TestTreeItem *treeItem = new TestTreeItem(functionName, location.m_name, location.m_type);
treeItem->setLine(location.m_line);
treeItem->setColumn(location.m_column);
treeItem->setReferencingFile(referencingFile);
return treeItem;
}
static TestTreeItem *constructFunctionTestTreeItem(const QString &funcName,
const TestCodeLocationAndType &location,
const TestCodeLocationList &dataTags)
{
TestTreeItem *treeItem = new TestTreeItem(funcName, location.m_name, location.m_type);
treeItem->setLine(location.m_line);
treeItem->setColumn(location.m_column);
treeItem->setState(location.m_state);
// if there are any data tags for this function add them
foreach (const TestCodeLocationAndType &tagLocation, dataTags)
treeItem->appendChild(constructDataTagTestTreeItem(location.m_name, tagLocation));
return treeItem;
}
static TestTreeItem *constructTestTreeItem(const TestParseResult &result)
{
TestTreeItem *treeItem;
if (result.testCaseName.isEmpty()) { // unnamed Quick Test
treeItem = new TestTreeItem(QString(), QString(), TestTreeItem::TestClass);
foreach (const QString &functionName, result.functions.keys()) {
treeItem->appendChild(constructUnnamedQuickFunctionTestTreeItem(
functionName, result.referencingFile, result.functions.value(functionName)));
}
} else {
treeItem = new TestTreeItem(result.testCaseName, result.fileName, TestTreeItem::TestClass);
treeItem->setReferencingFile(result.referencingFile);
treeItem->setLine(result.line);
treeItem->setColumn(result.column);
foreach (const QString &functionName, result.functions.keys()) {
const TestCodeLocationAndType locationAndType = result.functions.value(functionName);
const QString qualifiedName = result.testCaseName + QLatin1String("::") + functionName;
treeItem->appendChild(
constructFunctionTestTreeItem(functionName, locationAndType,
result.dataTagsOrTestSets.value(qualifiedName)));
}
}
return treeItem;
}
static TestTreeItem *constructGTestSetTreeItem(const QString &filePath,
const QString &referencingFile,
const TestCodeLocationAndType &location)
{
TestTreeItem *treeItem = new TestTreeItem(location.m_name, filePath, location.m_type);
treeItem->setState(location.m_state);
treeItem->setLine(location.m_line);
treeItem->setColumn(location.m_column);
treeItem->setReferencingFile(referencingFile);
return treeItem;
}
static TestTreeItem *constructGTestTreeItem(const TestParseResult &result)
{
TestTreeItem *item = new TestTreeItem(result.testCaseName, QString(),
result.parameterized ? TestTreeItem::GTestCaseParameterized
: TestTreeItem::GTestCase);
item->setReferencingFile(result.referencingFile);
foreach (const TestCodeLocationAndType &location, result.dataTagsOrTestSets.first())
item->appendChild(constructGTestSetTreeItem(result.fileName, result.referencingFile, location));
return item;
}
void TestTreeModel::onParseResultReady(const TestParseResult &result)
{
switch (result.type) {
@@ -780,7 +695,10 @@ void TestTreeModel::handleParseResult(const TestParseResult &result)
TestTreeItem *toBeModified = root->findChildByFiles(result.fileName, result.referencingFile);
// if there's no matching item, add the new one
if (!toBeModified) {
root->appendChild(constructTestTreeItem(result));
if (result.type == AutoTest)
root->appendChild(AutoTestTreeItem::createTestItem(result));
else
root->appendChild(QuickTestTreeItem::createTestItem(result));
return;
}
// else we have to check level by level.. first the current level...
@@ -795,9 +713,14 @@ void TestTreeModel::handleParseResult(const TestParseResult &result)
// if there's no function matching, add the new one
if (!functionItem) {
const QString qualifiedName = result.testCaseName + QLatin1String("::") + func;
toBeModified->appendChild(
constructFunctionTestTreeItem(func, result.functions.value(func),
result.dataTagsOrTestSets.value(qualifiedName)));
if (result.type == AutoTest) {
toBeModified->appendChild(AutoTestTreeItem::createFunctionItem(
func, result.functions.value(func),
result.dataTagsOrTestSets.value(qualifiedName)));
} else {
toBeModified->appendChild(QuickTestTreeItem::createFunctionItem(
func, result.functions.value(func)));
}
continue;
}
// else we have to check level by level.. first the current level...
@@ -805,13 +728,13 @@ void TestTreeModel::handleParseResult(const TestParseResult &result)
functionItem->markForRemoval(false);
if (changed)
emit dataChanged(indexForItem(functionItem), indexForItem(functionItem));
// ...now the data tags
// ...now the data tags - actually these are supported only for AutoTestTreeItem
const QString &funcFileName = result.functions.value(func).m_name;
const QString qualifiedFunctionName = result.testCaseName + QLatin1String("::") + func;
foreach (const TestCodeLocationAndType &location, result.dataTagsOrTestSets.value(qualifiedFunctionName)) {
TestTreeItem *dataTagItem = functionItem->findChildByName(location.m_name);
if (!dataTagItem) {
functionItem->appendChild(constructDataTagTestTreeItem(funcFileName, location));
functionItem->appendChild(AutoTestTreeItem::createDataTagItem(funcFileName, location));
continue;
}
changed = dataTagItem->modifyDataTagContent(funcFileName, location);
@@ -826,7 +749,7 @@ void TestTreeModel::handleUnnamedQuickParseResult(const TestParseResult &result)
{
TestTreeItem *toBeModified = unnamedQuickTests();
if (!toBeModified) {
m_quickTestRootItem->appendChild(constructTestTreeItem(result));
m_quickTestRootItem->appendChild(QuickTestTreeItem::createUnnamedQuickTestItem(result));
return;
}
// if we have already Unnamed Quick tests we might update them..
@@ -834,9 +757,8 @@ void TestTreeModel::handleUnnamedQuickParseResult(const TestParseResult &result)
const TestCodeLocationAndType &location = result.functions.value(func);
TestTreeItem *functionItem = toBeModified->findChildByNameAndFile(func, location.m_name);
if (!functionItem) {
toBeModified->appendChild(
constructUnnamedQuickFunctionTestTreeItem(func, result.referencingFile,
location));
toBeModified->appendChild(QuickTestTreeItem::createUnnamedQuickFunctionItem(
func, result));
continue;
}
functionItem->modifyLineAndColumn(result.line, result.column);
@@ -851,7 +773,7 @@ void TestTreeModel::handleGTestParseResult(const TestParseResult &result)
TestTreeItem *toBeModified = m_googleTestRootItem->findChildByNameTypeAndFile(
result.testCaseName, type, result.referencingFile);
if (!toBeModified) {
m_googleTestRootItem->appendChild(constructGTestTreeItem(result));
m_googleTestRootItem->appendChild(GoogleTestTreeItem::createTestItem(result));
return;
}
// if found nothing has to be updated as all relevant members are used to find the item
@@ -859,8 +781,7 @@ void TestTreeModel::handleGTestParseResult(const TestParseResult &result)
TestTreeItem *testSetItem = toBeModified->findChildByNameAndFile(location.m_name,
result.fileName);
if (!testSetItem) {
toBeModified->appendChild(constructGTestSetTreeItem(result.fileName,
result.referencingFile, location));
toBeModified->appendChild(GoogleTestTreeItem::createTestSetItem(result, location));
continue;
}
bool changed = testSetItem->modifyGTestSetContent(result.fileName,