feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I3511e9d83f395f1f29584f35cafc59528c9edd37
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2024-02-01 11:05:00 +01:00
parent 05c6cffd6b
commit 00b69b5f90
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/solutions/tasking/tasktree.h
View File

@@ -7,7 +7,6 @@
#include <QObject> #include <QObject>
#include <QList> #include <QList>
#include <QSharedPointer>
#include <memory> #include <memory>
@@ -116,7 +115,7 @@ protected:
private: private:
friend class ExecutionContextActivator; friend class ExecutionContextActivator;
friend class TaskTreePrivate; friend class TaskTreePrivate;
QSharedPointer<LoopData> m_loopData; std::shared_ptr<LoopData> m_loopData;
}; };
class TASKING_EXPORT LoopForever final : public Loop class TASKING_EXPORT LoopForever final : public Loop
@@ -166,7 +165,7 @@ private:
friend size_t qHash(const StorageBase &storage, uint seed = 0) friend size_t qHash(const StorageBase &storage, uint seed = 0)
{ return size_t(storage.m_storageData.get()) ^ seed; } { return size_t(storage.m_storageData.get()) ^ seed; }
QSharedPointer<StorageData> m_storageData; std::shared_ptr<StorageData> m_storageData;
template <typename StorageStruct> friend class Storage; template <typename StorageStruct> friend class Storage;
friend class ExecutionContextActivator; friend class ExecutionContextActivator;