QmlDesigner.PropertyEditorView: moving QML types registration

Moving the registration of QML types from PropertyEditorView
to QuickPropertyEditorView.

The view itself should not handle QML implementation details anymore.

Change-Id: Ia66db999e2f7a4b8cbe1111c4176257344d78ea8
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
This commit is contained in:
Thomas Hartmann
2013-08-08 19:27:18 +02:00
parent 7a5cce92c2
commit 00eccf6b22
3 changed files with 34 additions and 26 deletions

View File

@@ -43,17 +43,7 @@
#include <rewriterview.h> #include <rewriterview.h>
#include "propertyeditorvalue.h" #include "propertyeditorvalue.h"
#include "basiclayouts.h"
#include "basicwidgets.h"
#include "resetwidget.h"
#include "qlayoutobject.h"
#include <qmleditorwidgets/colorwidgets.h>
#include "gradientlineqmladaptor.h"
#include "behaviordialog.h"
#include "fontwidget.h"
#include "siblingcombobox.h"
#include "propertyeditortransaction.h" #include "propertyeditortransaction.h"
#include "originwidget.h"
#include <utils/fileutils.h> #include <utils/fileutils.h>
@@ -96,22 +86,7 @@ PropertyEditorView::PropertyEditorView(QWidget *parent) :
m_stackedWidget->insertWidget(0, new QWidget(m_stackedWidget)); m_stackedWidget->insertWidget(0, new QWidget(m_stackedWidget));
QuickPropertyEditorView::registerQmlTypes();
static bool declarativeTypesRegistered = false;
if (!declarativeTypesRegistered) {
declarativeTypesRegistered = true;
BasicWidgets::registerDeclarativeTypes();
BasicLayouts::registerDeclarativeTypes();
ResetWidget::registerDeclarativeType();
QLayoutObject::registerDeclarativeType();
QmlEditorWidgets::ColorWidgets::registerDeclarativeTypes();
BehaviorDialog::registerDeclarativeType();
PropertyEditorValue::registerDeclarativeTypes();
FontWidget::registerDeclarativeTypes();
SiblingComboBox::registerDeclarativeTypes();
OriginWidget::registerDeclarativeType();
GradientLineQmlAdaptor::registerDeclarativeType();
}
setQmlDir(PropertyEditorQmlBackend::propertyEditorResourcesPath()); setQmlDir(PropertyEditorQmlBackend::propertyEditorResourcesPath());
m_stackedWidget->setWindowTitle(tr("Properties")); m_stackedWidget->setWindowTitle(tr("Properties"));
} }

View File

@@ -29,6 +29,17 @@
#include "quickpropertyeditorview.h" #include "quickpropertyeditorview.h"
#include "basiclayouts.h"
#include "basicwidgets.h"
#include "resetwidget.h"
#include "qlayoutobject.h"
#include <qmleditorwidgets/colorwidgets.h>
#include "gradientlineqmladaptor.h"
#include "behaviordialog.h"
#include "fontwidget.h"
#include "siblingcombobox.h"
#include "originwidget.h"
#include <QDeclarativeItem> #include <QDeclarativeItem>
#include <QDeclarativeEngine> #include <QDeclarativeEngine>
#include <QDeclarativeContext> #include <QDeclarativeContext>
@@ -141,4 +152,24 @@ void QuickPropertyEditorView::setRootWidget(QWidget *widget)
} }
} }
void QuickPropertyEditorView::registerQmlTypes()
{
static bool declarativeTypesRegistered = false;
if (!declarativeTypesRegistered) {
declarativeTypesRegistered = true;
BasicWidgets::registerDeclarativeTypes();
BasicLayouts::registerDeclarativeTypes();
ResetWidget::registerDeclarativeType();
QLayoutObject::registerDeclarativeType();
QmlEditorWidgets::ColorWidgets::registerDeclarativeTypes();
BehaviorDialog::registerDeclarativeType();
PropertyEditorValue::registerDeclarativeTypes();
FontWidget::registerDeclarativeTypes();
SiblingComboBox::registerDeclarativeTypes();
OriginWidget::registerDeclarativeType();
GradientLineQmlAdaptor::registerDeclarativeType();
}
}
} //QmlDesigner } //QmlDesigner

View File

@@ -62,6 +62,8 @@ public:
enum Status { Null, Ready, Loading, Error }; enum Status { Null, Ready, Loading, Error };
Status status() const; Status status() const;
static void registerQmlTypes();
signals: signals:
void statusChanged(QuickPropertyEditorView::Status); void statusChanged(QuickPropertyEditorView::Status);