From 00f685cba49e7e293f55e8a2ae920e0ae97d9192 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 23 Jun 2020 07:26:58 +0200
Subject: [PATCH] Valgrind: Replace QLinkedList

Task-number: QTCREATORBUG-24098
Change-Id: I611bab2bbd47c969c64037173f5ea68240ca28ff
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/plugins/valgrind/callgrindvisualisation.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/plugins/valgrind/callgrindvisualisation.cpp b/src/plugins/valgrind/callgrindvisualisation.cpp
index 905618e5688..dd6aa95e7ce 100644
--- a/src/plugins/valgrind/callgrindvisualisation.cpp
+++ b/src/plugins/valgrind/callgrindvisualisation.cpp
@@ -33,17 +33,17 @@
 #include <valgrind/callgrind/callgrindproxymodel.h>
 #include <utils/qtcassert.h>
 
+#include <QAbstractItemModel>
+#include <QDebug>
 #include <QGraphicsRectItem>
 #include <QGraphicsScene>
 #include <QGraphicsSimpleTextItem>
 #include <QMouseEvent>
-#include <QStaticText>
-#include <QStyleOptionGraphicsItem>
 #include <QPair>
 #include <QPersistentModelIndex>
-#include <QLinkedList>
-#include <QAbstractItemModel>
-#include <QDebug>
+#include <QStaticText>
+#include <QStyleOptionGraphicsItem>
+#include <QVector>
 
 #define VISUALISATION_DEBUG 0
 // Margin from hardcoded value in:
@@ -364,7 +364,7 @@ void Visualization::populateScene()
     qreal total = 0;
 
     using Pair = QPair<QModelIndex, qreal>;
-    QLinkedList<Pair> costs;
+    QVector<Pair> costs;
     for (int row = 0; row < d->m_model->rowCount(); ++row) {
         const QModelIndex index = d->m_model->index(row, DataModel::InclusiveCostColumn);
 
@@ -402,7 +402,7 @@ void Visualization::populateScene()
 
     // add the canvas elements to the scene
     qreal used = sceneHeight * 0.1;
-    foreach (const Pair &cost, costs) {
+    for (const Pair &cost : qAsConst(costs)) {
         const QModelIndex &index = cost.first;
         const QString text = index.data().toString();