From 014154e1678fbd4510727c5a7660c46b2b6e45e5 Mon Sep 17 00:00:00 2001 From: Daniel Teske Date: Mon, 31 Oct 2011 12:31:15 +0100 Subject: [PATCH] Don't ask the user if a buildstep reported non success Change-Id: I636d24eaadbf93df8dac1cf362d1d753c9660fa6 Reviewed-by: Eike Ziller --- .../projectexplorer/projectexplorer.cpp | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp index 9d5e2b16e99..374b13c5bd6 100644 --- a/src/plugins/projectexplorer/projectexplorer.cpp +++ b/src/plugins/projectexplorer/projectexplorer.cpp @@ -1557,19 +1557,17 @@ void ProjectExplorerPlugin::buildQueueFinished(bool success) updateActions(); - bool ignoreErrors = true; - if (d->m_delayedRunConfiguration) { - if (d->m_buildManager->getErrorTaskCount() > 0) { - ignoreErrors = QMessageBox::question(Core::ICore::instance()->mainWindow(), - tr("Ignore all errors?"), - tr("Found some build errors in current task.\n" - "Do you want to ignore them?"), - QMessageBox::Yes | QMessageBox::No, - QMessageBox::No) == QMessageBox::Yes; - } + bool ignoreErrors = false; + if (d->m_delayedRunConfiguration && success && d->m_buildManager->getErrorTaskCount() > 0) { + ignoreErrors = QMessageBox::question(Core::ICore::instance()->mainWindow(), + tr("Ignore all errors?"), + tr("Found some build errors in current task.\n" + "Do you want to ignore them?"), + QMessageBox::Yes | QMessageBox::No, + QMessageBox::No) == QMessageBox::Yes; } - if (success && ignoreErrors && d->m_delayedRunConfiguration) { + if ((success || ignoreErrors) && d->m_delayedRunConfiguration) { executeRunConfiguration(d->m_delayedRunConfiguration, d->m_runMode); } else { if (d->m_buildManager->tasksAvailable())