From 0158dfcfd2e26a1786d23e9374a8c84e5adc935b Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Wed, 23 Sep 2020 15:08:57 +0200 Subject: [PATCH] LSP: Do not use FullyEncoded in QUrl::toString Change-Id: I8f978327a1d12f7d418a77ac4bc70b135142f989 Reviewed-by: David Schulz --- src/libs/languageserverprotocol/lsptypes.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libs/languageserverprotocol/lsptypes.cpp b/src/libs/languageserverprotocol/lsptypes.cpp index 04594e54930..c9e44e4c38d 100644 --- a/src/libs/languageserverprotocol/lsptypes.cpp +++ b/src/libs/languageserverprotocol/lsptypes.cpp @@ -403,13 +403,11 @@ Utils::Link Location::toLink() const if (!isValid(nullptr)) return Utils::Link(); - // QUrl::FullyDecoded is not supported by QUrl::toString. // Ensure %xx like %20 are really decoded using fromPercentEncoding // Else, a path with spaces would keep its %20 which would cause failure // to open the file by the text editor. This is the cases with compilers in // C:\Programs Files on Windows. - auto file = uri().toString(QUrl::FullyDecoded | QUrl::PreferLocalFile); - + auto file = uri().toString(QUrl::PrettyDecoded | QUrl::PreferLocalFile); // fromPercentEncoding convert %xx encoding to raw values and then interpret // the result as utf-8, so toUtf8() must be used here. file = QUrl::fromPercentEncoding(file.toUtf8());