From 015c1475422c10643995b883b40a243e1f1f95ce Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 6 Dec 2024 14:33:48 +0100 Subject: [PATCH] ProjectExplorer: Remove some explicit QTextCodec use Default in Utils::Process implementation is now good enough. Change-Id: I3840c60b019f10949f0ba625a197cae41e103b8e Reviewed-by: Marcus Tillmanns --- src/plugins/projectexplorer/runcontrol.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/plugins/projectexplorer/runcontrol.cpp b/src/plugins/projectexplorer/runcontrol.cpp index 7041a168631..666c734aab1 100644 --- a/src/plugins/projectexplorer/runcontrol.cpp +++ b/src/plugins/projectexplorer/runcontrol.cpp @@ -42,7 +42,6 @@ #include #include -#include #include #if defined (WITH_JOURNALD) @@ -1522,15 +1521,14 @@ void SimpleTargetRunnerPrivate::handleStandardError() void SimpleTargetRunnerPrivate::start() { - const bool isLocal = !m_command.executable().needsDevice(); - CommandLine cmdLine = m_command; Environment env = m_environment; m_resultData = {}; QTC_ASSERT(m_state == Inactive, return); - if (isLocal) { + if (!m_command.executable().needsDevice()) { + // Running locally. if (m_runAsRoot) RunControl::provideAskPassEntry(env); @@ -1565,7 +1563,6 @@ void SimpleTargetRunnerPrivate::start() m_state = Run; m_process.setWorkingDirectory(m_workingDirectory); - m_process.setCodec(isLocal ? QTextCodec::codecForLocale() : QTextCodec::codecForName("utf8")); m_process.setForceDefaultErrorModeOnWindows(true); m_process.start(); }