From 019092d7f6aed048302a99a72d5c00bb1f127a1d Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Wed, 5 Sep 2018 16:36:57 +0200 Subject: [PATCH] Fix terminal command on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After 4c88c1808cddc2f134203e62b276f2f413e455c6 the terminal command itself may no longer have quoted spaces (since it is directly passed to QProcess as the program name). Change-Id: Iee4b9a6c3a87c29cb29cc732f6027f1c742f9eb5 Reviewed-by: André Hartmann Reviewed-by: Tobias Hunger --- src/libs/utils/consoleprocess_unix.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libs/utils/consoleprocess_unix.cpp b/src/libs/utils/consoleprocess_unix.cpp index fd426a5f0c3..ffaf34d5e8e 100644 --- a/src/libs/utils/consoleprocess_unix.cpp +++ b/src/libs/utils/consoleprocess_unix.cpp @@ -350,9 +350,10 @@ TerminalCommand ConsoleProcess::defaultTerminalEmulator() if (defaultTerm.command.isEmpty()) { defaultTerm = []() -> TerminalCommand { if (HostOsInfo::isMacHost()) { - QString termCmd = QCoreApplication::applicationDirPath() + "/../Resources/scripts/openTerminal.command"; + const QString termCmd = QCoreApplication::applicationDirPath() + + "/../Resources/scripts/openTerminal.command"; if (QFileInfo::exists(termCmd)) - return {termCmd.replace(' ', "\\ "), "", ""}; + return {termCmd, "", ""}; return {"/usr/X11/bin/xterm", "", "-e"}; } const Environment env = Environment::systemEnvironment();