feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Improve gdb binary settings handling.

Browse Source 
- Remove non-executable entries  on reading (check only
  absolute paths since path search is too expensive).
- Make sure gdb binary settings are not written out unless the
  user really changes them.

Reviewed-by: aep <arvid.picciani@nokia.com>
Acked-By: hjk
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
This commit is contained in:
Friedemann Kleint
2010-11-03 13:37:01 +01:00
parent 7a0e15b14e
commit 019be3e850
5 changed files with 72 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/debugger/debuggeractions.h
View File

@@ -55,10 +55,8 @@ public:
explicit DebuggerSettings(QObject *parent = 0);
~DebuggerSettings();
GdbBinaryToolChainMap gdbBinaryToolChainMap() const
{ return m_gdbBinaryToolChainMap; }
void setGdbBinaryToolChainMap(const GdbBinaryToolChainMap &map)
{ m_gdbBinaryToolChainMap = map; }
GdbBinaryToolChainMap gdbBinaryToolChainMap() const;
void setGdbBinaryToolChainMap(const GdbBinaryToolChainMap &map);
void insertItem(int code, Utils::SavedAction *item);
Utils::SavedAction *item(int code) const;
@@ -72,11 +70,14 @@ public slots:
void writeSettings(QSettings *settings) const;
private:
void readGdbBinarySettings(const QSettings *settings);
void writeGdbBinarySettings(QSettings *settings) const;
QHash<int, Utils::SavedAction *> m_items;
GdbBinaryToolChainMap m_gdbBinaryToolChainMap;
bool m_gdbBinariesChanged;
};
///////////////////////////////////////////////////////////
enum DebuggerActionCode