feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Move OptionsPage to the usual place

Browse Source 
Change-Id: Ic70274a7066c1335ae0263f57d29b1c543b94ffe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-02-03 09:18:49 +01:00
parent 1a86b68809
commit 019d16fad7
3 changed files with 22 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/clangtools/clangtoolsplugin.cpp
View File

@@ -36,8 +36,6 @@
#include "clangtoolsunittests.h" #include "clangtoolsunittests.h"
#endif #endif
#include <debugger/analyzer/analyzericons.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
@@ -46,7 +44,6 @@
#include <coreplugin/actionmanager/command.h> #include <coreplugin/actionmanager/command.h>
#include <coreplugin/actionmanager/actioncontainer.h> #include <coreplugin/actionmanager/actioncontainer.h>
#include <coreplugin/coreconstants.h> #include <coreplugin/coreconstants.h>
#include <coreplugin/dialogs/ioptionspage.h>
#include <cpptools/cpptoolsconstants.h> #include <cpptools/cpptoolsconstants.h>
#include <cpptools/cppmodelmanager.h> #include <cpptools/cppmodelmanager.h>
@@ -74,22 +71,6 @@ ProjectPanelFactory *projectPanelFactory()
return m_projectPanelFactoryInstance; return m_projectPanelFactoryInstance;
} }
class ClangToolsOptionsPage : public IOptionsPage
{
public:
ClangToolsOptionsPage()
{
setId(Constants::SETTINGS_PAGE_ID);
setDisplayName(QCoreApplication::translate(
"ClangTools::Internal::ClangToolsOptionsPage",
"Clang Tools"));
setCategory("T.Analyzer");
setDisplayCategory(QCoreApplication::translate("Analyzer", "Analyzer"));
setCategoryIconPath(Analyzer::Icons::SETTINGSCATEGORY_ANALYZER);
setWidgetCreator([] { return new SettingsWidget; });
}
};
class ClangToolsPluginPrivate class ClangToolsPluginPrivate
{ {
public: public:

16
src/plugins/clangtools/settingswidget.cpp
View File

@@ -33,6 +33,8 @@
#include <cpptools/clangdiagnosticconfigsmodel.h> #include <cpptools/clangdiagnosticconfigsmodel.h>
#include <cpptools/clangdiagnosticconfigsselectionwidget.h> #include <cpptools/clangdiagnosticconfigsselectionwidget.h>
#include <debugger/analyzer/analyzericons.h>
#include <utils/optional.h> #include <utils/optional.h>
namespace ClangTools { namespace ClangTools {
@@ -147,5 +149,19 @@ QString SettingsWidget::clazyStandalonePath() const
return m_ui->clazyStandalonePathChooser->rawPath(); return m_ui->clazyStandalonePathChooser->rawPath();
} }
// ClangToolsOptionsPage
ClangToolsOptionsPage::ClangToolsOptionsPage()
{
setId(Constants::SETTINGS_PAGE_ID);
setDisplayName(QCoreApplication::translate(
"ClangTools::Internal::ClangToolsOptionsPage",
"Clang Tools"));
setCategory("T.Analyzer");
setDisplayCategory(QCoreApplication::translate("Analyzer", "Analyzer"));
setCategoryIconPath(Analyzer::Icons::SETTINGSCATEGORY_ANALYZER);
setWidgetCreator([] { return new SettingsWidget; });
}
} // namespace Internal } // namespace Internal
} // namespace ClangTools } // namespace ClangTools

6
src/plugins/clangtools/settingswidget.h
View File

@@ -56,5 +56,11 @@ private:
ClangToolsSettings *m_settings; ClangToolsSettings *m_settings;
}; };
class ClangToolsOptionsPage final : public Core::IOptionsPage
{
public:
ClangToolsOptionsPage();
};
} // namespace Internal } // namespace Internal
} // namespace ClangTools } // namespace ClangTools