feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove two not-so-important uses of Node::nodeType()

Browse Source 
Progress towards removing these flags.

Change-Id: Idc98d8b104c4fe56501a0fed79f4539a8335f755
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-02-27 12:54:31 +01:00
parent 4e0ff112e4
commit 020ab0d9ee
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmldesigner/documentmanager.cpp
View File

@@ -395,8 +395,7 @@ void DocumentManager::findPathToIsoProFile(bool *iconResourceFileAlreadyExists,
ProjectExplorer::Node *iconQrcFileNode = nullptr; ProjectExplorer::Node *iconQrcFileNode = nullptr;
while (node && !iconQrcFileNode) { while (node && !iconQrcFileNode) {
qCDebug(documentManagerLog) << "Checking" << node->displayName() qCDebug(documentManagerLog) << "Checking" << node->displayName() << "(" << node << ")";
<< "(" << node << static_cast<int>(node->nodeType()) << ")";
if (node->isVirtualFolderType() && node->displayName() == "Resources") { if (node->isVirtualFolderType() && node->displayName() == "Resources") {
auto virtualFolderNode = dynamic_cast<ProjectExplorer::VirtualFolderNode*>(node); auto virtualFolderNode = dynamic_cast<ProjectExplorer::VirtualFolderNode*>(node);
@@ -405,8 +404,7 @@ void DocumentManager::findPathToIsoProFile(bool *iconResourceFileAlreadyExists,
ProjectExplorer::FolderNode *subFolderNode = virtualFolderNode->folderNodes().at(subFolderIndex); ProjectExplorer::FolderNode *subFolderNode = virtualFolderNode->folderNodes().at(subFolderIndex);
qCDebug(documentManagerLog) << "Checking if" << subFolderNode->displayName() << "(" qCDebug(documentManagerLog) << "Checking if" << subFolderNode->displayName() << "("
<< subFolderNode << static_cast<int>(subFolderNode->nodeType()) << subFolderNode << ") is" << isoIconsQrcFile;
<< ") is" << isoIconsQrcFile;
if (subFolderNode->isFolderNodeType() && subFolderNode->displayName() == isoIconsQrcFile) { if (subFolderNode->isFolderNodeType() && subFolderNode->displayName() == isoIconsQrcFile) {
qCDebug(documentManagerLog) << "Found" << isoIconsQrcFile << "in" << virtualFolderNode->filePath(); qCDebug(documentManagerLog) << "Found" << isoIconsQrcFile << "in" << virtualFolderNode->filePath();