feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSInspectorAgent: Refactor code

Browse Source 
Try to use the watchHandler for referring to the object tree
instead of caching the object tree locally.

Change-Id: I68624771ef49d50f2cf0d6d580b1b34d57483178
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
This commit is contained in:
Aurindam Jana
2012-05-14 23:26:23 +02:00
parent 6ef2c09247
commit 023deff474
7 changed files with 274 additions and 423 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libs/qmldebug/baseenginedebugclient.cpp
View File

@@ -286,14 +286,14 @@ quint32 BaseEngineDebugClient::addWatch(const ObjectReference &object,
return id;
}
quint32 BaseEngineDebugClient::addWatch(const ObjectReference &object)
quint32 BaseEngineDebugClient::addWatch(int objectId)
{
quint32 id = 0;
if (status() == Enabled) {
id = getId();
QByteArray message;
QDataStream ds(&message, QIODevice::WriteOnly);
ds << QByteArray("WATCH_OBJECT") << id << object.m_debugId;
ds << QByteArray("WATCH_OBJECT") << id << objectId;
sendMessage(message);
}
return id;
@@ -341,28 +341,28 @@ quint32 BaseEngineDebugClient::queryRootContexts(const EngineReference &engine)
return id;
}
quint32 BaseEngineDebugClient::queryObject(const ObjectReference &object)
quint32 BaseEngineDebugClient::queryObject(int objectId)
{
quint32 id = 0;
if (status() == Enabled && object.m_debugId != -1) {
if (status() == Enabled && objectId != -1) {
id = getId();
QByteArray message;
QDataStream ds(&message, QIODevice::WriteOnly);
ds << QByteArray("FETCH_OBJECT") << id << object.m_debugId << false <<
ds << QByteArray("FETCH_OBJECT") << id << objectId << false <<
true;
sendMessage(message);
}
return id;
}
quint32 BaseEngineDebugClient::queryObjectRecursive(const ObjectReference &object)
quint32 BaseEngineDebugClient::queryObjectRecursive(int objectId)
{
quint32 id = 0;
if (status() == Enabled && object.m_debugId != -1) {
if (status() == Enabled && objectId != -1) {
id = getId();
QByteArray message;
QDataStream ds(&message, QIODevice::WriteOnly);
ds << QByteArray("FETCH_OBJECT") << id << object.m_debugId << true <<
ds << QByteArray("FETCH_OBJECT") << id << objectId << true <<
true;
sendMessage(message);
}