feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Macros: Modernize

Browse Source 
* Replace 0 with nullptr
* Remove redundant pimpl
* Use inline member initialization

Started-by: Laurent Montel <laurent.montel@kdab.com>
Change-Id: I15ace2581c13ecf24b7c947972b9435fbcaa12ab
Reviewed-by: Laurent Montel <laurent.montel@kdab.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Orgad Shaneh
2017-02-27 15:47:47 +01:00
committed by Orgad Shaneh
parent e99b86e8ca
commit 0269bf537b
7 changed files with 16 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/plugins/macros/imacrohandler.cpp
View File

@@ -67,55 +67,31 @@ using namespace Macros::Internal;
the macro event.
*/
class IMacroHandler::IMacroHandlerPrivate
{
public:
IMacroHandlerPrivate();
Macro *currentMacro;
};
IMacroHandler::IMacroHandlerPrivate::IMacroHandlerPrivate() :
currentMacro(0)
{
}
// ---------- IMacroHandler ------------
IMacroHandler::IMacroHandler():
d(new IMacroHandlerPrivate)
{
}
IMacroHandler::~IMacroHandler()
{
delete d;
}
void IMacroHandler::startRecording(Macro* macro)
{
d->currentMacro = macro;
m_currentMacro = macro;
}
void IMacroHandler::endRecordingMacro(Macro* macro)
{
Q_UNUSED(macro)
d->currentMacro = 0;
m_currentMacro = nullptr;
}
void IMacroHandler::addMacroEvent(const MacroEvent& event)
{
if (d->currentMacro)
d->currentMacro->append(event);
if (m_currentMacro)
m_currentMacro->append(event);
}
void IMacroHandler::setCurrentMacro(Macro *macro)
{
d->currentMacro = macro;
m_currentMacro = macro;
}
bool IMacroHandler::isRecording() const
{
return d->currentMacro != 0;
return m_currentMacro != nullptr;
}