From 02785342acc1580210e6d69b5893c431ddc0c009 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 23 Apr 2020 16:47:25 +0200 Subject: [PATCH] Fix some clang warnings about unused lambda captures There are more, but we need to keep those because MSVC believes they are required. This is the subset that satisifies both compilers. Change-Id: I0b0a63d5496acc119a7f0513d3a1da0b76fa1fca Reviewed-by: hjk Reviewed-by: David Schulz Reviewed-by: Eike Ziller --- src/plugins/autotest/autotestplugin.cpp | 2 +- src/plugins/coreplugin/documentmanager.cpp | 2 +- src/plugins/debugger/debuggermainwindow.cpp | 2 +- src/plugins/debugger/lldb/lldbengine.cpp | 2 +- src/plugins/help/helpplugin.cpp | 2 +- .../qmldesigner/components/integration/designdocument.cpp | 2 +- .../qmldesigner/components/navigator/navigatortreemodel.cpp | 2 +- src/plugins/qmldesigner/components/navigator/navigatorview.cpp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/autotest/autotestplugin.cpp b/src/plugins/autotest/autotestplugin.cpp index faeb46df38d..9e01a295ced 100644 --- a/src/plugins/autotest/autotestplugin.cpp +++ b/src/plugins/autotest/autotestplugin.cpp @@ -157,7 +157,7 @@ AutotestPluginPrivate::AutotestPluginPrivate() this, [this] { m_runconfigCache.clear(); }); connect(sessionManager, &ProjectExplorer::SessionManager::aboutToRemoveProject, - this, [this] (ProjectExplorer::Project *project) { + this, [] (ProjectExplorer::Project *project) { auto it = s_projectSettings.find(project); if (it != s_projectSettings.end()) { delete it.value(); diff --git a/src/plugins/coreplugin/documentmanager.cpp b/src/plugins/coreplugin/documentmanager.cpp index 68f0b4674c0..f769b2484bc 100644 --- a/src/plugins/coreplugin/documentmanager.cpp +++ b/src/plugins/coreplugin/documentmanager.cpp @@ -275,7 +275,7 @@ DocumentManager::DocumentManager(QObject *parent) m_instance = this; connect(Utils::GlobalFileChangeBlocker::instance(), &Utils::GlobalFileChangeBlocker::stateChanged, - this, [this](bool blocked) { + this, [](bool blocked) { d->m_postponeAutoReload = blocked; if (!blocked) QTimer::singleShot(500, m_instance, &DocumentManager::checkForReload); diff --git a/src/plugins/debugger/debuggermainwindow.cpp b/src/plugins/debugger/debuggermainwindow.cpp index 67307871079..53e37ecc1a4 100644 --- a/src/plugins/debugger/debuggermainwindow.cpp +++ b/src/plugins/debugger/debuggermainwindow.cpp @@ -250,7 +250,7 @@ DebuggerMainWindowPrivate::DebuggerMainWindowPrivate(DebuggerMainWindow *parent) m_toolBarDock = dock; q->addDockWidget(Qt::BottomDockWidgetArea, m_toolBarDock); - connect(viewButton, &QAbstractButton::clicked, this, [this, viewButton] { + connect(viewButton, &QAbstractButton::clicked, this, [viewButton] { ActionContainer *viewsMenu = ActionManager::actionContainer(Core::Constants::M_VIEW_VIEWS); viewsMenu->menu()->exec(viewButton->mapToGlobal(QPoint())); }); diff --git a/src/plugins/debugger/lldb/lldbengine.cpp b/src/plugins/debugger/lldb/lldbengine.cpp index 61d9012ccb0..05a7d3b14f5 100644 --- a/src/plugins/debugger/lldb/lldbengine.cpp +++ b/src/plugins/debugger/lldb/lldbengine.cpp @@ -673,7 +673,7 @@ void LldbEngine::requestModuleSymbols(const QString &moduleName) { DebuggerCommand cmd("fetchSymbols"); cmd.arg("module", moduleName); - cmd.callback = [this, moduleName](const DebuggerResponse &response) { + cmd.callback = [moduleName](const DebuggerResponse &response) { const GdbMi &symbols = response.data["symbols"]; QString moduleName = response.data["module"].data(); Symbols syms; diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp index 4a6c47f879c..6ec180e09d1 100644 --- a/src/plugins/help/helpplugin.cpp +++ b/src/plugins/help/helpplugin.cpp @@ -373,7 +373,7 @@ HelpWidget *HelpPluginPrivate::createHelpWidget(const Context &context, HelpWidg &LocalHelpManager::returnOnCloseChanged, widget, &HelpWidget::updateCloseButton); - connect(widget, &HelpWidget::closeButtonClicked, this, [this, widget] { + connect(widget, &HelpWidget::closeButtonClicked, this, [widget] { if (widget->widgetStyle() == HelpWidget::SideBarWidget) RightPaneWidget::instance()->setShown(false); else if (widget->viewerCount() == 1 && LocalHelpManager::returnOnClose()) diff --git a/src/plugins/qmldesigner/components/integration/designdocument.cpp b/src/plugins/qmldesigner/components/integration/designdocument.cpp index e5d7e8978dc..9acede8f799 100644 --- a/src/plugins/qmldesigner/components/integration/designdocument.cpp +++ b/src/plugins/qmldesigner/components/integration/designdocument.cpp @@ -488,7 +488,7 @@ void DesignDocument::paste() } } - rewriterView()->executeInTransaction("DesignDocument::paste1", [this, &view, selectedNodes, targetNode](){ + rewriterView()->executeInTransaction("DesignDocument::paste1", [&view, selectedNodes, targetNode](){ QList pastedNodeList; int offset = double(qrand()) / RAND_MAX * 20 - 10; diff --git a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp index c91ff78626f..2e7a466a407 100644 --- a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp +++ b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp @@ -602,7 +602,7 @@ void NavigatorTreeModel::moveNodesInteractive(NodeAbstractProperty &parentProper { QTC_ASSERT(m_view, return); - m_view->executeInTransaction("NavigatorTreeModel::moveNodesInteractive",[this, &parentProperty, modelNodes, targetIndex](){ + m_view->executeInTransaction("NavigatorTreeModel::moveNodesInteractive",[&parentProperty, modelNodes, targetIndex](){ const TypeName propertyQmlType = parentProperty.parentModelNode().metaInfo().propertyTypeName(parentProperty.name()); foreach (const ModelNode &modelNode, modelNodes) { if (modelNode.isValid() diff --git a/src/plugins/qmldesigner/components/navigator/navigatorview.cpp b/src/plugins/qmldesigner/components/navigator/navigatorview.cpp index 86404e0ea0a..320825c7629 100644 --- a/src/plugins/qmldesigner/components/navigator/navigatorview.cpp +++ b/src/plugins/qmldesigner/components/navigator/navigatorview.cpp @@ -155,7 +155,7 @@ void NavigatorView::handleChangedExport(const ModelNode &modelNode, bool exporte if (rootNode.hasProperty(modelNodeId)) rootNode.removeProperty(modelNodeId); if (exported) { - executeInTransaction("NavigatorTreeModel:exportItem", [this, modelNode](){ + executeInTransaction("NavigatorTreeModel:exportItem", [modelNode](){ QmlObjectNode qmlObjectNode(modelNode); qmlObjectNode.ensureAliasExport(); });