Nim: Aspectify NimBuildConfiguration

Change-Id: Iccf81e3a089a6b6d756aace99c5051dc7349b6b9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-04-26 19:26:50 +02:00
parent 80be7adcdb
commit 02ab64f239
9 changed files with 10 additions and 187 deletions

View File

@@ -24,7 +24,6 @@
****************************************************************************/
#include "nimbuildconfiguration.h"
#include "nimbuildconfigurationwidget.h"
#include "nimcompilerbuildstep.h"
#include "nimproject.h"
#include "nimbuildconfiguration.h"
@@ -43,6 +42,7 @@
#include <projectexplorer/projectexplorerconstants.h>
#include <projectexplorer/projectmacroexpander.h>
#include <projectexplorer/target.h>
#include <projectexplorer/projectconfigurationaspects.h>
#include <utils/mimetypes/mimedatabase.h>
#include <utils/qtcassert.h>
@@ -73,6 +73,9 @@ static FileName defaultBuildDirectory(const Kit *k,
NimBuildConfiguration::NimBuildConfiguration(Target *target, Core::Id id)
: BuildConfiguration(target, id)
{
setConfigWidgetDisplayName(tr("General"));
setConfigWidgetHasFrame(true);
setBuildDirectorySettingsKey("Nim.NimBuildConfiguration.BuildDirectory");
}
void NimBuildConfiguration::initialize(const BuildInfo &info)
@@ -118,39 +121,11 @@ void NimBuildConfiguration::initialize(const BuildInfo &info)
}
}
NamedWidget *NimBuildConfiguration::createConfigWidget()
{
return new NimBuildConfigurationWidget(this);
}
BuildConfiguration::BuildType NimBuildConfiguration::buildType() const
{
return BuildConfiguration::Unknown;
}
bool NimBuildConfiguration::fromMap(const QVariantMap &map)
{
if (!BuildConfiguration::fromMap(map))
return false;
const QString displayName = map[Constants::C_NIMBUILDCONFIGURATION_DISPLAY_KEY].toString();
const QString buildDirectory = map[Constants::C_NIMBUILDCONFIGURATION_BUILDDIRECTORY_KEY].toString();
setDisplayName(displayName);
setBuildDirectory(FileName::fromString(buildDirectory));
return true;
}
QVariantMap NimBuildConfiguration::toMap() const
{
QVariantMap result = BuildConfiguration::toMap();
result[Constants::C_NIMBUILDCONFIGURATION_DISPLAY_KEY] = displayName();
result[Constants::C_NIMBUILDCONFIGURATION_BUILDDIRECTORY_KEY] = buildDirectory().toString();
return result;
}
FileName NimBuildConfiguration::cacheDirectory() const
{
return buildDirectory().appendPath(QStringLiteral("nimcache"));