feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Drop ITestSettingsPage intermediate class

Browse Source 
Less code in total, and more uniform with other IOptionPage subclasses.

Change-Id: I3d1cb9fae0faf32a360394cc5cf3262a9b59b456
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-01-10 12:00:37 +01:00
parent d86fba3ee1
commit 03003872bc
19 changed files with 41 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/autotest/itestframework.h
View File

@@ -28,10 +28,11 @@
#include "testtreeitem.h"
#include "itestparser.h"
namespace Core { class IOptionsPage; }
namespace Autotest {
class IFrameworkSettings;
class ITestSettingsPage;
class ITestFramework
{
@@ -47,7 +48,7 @@ public:
virtual unsigned priority() const = 0; // should this be modifyable?
virtual bool hasFrameworkSettings() const { return false; }
virtual IFrameworkSettings *createFrameworkSettings() const { return nullptr; }
virtual ITestSettingsPage *createSettingsPage(QSharedPointer<IFrameworkSettings> settings) const
virtual Core::IOptionsPage *createSettingsPage(QSharedPointer<IFrameworkSettings> settings) const
{
Q_UNUSED(settings)
return nullptr;
@@ -66,6 +67,8 @@ public:
return m_testParser;
}
Core::Id settingsId() const;
bool active() const { return m_active; }
void setActive(bool active) { m_active = active; }
bool grouping() const { return m_grouping; }