Themed Icons: Introduce Utils::Icon

Instead of describing icons via file name or in the themed icons case
via
a string that is a list of mask/color pairs, we have now a class for it.

Icons are now listed in per-plugin *icons.h headers.

RunControl::m_icon was The only place left where an icon property was in
fact a string. This patch changes that member to be a Utils::Icon.

Change-Id: Ibcfa8bb25e6d2e330c567ee7ccc0b97ead603177
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

src/plugins/valgrind/valgrindplugin.cpp

@@ -38,6 +38,7 @@
 #include "valgrindsettings.h"
 #include "valgrindconfigwidget.h"
 
+#include <analyzerbase/analyzericons.h>
 #include <analyzerbase/analyzermanager.h>
 #include <analyzerbase/analyzerruncontrol.h>
 #include <analyzerbase/analyzerstartparameters.h>
@@ -56,7 +57,6 @@
 #include <projectexplorer/projectexplorer.h>
 
 #include <utils/hostosinfo.h>
-#include <utils/themehelper.h>
 
 #include <QtPlugin>
 #include <QCoreApplication>
@@ -249,8 +249,7 @@ void ValgrindPlugin::extensionsInitialized()
         editorContextMenu->addSeparator(analyzerContext);
 
         QAction *action = new QAction(tr("Profile Costs of This Function and Its Callees"), this);
-        action->setIcon(Utils::ThemeHelper::themedIcon(
-                            QLatin1String(Analyzer::Constants::ANALYZER_CONTROL_START_ICON)));
+        action->setIcon(Analyzer::Icons::ANALYZER_CONTROL_START.icon());
         connect(action, &QAction::triggered, cgTool,
                 &CallgrindTool::handleShowCostsOfFunction);
         Command *cmd = ActionManager::registerAction(action, "Analyzer.Callgrind.ShowCostsOfFunction",