From 0341f83ad1fdb868ee987bd8af0b1e621f7684a2 Mon Sep 17 00:00:00 2001
From: Cristian Adam <cristian.adam@qt.io>
Date: Tue, 29 Mar 2022 20:09:02 +0200
Subject: [PATCH] CMakePM: Fix disappearing of the CMake settings page

The ProjectExplorer::Task::Error will result in having
m_kitErrorsForProject in targetsettingspanel.cpp which in
TargetItem::updateSubItems() recreates the build settings page.

By reporting the CMake project loading as Task::Warning the above
case is avoided the project build settings page is not
disappearing anymore.

Change-Id: Ib2523e6ea86fe5ad6e4bbee4e101b47cb350a68d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
index c4d2127573b..99cb43eab40 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
@@ -514,7 +514,7 @@ void CMakeBuildSystem::combineScanAndParse(bool restoredFromBackup)
 
             if (restoredFromBackup)
                 project()->addIssue(
-                    CMakeProject::IssueType::Error,
+                    CMakeProject::IssueType::Warning,
                     tr("<b>CMake configuration failed<b>"
                        "<p>The backup of the previous configuration has been restored.</p>"
                        "<p>Have a look at the Issues pane or in the \"Projects > Build\" settings "
@@ -532,7 +532,7 @@ void CMakeBuildSystem::combineScanAndParse(bool restoredFromBackup)
             updateFallbackProjectData();
 
             project()->addIssue(
-                CMakeProject::IssueType::Error,
+                CMakeProject::IssueType::Warning,
                 tr("<b>Failed to load project<b>"
                    "<p>Have a look at the Issues pane or in the \"Projects > Build\" settings "
                    "for more information about the failure.</p"));