From 03447f173408e1ba3c617f3682b0cf538f0c44a1 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 9 Nov 2018 13:49:58 +0100 Subject: [PATCH] Debugger: Code cosmetics Remove dead code Change-Id: I07c30fdd777f2bdaf7695d740448fffb65349e9c Reviewed-by: Christian Stenger --- src/plugins/debugger/debuggerplugin.cpp | 40 ------------------------- 1 file changed, 40 deletions(-) diff --git a/src/plugins/debugger/debuggerplugin.cpp b/src/plugins/debugger/debuggerplugin.cpp index 480be5db516..21a45c293d6 100644 --- a/src/plugins/debugger/debuggerplugin.cpp +++ b/src/plugins/debugger/debuggerplugin.cpp @@ -1065,13 +1065,6 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments, m_engineManagerWindow->setWindowTitle(tr("Debugger Perspectives")); m_engineManagerWindow->setObjectName(DOCKWIDGET_ENGINEMANAGER); - //act = m_snapshotAction = new QAction(tr("Create Snapshot"), this); - //act->setProperty(Role, RequestCreateSnapshotRole); - //act->setIcon(Icons::SNAPSHOT.icon()); - -// connect(act, &QAction::triggered, -// this, &DebuggerPluginPrivate::handleOperateByInstructionTriggered); - // Logging m_globalLogWindow = new GlobalLogWindow; @@ -1290,22 +1283,11 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments, debugMenu->addSeparator(); - //cmd = ActionManager::registerAction(m_snapshotAction, - // "Debugger.Snapshot", cppDebuggercontext); - //cmd->setDefaultKeySequence(QKeySequence(tr("Ctrl+D,Ctrl+S"))); - //cmd->setAttribute(Command::CA_Hide); - //debugMenu->addAction(cmd); - ActionManager::registerAction(&m_frameDownAction, "Debugger.FrameDown", cppDebuggercontext); ActionManager::registerAction(&m_frameUpAction, "Debugger.FrameUp", cppDebuggercontext); -// cmd = ActionManager::registerAction(action(OperateByInstruction), -// Constants::OPERATE_BY_INSTRUCTION, cppDebuggercontext); -// cmd->setAttribute(Command::CA_Hide); -// debugMenu->addAction(cmd); - cmd = ActionManager::registerAction(&m_breakAction, "Debugger.ToggleBreak"); cmd->setDefaultKeySequence(QKeySequence(useMacShortcuts ? tr("F8") : tr("F9"))); debugMenu->addAction(cmd); @@ -1314,14 +1296,6 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments, debugMenu->addSeparator(); - // currently broken -// auto qmlUpdateOnSaveDummyAction = new QAction(tr("Apply Changes on Save"), this); -// qmlUpdateOnSaveDummyAction->setCheckable(true); -// qmlUpdateOnSaveDummyAction->setIcon(Icons::APPLY_ON_SAVE.icon()); -// qmlUpdateOnSaveDummyAction->setEnabled(false); -// cmd = ActionManager::registerAction(qmlUpdateOnSaveDummyAction, Constants::QML_UPDATE_ON_SAVE); -// debugMenu->addAction(cmd); - auto qmlShowAppOnTopDummyAction = new QAction(tr("Show Application on Top"), this); qmlShowAppOnTopDummyAction->setCheckable(true); qmlShowAppOnTopDummyAction->setIcon(Icons::APP_ON_TOP.icon()); @@ -1398,24 +1372,10 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments, m_perspective.useSubPerspectiveSwitcher(EngineManager::engineChooser()); m_perspective.addToolBarAction(&m_startAction); -// QAction *operateByInstructionAction = action(OperateByInstruction); -// operateByInstructionAction->setText(tr("Start in Operate by Instruction mode")); - - -// QAction *enableReverseDebuggingAction = action(EnableReverseDebugging); -// enableReverseDebuggingAction->setText(tr("Start with recording information to reverse step if possible")); -//// Icons::SINGLE_INSTRUCTION_MODE.icon()}; -// Action m_enableReverseDebuggingAction{tr("Start with recording information to reverse step if possible"), -// Icons::REVERSE_MODE.icon()} -// m_perspective.addToolbarAction(operateByInstructionAction); - m_perspective.addWindow(m_breakpointManagerWindow, Perspective::SplitVertical, nullptr); m_perspective.addWindow(m_globalLogWindow, Perspective::SplitHorizontal, m_breakpointManagerWindow, false); m_perspective.addWindow(m_engineManagerWindow, Perspective::AddToTab, m_globalLogWindow); -// connect(action(EnableReverseDebugging), &SavedAction::valueChanged, -// this, &DebuggerPluginPrivate::enableReverseDebuggingTriggered); - setInitialState(); connect(SessionManager::instance(), &SessionManager::startupProjectChanged,