From 034fb098bca036135bf50108811932da7bab7000 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Sat, 24 May 2025 14:39:57 +0200
Subject: [PATCH] QmlDesigner: Reorder code to improve hits

isQtQuickState() is expensive. So isBaseState should be called first.
Which is quite probable anyway.

Change-Id: I86661c42f8d4ddffa9f0af75aa75ea083c7c9ba4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 src/plugins/qmldesigner/qmltools/qmlstate.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/qmldesigner/qmltools/qmlstate.cpp b/src/plugins/qmldesigner/qmltools/qmlstate.cpp
index cd2dbc61d9e..2ed06af6585 100644
--- a/src/plugins/qmldesigner/qmltools/qmlstate.cpp
+++ b/src/plugins/qmldesigner/qmltools/qmlstate.cpp
@@ -297,7 +297,7 @@ bool QmlModelState::isValidQmlModelState(const ModelNode &modelNode, SL sl)
                                keyValue("caller location", sl)};
 
     return isValidQmlModelNodeFacade(modelNode)
-           && (modelNode.metaInfo().isQtQuickState() || isBaseState(modelNode));
+           && (isBaseState(modelNode) || modelNode.metaInfo().isQtQuickState());
 }
 
 /**