feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

JsonWizard: Allow for variables in features passed to KitsPage

Browse Source 
Change-Id: I8c0d6b8b6e46d2de7cd4b088c7c98c2efe57427f
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-06-24 16:14:45 +02:00
parent 57d652743e
commit 040a0f2d30
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/jsonwizard/jsonkitspage.cpp
View File

@@ -145,7 +145,7 @@ FeatureSet JsonKitsPage::evaluate(const QVector<JsonKitsPage::ConditionalFeature
FeatureSet features; FeatureSet features;
foreach (const ConditionalFeature &f, list) { foreach (const ConditionalFeature &f, list) {
if (JsonWizard::boolFromVariant(f.condition, wiz->expander())) if (JsonWizard::boolFromVariant(f.condition, wiz->expander()))
features |= f.feature; features |= Feature::fromString(wiz->expander()->expand(f.feature));
} }
return features; return features;
} }
@@ -167,7 +167,7 @@ QVector<JsonKitsPage::ConditionalFeature> JsonKitsPage::parseFeatures(const QVar
foreach (const QVariant &element, data.toList()) { foreach (const QVariant &element, data.toList()) {
if (element.type() == QVariant::String) { if (element.type() == QVariant::String) {
result.append({ Feature::fromString(element.toString()), QVariant(true) }); result.append({ element.toString(), QVariant(true) });
} else if (element.type() == QVariant::Map) { } else if (element.type() == QVariant::Map) {
const QVariantMap obj = element.toMap(); const QVariantMap obj = element.toMap();
const QString feature = obj.value(QLatin1String(KEY_FEATURE)).toString(); const QString feature = obj.value(QLatin1String(KEY_FEATURE)).toString();
@@ -177,7 +177,7 @@ QVector<JsonKitsPage::ConditionalFeature> JsonKitsPage::parseFeatures(const QVar
return QVector<ConditionalFeature>(); return QVector<ConditionalFeature>();
} }
result.append({ Feature::fromString(feature), obj.value(QLatin1String(KEY_CONDITION), true) }); result.append({ feature, obj.value(QLatin1String(KEY_CONDITION), true) });
} else { } else {
if (errorMessage) if (errorMessage)
*errorMessage = tr("Feature list element is not a string or object."); *errorMessage = tr("Feature list element is not a string or object.");

4
src/plugins/projectexplorer/jsonwizard/jsonkitspage.h
View File

@@ -58,10 +58,10 @@ public:
class ConditionalFeature { class ConditionalFeature {
public: public:
ConditionalFeature() = default; ConditionalFeature() = default;
ConditionalFeature(const Core::Feature &f, const QVariant &c) : feature(f), condition(c) ConditionalFeature(const QString &f, const QVariant &c) : feature(f), condition(c)
{ } { }
Core::Feature feature; QString feature;
QVariant condition; QVariant condition;
}; };
static QVector<ConditionalFeature> parseFeatures(const QVariant &data, static QVector<ConditionalFeature> parseFeatures(const QVariant &data,