From 040ef3b7d30541b2cfe8ece14eb8558e5ebd4b2e Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Thu, 26 Jan 2023 15:22:23 +0100
Subject: [PATCH] Docker: Use a optional<Environment> to handle the non-fetched
 state

Change-Id: I93ef9da6c9c7731b28f9d6fab6413ce9c4f428b4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
---
 src/plugins/docker/dockerdevice.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/plugins/docker/dockerdevice.cpp b/src/plugins/docker/dockerdevice.cpp
index 91c315967bb..aaa9fd3a1ea 100644
--- a/src/plugins/docker/dockerdevice.cpp
+++ b/src/plugins/docker/dockerdevice.cpp
@@ -198,7 +198,7 @@ public:
 
     QString m_container;
 
-    Environment m_cachedEnviroment;
+    std::optional<Environment> m_cachedEnviroment;
     bool m_isShutdown = false;
     DockerDeviceFileAccess m_fileAccess{this};
 };
@@ -500,7 +500,7 @@ void DockerDevicePrivate::stopCurrentContainer()
 
     proc.runBlocking();
 
-    m_cachedEnviroment.clear();
+    m_cachedEnviroment.reset();
 }
 
 bool DockerDevicePrivate::prepareForBuild(const Target *target)
@@ -1137,11 +1137,11 @@ bool DockerDevicePrivate::addTemporaryMount(const FilePath &path, const FilePath
 
 Environment DockerDevicePrivate::environment()
 {
-    if (!m_cachedEnviroment.hasChanges())
+    if (!m_cachedEnviroment)
         fetchSystemEnviroment();
 
-    QTC_CHECK(m_cachedEnviroment.hasChanges());
-    return m_cachedEnviroment;
+    QTC_ASSERT(m_cachedEnviroment, return {});
+    return m_cachedEnviroment.value();
 }
 
 void DockerDevicePrivate::shutdown()