feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditor: Simplify internals

Browse Source 
Don't pass startupFile arg on every setDiffFiles.
Provide a setStartupFile() separate setter inside
DiffEditorDocument and call it directly from
DiffEditorController::setStartupFile().

Correct updateDescription() implementation.

Change-Id: Ie489431632bdabc61e2c692d09caf7b2e3990764
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-12-14 09:10:46 +01:00
parent ac7a582ca9
commit 042087ab1d
8 changed files with 27 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/diffeditor/diffeditorcontroller.h
View File

@@ -66,9 +66,9 @@ protected:
void setReloader(const std::function<void ()> &reloader);
void reloadFinished(bool success);
void setStartupFile(const QString &startupFile);
void setDiffFiles(const QList<FileData> &diffFileList,
const Utils::FilePath &baseDirectory = {},
const QString &startupFile = {});
const Utils::FilePath &baseDirectory = {});
void setDescription(const QString &description);
QString description() const;
void forceContextLineCount(int lines);