From 04362afed277b077b47d87d7cdec33fc752bb892 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 27 Dec 2021 11:27:28 +0100 Subject: [PATCH] Make connParams a const member Change-Id: I1dc75414766b9ec6c16a1c7080878da51310863c Reviewed-by: Qt CI Bot Reviewed-by: Artem Sokolovskii Reviewed-by: hjk --- src/libs/ssh/sshconnection.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/libs/ssh/sshconnection.cpp b/src/libs/ssh/sshconnection.cpp index a6f9ccc0357..cbbede6cacc 100644 --- a/src/libs/ssh/sshconnection.cpp +++ b/src/libs/ssh/sshconnection.cpp @@ -88,6 +88,9 @@ bool operator!=(const SshConnectionParameters &p1, const SshConnectionParameters struct SshConnection::SshConnectionPrivate { + SshConnectionPrivate(const SshConnectionParameters &sshParameters) + : connParams(sshParameters) {} + QString fullProcessError() { QString error; @@ -149,7 +152,7 @@ struct SshConnection::SshConnectionPrivate return connectionOptions(binary) << connParams.host(); } - SshConnectionParameters connParams; + const SshConnectionParameters connParams; SshConnectionInfo connInfo; SshProcess masterProcess; QString errorString; @@ -160,11 +163,10 @@ struct SshConnection::SshConnectionPrivate SshConnection::SshConnection(const SshConnectionParameters &serverInfo, QObject *parent) - : QObject(parent), d(new SshConnectionPrivate) + : QObject(parent), d(new SshConnectionPrivate(serverInfo)) { qRegisterMetaType("QSsh::SftpFileInfo"); qRegisterMetaType >("QList"); - d->connParams = serverInfo; connect(&d->masterProcess, &QtcProcess::readyReadStandardOutput, [this] { const QByteArray reply = d->masterProcess.readAllStandardOutput(); if (reply == "\n")